public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/49169] ARM: optimisations strip the Thumb/ARM mode bit off function pointers
Date: Thu, 26 May 2011 08:22:00 -0000	[thread overview]
Message-ID: <bug-49169-4-w2PMh20Uns@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-49169-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49169

--- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-05-26 08:20:22 UTC ---
There are several places in the compiler where we assume DECL_ALIGN
constraints the lower bits of the address of the DECL.

See several similar bugs in the past (PR47239 comes to my mind).

fold-const.c:get_pointer_modulus_and_residue looks suspicious to me here,
so you might want to try

Index: gcc/fold-const.c
===================================================================
--- gcc/fold-const.c    (revision 174266)
+++ gcc/fold-const.c    (working copy)
@@ -9219,7 +9219,8 @@ get_pointer_modulus_and_residue (tree ex
   *residue = 0;

   code = TREE_CODE (expr);
-  if (code == ADDR_EXPR)
+  if (code == ADDR_EXPR
+      && TREE_CODE (TREE_OPERAND (expr, 0)) != FUNCTION_DECL)
     {
       unsigned int bitalign;
       bitalign = get_object_alignment_1 (TREE_OPERAND (expr, 0), residue);


  parent reply	other threads:[~2011-05-26  8:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26  2:23 [Bug rtl-optimization/49169] New: " michael.hope at linaro dot org
2011-05-26  7:59 ` [Bug rtl-optimization/49169] " mikpe at it dot uu.se
2011-05-26  8:22 ` rguenth at gcc dot gnu.org [this message]
2011-05-26  8:48 ` rguenth at gcc dot gnu.org
2011-06-07  7:33 ` rsandifo at gcc dot gnu.org
2011-06-27  9:34 ` rsandifo at gcc dot gnu.org
2011-07-08 15:05 ` ramana at gcc dot gnu.org
2011-09-19  9:00 ` jye2 at gcc dot gnu.org
2012-07-31  1:00 ` ramana at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-49169-4-w2PMh20Uns@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).