From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8913 invoked by alias); 14 Oct 2011 23:06:54 -0000 Received: (qmail 8905 invoked by uid 22791); 14 Oct 2011 23:06:54 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Oct 2011 23:06:40 +0000 From: "kkojima at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/49263] SH Target: underutilized "TST #imm, R0" instruction Date: Fri, 14 Oct 2011 23:06:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: kkojima at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg01430.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D49263 --- Comment #12 from Kazumoto Kojima 2011-10-1= 4 23:06:06 UTC --- (In reply to comment #11) > Created attachment 25491 [details] > Proposed patch including test case Looks fine. A very minor style nits: > + if (GET_CODE (XEXP (x, 0)) =3D=3D AND /* tst instruction. */ This comment looks a bit bogus. A full sentence comment would be better. > + > + There are some extra empty lines. GNU/GCC coding style says that only one empty line is needed. I know that there are extra empty lines already, but we should not add new ones :-)