[Bug libstdc++/49293] New: 22_locale/time_get/get_weekday/char/38081-[12].cc fail with glibc 2.14

[Bug libstdc++/49293] New: 22_locale/time_get/get_weekday/char/38081-[12].cc fail with glibc 2.14

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49293

           Summary: 22_locale/time_get/get_weekday/char/38081-[12].cc fail
                    with glibc 2.14
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com


On Linux/x86, with glibc 2.14, I got

FAIL: 22_locale/time_get/get_weekday/char/38081-1.cc execution test
FAIL: 22_locale/time_get/get_weekday/char/38081-2.cc execution test

[Bug libstdc++/49293] 22_locale/time_get/get_weekday/char/38081-[12].cc fail with glibc 2.14

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49293

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-06-05 22:28:03 UTC ---
I think that the only possible explanation is that something changed in the
locale data for "ru_RU.ISO-8859-5". I don't have ready at hand a glibc 2.14
system, if somebody can check what has changed in the names of those weekdays
the fix is certainly simple only matter of tweaking the testcases to allow both
the old and the new names. Maybe Jakub can also help.

[Bug libstdc++/49293] 22_locale/time_get/get_weekday/char/38081-[12].cc fail with glibc 2.14

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49293

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-06-06 06:17:14 UTC ---
Yeah, the locale changed:
http://sources.redhat.com/git/?p=glibc.git;a=commitdiff;h=f49839299a085505eb673544744b61d2d9cdd1db
I think it is a mistake to use variable length abmon, especially if some abmon
names are 5 characters long which isn't really abbreviation anymore, and to add
a useless dot to make it even longer, but ru_RU isn't the first locale to make
such a change.

[Bug libstdc++/49293] 22_locale/time_get/get_weekday/char/38081-[12].cc fail with glibc 2.14

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49293

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-06-06 10:41:48 UTC ---
Created attachment 24446
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24446
Draft patch

[Bug libstdc++/49293] 22_locale/time_get/get_weekday/char/38081-[12].cc fail with glibc 2.14

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49293

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.06.06 10:42:46
         AssignedTo|unassigned at gcc dot       |paolo.carlini at oracle dot
                   |gnu.org                     |com
     Ever Confirmed|0                           |1

--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-06-06 10:42:46 UTC ---
Thanks Jakub. The patchlet I have just attached should do the trick, then. If
somebody would be so kind to test it...

[Bug libstdc++/49293] 22_locale/time_get/get_weekday/char/38081-[12].cc fail with glibc 2.14

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49293

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-06-07 08:46:17 UTC ---
I guess I'm going to commit my patchlet, in case issues remain should be just
matter of tweaking a few chars in the strings, patch preapproved.

[Bug libstdc++/49293] 22_locale/time_get/get_weekday/char/38081-[12].cc fail with glibc 2.14

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49293

--- Comment #6 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-06-07 08:50:08 UTC ---
Author: paolo
Date: Tue Jun  7 08:50:04 2011
New Revision: 174737

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=174737
Log:
2011-06-07  Paolo Carlini  <paolo.carlini@oracle.com>

    PR libstdc++/49293
    * testsuite/22_locale/time_get/get_weekday/char/38081-1.cc: Tweak
    for glibc 2.14.
    * testsuite/22_locale/time_get/get_weekday/char/38081-2.cc: Likewise.


Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/testsuite/22_locale/time_get/get_weekday/char/38081-1.cc
    trunk/libstdc++-v3/testsuite/22_locale/time_get/get_weekday/char/38081-2.cc

[Bug libstdc++/49293] 22_locale/time_get/get_weekday/char/38081-[12].cc fail with glibc 2.14

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49293

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.0

--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-06-07 08:52:19 UTC ---
Done.

[Bug libstdc++/49293] 22_locale/time_get/get_weekday/char/38081-[12].cc fail with glibc 2.14

[uros at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49293

--- Comment #8 from uros at gcc dot gnu.org 2011-07-22 16:47:24 UTC ---
Author: uros
Date: Fri Jul 22 16:47:20 2011
New Revision: 176643

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176643
Log:
    Backport from mainline
    2011-06-07  Paolo Carlini  <paolo.carlini@oracle.com>

    PR libstdc++/49293
    * testsuite/22_locale/time_get/get_weekday/char/38081-1.cc: Tweak
    for glibc 2.14.
    * testsuite/22_locale/time_get/get_weekday/char/38081-2.cc: Likewise.


Modified:
    branches/gcc-4_6-branch/libstdc++-v3/ChangeLog
   
branches/gcc-4_6-branch/libstdc++-v3/testsuite/22_locale/time_get/get_weekday/char/38081-1.cc
   
branches/gcc-4_6-branch/libstdc++-v3/testsuite/22_locale/time_get/get_weekday/char/38081-2.cc

[Bug libstdc++/49293] 22_locale/time_get/get_weekday/char/38081-[12].cc fail with glibc 2.14

[uros at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49293

--- Comment #9 from uros at gcc dot gnu.org 2011-07-24 21:50:51 UTC ---
Author: uros
Date: Sun Jul 24 21:50:48 2011
New Revision: 176719

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176719
Log:
    Backport from mainline
    2011-06-07  Paolo Carlini  <paolo.carlini@oracle.com>

    PR libstdc++/49293
    * testsuite/22_locale/time_get/get_weekday/char/38081-1.cc: Tweak
    for glibc 2.14.
    * testsuite/22_locale/time_get/get_weekday/char/38081-2.cc: Likewise.


Modified:
    branches/gcc-4_5-branch/libstdc++-v3/ChangeLog
   
branches/gcc-4_5-branch/libstdc++-v3/testsuite/22_locale/time_get/get_weekday/char/38081-1.cc
   
branches/gcc-4_5-branch/libstdc++-v3/testsuite/22_locale/time_get/get_weekday/char/38081-2.cc