[Bug middle-end/49373] New: [4.7 Regression] Many testcase failures

[Bug middle-end/49373] New: [4.7 Regression] Many testcase failures

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

           Summary: [4.7 Regression] Many testcase failures
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com


On Linux/ia32, revision 174952 gave

FAIL: g++.dg/lto/20081118-1 cp_lto_20081118-1_0.o-cp_lto_20081118-1_1.o link,
-O0 -flto
FAIL: g++.dg/lto/20081118-1 cp_lto_20081118-1_0.o-cp_lto_20081118-1_1.o link,
-O0 -flto -flto-partition=1to1 
FAIL: g++.dg/lto/20081118-1 cp_lto_20081118-1_0.o-cp_lto_20081118-1_1.o link,
-O0 -flto -flto-partition=none 
FAIL: g++.dg/lto/20081118-1 cp_lto_20081118-1_0.o-cp_lto_20081118-1_1.o link,
-O2 -flto
FAIL: g++.dg/lto/20081118-1 cp_lto_20081118-1_0.o-cp_lto_20081118-1_1.o link,
-O2 -flto -flto-partition=1to1 
FAIL: g++.dg/lto/20081118-1 cp_lto_20081118-1_0.o-cp_lto_20081118-1_1.o link,
-O2 -flto -flto-partition=none 
FAIL: g++.dg/lto/20100302 cp_lto_20100302_0.o-cp_lto_20100302_1.o link, -flto
-fabi-version=2
FAIL: g++.dg/torture/pr40389.C  -O2 -flto  execution test
FAIL: g++.dg/torture/pr40389.C  -O2 -flto -flto-partition=none  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -O1  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -O2  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -O3 -fomit-frame-pointer  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -O3 -g  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -Os  execution test
FAIL: gcc.c-torture/execute/builtins/strlen-3.c execution,  -O2 -flto 
FAIL: gcc.c-torture/execute/builtins/strlen-3.c execution,  -O2 -flto
-flto-partition=none 
FAIL: gcc.dg/guality/vla-1.c  -O2 -flto  line 17 sizeof (a) == 6
FAIL: gcc.dg/guality/vla-1.c  -O2 -flto -flto-partition=none  line 17 sizeof
(a) == 6

Revision 174911 is OK.

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org
   Target Milestone|---                         |4.7.0

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2011-06-11 16:07:50 UTC ---
Revision 174952:

http://gcc.gnu.org/ml/gcc-cvs/2011-06/msg00441.html

caused:

FAIL: g++.dg/torture/pr43879-1_1.C  -O1  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -O2  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -O3 -fomit-frame-pointer  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -O3 -g  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -Os  execution test

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> 2011-06-11 16:13:38 UTC ---
All most all failures are caused by revision 174952:

http://gcc.gnu.org/ml/gcc-cvs/2011-06/msg00441.html

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-11 17:08:08 UTC ---
The patch is expected to cause g++.dg/torture/pr43879-1_1.C.

I do not get the other LTO failures. Perhaps it depends whether or not one use
linker plugin. The final testing was done on gccfarm machines, so w/o plugin. 
What kind of error do you get there?

I will look into those tomorrow.
Honza

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> 2011-06-11 17:43:49 UTC ---
(In reply to comment #3)
> The patch is expected to cause g++.dg/torture/pr43879-1_1.C.
> 
> I do not get the other LTO failures. Perhaps it depends whether or not one use
> linker plugin. The final testing was done on gccfarm machines, so w/o plugin. 
> What kind of error do you get there?

I got

/tmp/ccdoubbY.lto.o: In function `C::~C()':^M
cp_lto_20081118-1_0.o:(.text+0x50): undefined reference to `C::~C()'^M
/tmp/ccdoubbY.lto.o: In function `D::~D()':^M
cp_lto_20081118-1_0.o:(.text+0xae): undefined reference to `C::~C()'^M
/tmp/ccdoubbY.lto.o:(.rodata+0x10): undefined reference to `C::~C()'^M
collect2: error: ld returned 1 exit status^M

FAIL: g++.dg/lto/20081118-1 cp_lto_20081118-1_0.o-cp_lto_20081118-1_1.o link,
-O0 -flto -flto-partition=none

and

FAIL: gcc.c-torture/execute/builtins/strlen-3.c execution,  -O2 -flto
-flto-partition=none

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> 2011-06-11 17:51:29 UTC ---
Revision 174957 still gave:

FAIL: gcc.c-torture/execute/builtins/strlen-3.c execution,  -O2 -flto 
FAIL: gcc.c-torture/execute/builtins/strlen-3.c execution,  -O2 -flto
-flto-partition=none 
FAIL: gcc.dg/guality/vla-1.c  -O2 -flto -flto-partition=none  line 17 sizeof
(a) == 6
FAIL: gcc.dg/guality/vla-1.c  -O2 -flto  line 17 sizeof (a) == 6
FAIL: g++.dg/torture/pr43879-1_1.C  -O1  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -O2  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -O3 -fomit-frame-pointer  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -O3 -g  execution test
FAIL: g++.dg/torture/pr43879-1_1.C  -Os  execution test

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

--- Comment #6 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-11 17:51:52 UTC ---
The first problem should be solved by:
        * lto-streamer-out.c (produce_symtab): Stream out the newly represented
        aliases.
The builtins failure is probably yet another manifestation of the fact that we
don't stream builtin decls correctly.  I will check...

Honza

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[laurent at guerby dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

Laurent GUERBY <laurent at guerby dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |laurent at guerby dot net

--- Comment #7 from Laurent GUERBY <laurent at guerby dot net> 2011-06-11 18:10:47 UTC ---
(In reply to comment #3)
> The patch is expected to cause g++.dg/torture/pr43879-1_1.C.
> 
> I do not get the other LTO failures. Perhaps it depends whether or not one use
> linker plugin. The final testing was done on gccfarm machines, so w/o plugin. 
> What kind of error do you get there?
> 
> I will look into those tomorrow.
> Honza

Hi Honza,

What cfarm machine did you use for testing? gcc20 has binutils 2.20.1 whereas
gcc16 has 2.18.1.

Thanks!

Laurent

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

--- Comment #8 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-12 20:39:01 UTC ---
Author: hubicka
Date: Sun Jun 12 20:38:57 2011
New Revision: 174972

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=174972
Log:
    PR middle-end/49373
    * ipa.c (cgraph_externally_visible_p): Check resolution info.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa.c

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hp at gcc dot gnu.org

--- Comment #9 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2011-06-13 02:14:23 UTC ---
(In reply to comment #3)
> The patch is expected to cause g++.dg/torture/pr43879-1_1.C.

If it's expected, then xfail it.

The regression is still there at r174974, at least for cris-elf.

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

--- Comment #10 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2011-06-22 21:38:23 UTC ---
Author: hp
Date: Wed Jun 22 21:38:20 2011
New Revision: 175317

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175317
Log:
    PR middle-end/49373
    * g++.dg/torture/pr43879-1_1.C: Xfail for -O1 and above, except -flto.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/torture/pr43879-1_1.C

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |xfail
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.06.23 11:40:14
     Ever Confirmed|0                           |1

--- Comment #11 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-06-23 11:40:14 UTC ---
Now XFAILed (parts).

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

--- Comment #12 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2011-06-23 11:52:22 UTC ---
IIUC that's the remaining fail being xfailed; the others are fully covered by
the earlier commits.

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

--- Comment #13 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-23 16:45:15 UTC ---
Author: hubicka
Date: Thu Jun 23 16:45:08 2011
New Revision: 175336

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175336
Log:
    PR tree-optimize/49373
    * tree-pass.h (all_late_ipa_passes): Declare.
    * cgraphunit.c (init_lowered_empty_function): Fix properties.
    (cgraph_optimize): Execute late passes; remove unreachable funcions after
    materialization.
    * ipa-inline.c (gate_ipa_inline): Enable only when optimizing or LTOing.
    * passes.c (all_late_ipa_passes): Declare.
    (dump_passes, register_pass): Handle late ipa passes.
    (init_optimization_passes): Move ipa_pta to late passes; schedule fixup_cfg
    at beggining of all_passes.
    (apply_ipa_transforms): New function.
    (execute_one_pass): When doing simple ipa pass, apply all transforms.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cgraphunit.c
    trunk/gcc/ipa-inline.c
    trunk/gcc/passes.c
    trunk/gcc/tree-pass.h

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

--- Comment #14 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-23 19:41:30 UTC ---
Author: hubicka
Date: Thu Jun 23 19:41:26 2011
New Revision: 175350

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175350
Log:
    PR middle-end/49373
    * g++.dg/torture/pr43879-1_1.C: Revert the xfail introduced yesterday.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/torture/pr43879-1_1.C

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at redhat dot com

--- Comment #15 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-23 19:52:02 UTC ---
OK, I think all the problems are fixed with exception of 

FAIL: gcc.dg/guality/vla-1.c  -O2 -flto  line 17 sizeof (a) == 6
FAIL: gcc.dg/guality/vla-1.c  -O2 -flto -flto-partition=none  line 17 sizeof

Jakub, do you have any idea what gets wrong here? vla-2.c fails with LTO for a
while and I don't see what can possibly be affected by the patch of mine.

Honza

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #16 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-06-24 12:54:39 UTC ---
This is a bug in lto-streamer-out.c.  TYPE_MAXVAL of the ARRAY_TYPE's
TYPE_DOMAIN e.g. in f1 is a VAR_DECL (DECL_NAME is NULL, DECL_ARTIFICIAL, but
!DECL_IGNORED_P).  It is first encountered in a GIMPLE_DEBUG's first operand,
it hasn't been seen yet, so that VAR_DECL is output.  But, later on
write_global_stream calls lto_output_tree on the VLA ARRAY_TYPE, with ref_p set
to false, and this eventually calls lto_output_tree on that VAR_DECL again.
But this doesn't find it in ob->writer_cache, because the cache has been
destroyed in between, from output_function -> destroy_output_block ->
lto_streamer_cache_delete.
I guess VLA types need to be emitted immediately in the containing function,
rather than being deferred to be written much later on globally.

[Bug middle-end/49373] [4.7 Regression] Many testcase failures

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49373

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
             Blocks|49945                       |
         Resolution|                            |FIXED

--- Comment #17 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-08-02 14:20:17 UTC ---
Let's track the debuginfo bug elsewhere, it doesn't sound like a new issue.