public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/49412] New: __dso_handle should be hidden
@ 2011-06-15 0:21 hjl.tools at gmail dot com
2011-06-15 4:12 ` [Bug c++/49412] " jason at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: hjl.tools at gmail dot com @ 2011-06-15 0:21 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49412
Summary: __dso_handle should be hidden
Product: gcc
Version: 4.7.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c++
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: hjl.tools@gmail.com
CC: jason@redhat.com
__dso_handle is always defined locally and hidden if
HAVE_GAS_HIDDEN is set. Does this patch:
diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c
index f4988f9..17ba539 100644
--- a/gcc/cp/decl.c
+++ b/gcc/cp/decl.c
@@ -6435,6 +6435,11 @@ get_dso_handle_node (void)
dso_handle_node = declare_global_var (get_identifier ("__dso_handle"),
ptr_type_node);
+#ifdef HAVE_GAS_HIDDEN
+ DECL_VISIBILITY (dso_handle_node) = VISIBILITY_HIDDEN;
+ DECL_VISIBILITY_SPECIFIED (dso_handle_node) = 1;
+#endif
+
return dso_handle_node;
}
make any senses?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug c++/49412] __dso_handle should be hidden
2011-06-15 0:21 [Bug c++/49412] New: __dso_handle should be hidden hjl.tools at gmail dot com
@ 2011-06-15 4:12 ` jason at gcc dot gnu.org
2011-06-15 13:14 ` hjl.tools at gmail dot com
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: jason at gcc dot gnu.org @ 2011-06-15 4:12 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49412
Jason Merrill <jason at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jason at gcc dot gnu.org
--- Comment #1 from Jason Merrill <jason at gcc dot gnu.org> 2011-06-15 04:11:14 UTC ---
Seems reasonable.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug c++/49412] __dso_handle should be hidden
2011-06-15 0:21 [Bug c++/49412] New: __dso_handle should be hidden hjl.tools at gmail dot com
2011-06-15 4:12 ` [Bug c++/49412] " jason at gcc dot gnu.org
@ 2011-06-15 13:14 ` hjl.tools at gmail dot com
2011-06-15 15:51 ` hjl at gcc dot gnu.org
2011-06-15 16:02 ` hjl.tools at gmail dot com
3 siblings, 0 replies; 5+ messages in thread
From: hjl.tools at gmail dot com @ 2011-06-15 13:14 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49412
H.J. Lu <hjl.tools at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |http://gcc.gnu.org/ml/gcc-p
| |atches/2011-06/msg01153.htm
| |l
--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> 2011-06-15 13:14:08 UTC ---
A patch is posted at
http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01153.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug c++/49412] __dso_handle should be hidden
2011-06-15 0:21 [Bug c++/49412] New: __dso_handle should be hidden hjl.tools at gmail dot com
2011-06-15 4:12 ` [Bug c++/49412] " jason at gcc dot gnu.org
2011-06-15 13:14 ` hjl.tools at gmail dot com
@ 2011-06-15 15:51 ` hjl at gcc dot gnu.org
2011-06-15 16:02 ` hjl.tools at gmail dot com
3 siblings, 0 replies; 5+ messages in thread
From: hjl at gcc dot gnu.org @ 2011-06-15 15:51 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49412
--- Comment #3 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> 2011-06-15 15:50:28 UTC ---
Author: hjl
Date: Wed Jun 15 15:50:22 2011
New Revision: 175080
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175080
Log:
Mark __dso_handle hidden if assembler supports it.
2011-06-15 H.J. Lu <hongjiu.lu@intel.com>
PR c++/49412
* decl.c (get_dso_handle_node): Mark __dso_handle hidden if
assembler supports hidden visibility.
Modified:
trunk/gcc/cp/ChangeLog
trunk/gcc/cp/decl.c
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug c++/49412] __dso_handle should be hidden
2011-06-15 0:21 [Bug c++/49412] New: __dso_handle should be hidden hjl.tools at gmail dot com
` (2 preceding siblings ...)
2011-06-15 15:51 ` hjl at gcc dot gnu.org
@ 2011-06-15 16:02 ` hjl.tools at gmail dot com
3 siblings, 0 replies; 5+ messages in thread
From: hjl.tools at gmail dot com @ 2011-06-15 16:02 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49412
H.J. Lu <hjl.tools at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.7.0
--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> 2011-06-15 16:02:12 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-06-15 16:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-15 0:21 [Bug c++/49412] New: __dso_handle should be hidden hjl.tools at gmail dot com
2011-06-15 4:12 ` [Bug c++/49412] " jason at gcc dot gnu.org
2011-06-15 13:14 ` hjl.tools at gmail dot com
2011-06-15 15:51 ` hjl at gcc dot gnu.org
2011-06-15 16:02 ` hjl.tools at gmail dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).