[Bug fortran/49417] New: [4.6/4.7 Regression] [OOP] ICE on invalid CLASS component declaration

[Bug fortran/49417] New: [4.6/4.7 Regression] [OOP] ICE on invalid CLASS component declaration

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49417

           Summary: [4.6/4.7 Regression] [OOP] ICE on invalid CLASS
                    component declaration
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: janus@gcc.gnu.org


Reported by Andrew Benson at
http://gcc.gnu.org/ml/fortran/2011-06/msg00119.html:


module Nodes

 type :: nodeWrapper
 end type nodeWrapper

 type, extends(nodeWrapper) :: treeNode
    class(nodeWrapper) :: subComponent
 end type treeNode

end module Nodes


ICEs with 4.6 and 4.7 trunk, while it is correctly rejected with 4.5.

[Bug fortran/49417] [4.6/4.7 Regression] [OOP] ICE on invalid CLASS component declaration

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49417

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code
                 CC|                            |burnus at gcc dot gnu.org
   Target Milestone|---                         |4.6.1

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-06-15 10:15:25 UTC ---
==15300== Invalid read of size 1
==15300==    at 0x502B83: parse_spec (parse.c:2110)
==15300==    by 0x503B42: gfc_parse_file (parse.c:4113)
==15300==    by 0x53D3F5: gfc_be_parse_file (f95-lang.c:250)

Which is parse_derived's (!)
2109         default:
2110           unexpected_statement (st);

[Bug fortran/49417] [4.6/4.7 Regression] [OOP] ICE on invalid CLASS component declaration

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49417

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.06.15 11:56:15
         AssignedTo|unassigned at gcc dot       |janus at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|4.6.1                       |---
     Ever Confirmed|0                           |1

--- Comment #2 from janus at gcc dot gnu.org 2011-06-15 11:56:15 UTC ---
Mine (I'm working on a patch). Apparently we fail to check for the 'class_ok'
attribute.

[Bug fortran/49417] [4.6/4.7 Regression] [OOP] ICE on invalid CLASS component declaration

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49417

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.6.1

[Bug fortran/49417] [4.6/4.7 Regression] [OOP] ICE on invalid CLASS component declaration

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49417

--- Comment #3 from janus at gcc dot gnu.org 2011-06-16 11:45:09 UTC ---
Author: janus
Date: Thu Jun 16 11:45:05 2011
New Revision: 175101

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175101
Log:
2011-06-16  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/49417
    * module.c (mio_component): Make sure the 'class_ok' attribute is set
    for use-associated CLASS components.
    * parse.c (parse_derived): Check for 'class_ok' attribute.
    * resolve.c (resolve_fl_derived): Ditto.

2011-06-16  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/49417
    * gfortran.dg/class_43.f03: New.

Added:
    trunk/gcc/testsuite/gfortran.dg/class_43.f03
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/module.c
    trunk/gcc/fortran/parse.c
    trunk/gcc/fortran/resolve.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/49417] [4.6 Regression] [OOP] ICE on invalid CLASS component declaration

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49417

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
            Summary|[4.6/4.7 Regression] [OOP]  |[4.6 Regression] [OOP] ICE
                   |ICE on invalid CLASS        |on invalid CLASS component
                   |component declaration       |declaration

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-06-18 17:12:50 UTC ---
Fixed for the trunk I assume.  Janus, if you want this to make into gcc
4.6.1-rc1, please commit on Monday or earlier.

[Bug fortran/49417] [4.6 Regression] [OOP] ICE on invalid CLASS component declaration

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49417

--- Comment #5 from janus at gcc dot gnu.org 2011-06-19 21:05:22 UTC ---
Author: janus
Date: Sun Jun 19 21:05:18 2011
New Revision: 175194

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175194
Log:
2011-06-19  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/47601
    * module.c (mio_component_ref): Handle components of extended types.
    * symbol.c (gfc_find_component): Return if sym is NULL.

    PR fortran/48699
    * check.c (gfc_check_move_alloc): If 'TO' argument is polymorphic,
    make sure the vtab is present.

    PR fortran/49074
    * interface.c (gfc_extend_assign): Propagate the locus from the
    assignment to the type-bound procedure call.

    PR fortran/49417
    * module.c (mio_component): Make sure the 'class_ok' attribute is set
    for use-associated CLASS components.
    * parse.c (parse_derived): Check for 'class_ok' attribute.
    * resolve.c (resolve_fl_derived): Ditto.


2011-06-19  Janus Weil  <janus@gcc.gnu.org>

    PR fortran/47601
    * gfortran.dg/extends_13.f03: New.

    PR fortran/48699
    * gfortran.dg/move_alloc_5.f90: New.

    PR fortran/49074
    * gfortran.dg/typebound_assignment_3.f03: New.

    PR fortran/49417
    * gfortran.dg/class_43.f03: New.

Added:
    branches/gcc-4_6-branch/gcc/testsuite/gfortran.dg/class_43.f03
    branches/gcc-4_6-branch/gcc/testsuite/gfortran.dg/extends_13.f03
    branches/gcc-4_6-branch/gcc/testsuite/gfortran.dg/move_alloc_5.f90
   
branches/gcc-4_6-branch/gcc/testsuite/gfortran.dg/typebound_assignment_3.f03
Modified:
    branches/gcc-4_6-branch/gcc/fortran/ChangeLog
    branches/gcc-4_6-branch/gcc/fortran/check.c
    branches/gcc-4_6-branch/gcc/fortran/interface.c
    branches/gcc-4_6-branch/gcc/fortran/module.c
    branches/gcc-4_6-branch/gcc/fortran/parse.c
    branches/gcc-4_6-branch/gcc/fortran/resolve.c
    branches/gcc-4_6-branch/gcc/fortran/symbol.c
    branches/gcc-4_6-branch/gcc/testsuite/ChangeLog

[Bug fortran/49417] [4.6 Regression] [OOP] ICE on invalid CLASS component declaration

[janus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49417

janus at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from janus at gcc dot gnu.org 2011-06-19 21:21:24 UTC ---
Fixed on trunk and 4.6. Closing.