[Bug c++/49440] New: Invalid dynamic_cast for unnamed namespace

[Bug c++/49440] New: Invalid dynamic_cast for unnamed namespace

[hordi at ukr dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49440

           Summary: Invalid dynamic_cast for unnamed namespace
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hordi@ukr.net


We have a base class, from this base class we are creating two classes in
unnamed namespace (each class in different *.cpp-file). After that we are
creating one from it and trying to dynamic_cast to other - in result this
operation is processed but should not. This code works properly for gcc-4.4.5
for example...

small description:

file: a.h

class Module{...}

Module *gp = 0;

file a.cpp
namespace
{
  class ItemModule : public Module{}
}

some code:
gp = new ItemModule();

file main.cpp
namespace
{
  class ItemModule : public Module{}
}

int main()
{
  ItemModule *p = dynamic_cast<ItemModule*>(gp);

  //I expect to see NULL, but have real address
  printf("%p\n",p);
}

[Bug c++/49440] Invalid dynamic_cast for unnamed namespace

[hordi at ukr dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49440

--- Comment #1 from Iurii Gordiienko <hordi at ukr dot net> 2011-06-16 13:22:31 UTC ---
4.5.1, 4.5.2 - same result

[Bug c++/49440] Invalid dynamic_cast for unnamed namespace

[hordi at ukr dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49440

--- Comment #2 from Iurii Gordiienko <hordi at ukr dot net> 2011-06-16 13:23:47 UTC ---
Created attachment 24546
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24546
small example for reprodusing

[Bug c++/49440] [4.5/4.6/4.7 regression] Invalid dynamic_cast for unnamed namespace

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49440

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.06.22 21:00:47
                 CC|                            |jason at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |jason at gcc dot gnu.org
                   |gnu.org                     |
            Summary|Invalid dynamic_cast for    |[4.5/4.6/4.7 regression]
                   |unnamed namespace           |Invalid dynamic_cast for
                   |                            |unnamed namespace
     Ever Confirmed|0                           |1

--- Comment #3 from Jason Merrill <jason at gcc dot gnu.org> 2011-06-22 21:00:47 UTC ---
This is related to the change to use string comparison for matching type_infos.
 We have a special case for file-local symbols, but aren't using it here for
some reason.

http://gcc.gnu.org/ml/gcc/2009-08/msg00258.html

[Bug c++/49440] [4.5/4.6/4.7 regression] Invalid dynamic_cast for unnamed namespace

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49440

--- Comment #4 from Jason Merrill <jason at gcc dot gnu.org> 2011-06-23 16:52:52 UTC ---
Author: jason
Date: Thu Jun 23 16:52:48 2011
New Revision: 175340

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175340
Log:
    PR c++/49440
    * class.c (set_linkage_according_to_type): Just check TREE_PUBLIC
    on the type's name.

Added:
    trunk/gcc/testsuite/g++.dg/rtti/anon-ns1.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/class.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/49440] [4.5/4.6/4.7 regression] Invalid dynamic_cast for unnamed namespace

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49440

--- Comment #5 from Jason Merrill <jason at gcc dot gnu.org> 2011-06-27 01:13:36 UTC ---
Author: jason
Date: Mon Jun 27 01:13:33 2011
New Revision: 175418

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175418
Log:
    PR c++/49440
    * class.c (set_linkage_according_to_type): Hand off to
    determine_visibility.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/g++.dg/rtti/anon-ns1.C
Modified:
    branches/gcc-4_5-branch/gcc/cp/ChangeLog
    branches/gcc-4_5-branch/gcc/cp/class.c
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog

[Bug c++/49440] [4.6 regression] Invalid dynamic_cast for unnamed namespace

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49440

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.4

[Bug c++/49440] [4.6 regression] Invalid dynamic_cast for unnamed namespace

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49440

--- Comment #6 from Jason Merrill <jason at gcc dot gnu.org> 2011-06-27 20:16:08 UTC ---
Author: jason
Date: Mon Jun 27 20:16:02 2011
New Revision: 175558

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175558
Log:
    PR c++/49440
    * class.c (set_linkage_according_to_type): Hand off to
    determine_visibility.

Added:
    branches/gcc-4_6-branch/gcc/testsuite/g++.dg/rtti/anon-ns1.C
Modified:
    branches/gcc-4_6-branch/gcc/cp/ChangeLog
    branches/gcc-4_6-branch/gcc/cp/class.c
    branches/gcc-4_6-branch/gcc/testsuite/ChangeLog

[Bug c++/49440] [4.6 regression] Invalid dynamic_cast for unnamed namespace

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49440

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Jason Merrill <jason at gcc dot gnu.org> 2011-06-27 20:18:40 UTC ---
Fixed for 4.5.4 and 4.6.2.