[Bug middle-end/49463] New: [4.7 Regression] LTO testcase failures

[Bug middle-end/49463] New: [4.7 Regression] LTO testcase failures

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

           Summary: [4.7 Regression] LTO testcase failures
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com
                CC: hubicka@gcc.gnu.org


On Linux/x86, revision 175169 gave:

FAIL: gcc.c-torture/execute/builtins/strstr-asm.c compilation,  -O2 -flto
FAIL: gcc.c-torture/execute/builtins/strstr-asm.c compilation,  -O2 -flto
-flto-partition=none
FAIL: gcc.dg/torture/tls/run-gd.c  -O2 -flto  (test for excess errors)
FAIL: gcc.dg/torture/tls/run-gd.c  -O2 -flto -flto-partition=none  (test for
excess errors)
FAIL: gcc.dg/torture/tls/run-ie.c  -O2 -flto  (test for excess errors)
FAIL: gcc.dg/torture/tls/run-ie.c  -O2 -flto -flto-partition=none  (test for
excess errors)
FAIL: gcc.dg/torture/tls/run-ld.c  -O2 -flto  (test for excess errors)
FAIL: gcc.dg/torture/tls/run-ld.c  -O2 -flto -flto-partition=none  (test for
excess errors)
FAIL: gcc.dg/torture/tls/run-le.c  -O2 -flto  (test for excess errors)
FAIL: gcc.dg/torture/tls/run-le.c  -O2 -flto -flto-partition=none  (test for
excess errors)
FAIL: gcc.dg/torture/tls/tls-test.c  -O2 -flto  (test for excess errors)
FAIL: gcc.dg/torture/tls/tls-test.c  -O2 -flto -flto-partition=none  (test for
excess errors)
FAIL: objc.dg/torture/tls/thr-init-2.m  -O2 -flto  -fgnu-runtime (test for
excess errors)
FAIL: objc.dg/torture/tls/thr-init-2.m  -O2 -flto -flto-partition=none 
-fgnu-runtime (test for excess errors)

Revision 175166 is OK.

[Bug middle-end/49463] [4.7 Regression] LTO testcase failures

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2011-06-18 14:19:17 UTC ---
It is caused by revision 175167:

http://gcc.gnu.org/ml/gcc-cvs/2011-06/msg00657.html

[Bug middle-end/49463] [4.7 Regression] LTO testcase failures

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.0

[Bug middle-end/49463] [4.7 Regression] LTO testcase failures

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> 2011-06-23 14:04:25 UTC ---
With the latest binutils, I still got

Executing on host: /export/build/gnu/gcc/build-x86_64-linux/gcc/xgcc
-B/export/build/gnu/gcc/build-x86_64-linux/gcc/
/export/gnu/import/git/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/strstr-asm.c
/export/gnu/import/git/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/strstr-asm-lib.c
/export/gnu/import/git/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/lib/main.c
 -w  -O2 -flto -flto-partition=none   -lm   -m32 -o
/export/build/gnu/gcc/build-x86_64-linux/gcc/testsuite/gcc/strstr-asm.x6   
(timeout = 300)
spawn -ignore SIGHUP /export/build/gnu/gcc/build-x86_64-linux/gcc/xgcc
-B/export/build/gnu/gcc/build-x86_64-linux/gcc/
/export/gnu/import/git/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/strstr-asm.c
/export/gnu/import/git/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/strstr-asm-lib.c
/export/gnu/import/git/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/lib/main.c
-w -O2 -flto -flto-partition=none -lm -m32 -o
/export/build/gnu/gcc/build-x86_64-linux/gcc/testsuite/gcc/strstr-asm.x6^M
`my_strstr' referenced in section `.text.startup' of /tmp/ccALUDUU.lto.o:
defined in discarded section `.text' of /tmp/ccM5l8Wd.o (symbol from plugin)^M
collect2: error: ld returned 1 exit status^M
compiler exited with status 1

[Bug middle-end/49463] [4.7 Regression] LTO doesn't work symbol renamed via asm statement

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-23 16:40:40 UTC ---
"Fix" for strstr-asm.c posted at
http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01794.html

I will look into the TLS testcases next.

Honza

[Bug middle-end/49463] [4.7 Regression] LTO doesn't work symbol renamed via asm statement

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> 2011-06-23 16:42:42 UTC ---
(In reply to comment #3)
>
> I will look into the TLS testcases next.
> 

They are fixed by the new linker.

[Bug middle-end/49463] [4.7 Regression] LTO doesn't work symbol renamed via asm statement

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

--- Comment #5 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-23 16:48:32 UTC ---
Good to know.  I was just about to ask how to reproduce it.
Thanks ;)

[Bug middle-end/49463] [4.7 Regression] LTO doesn't work symbol renamed via asm statement

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.06.25 14:21:26
                 CC|                            |danglin at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #6 from John David Anglin <danglin at gcc dot gnu.org> 2011-06-25 14:21:26 UTC ---
Also seen on hppa-unknown-linux-gnu.

[Bug middle-end/49463] [4.7 Regression] LTO doesn't work symbol renamed via asm statement

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

--- Comment #7 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-25 15:02:07 UTC ---
Hi,
this is not really expected.  TLS was apparently binutils bug, while the
stringop-asm is linker plugin only problem (I sent 3 different fixes for that,
each of them wrong since we can't really immitate here the non-LTO behaviour
without tracking for every statement the originating LTO object file).

What problem you get on hppa?  Are you using plugin there?

[Bug middle-end/49463] [4.7 Regression] LTO doesn't work symbol renamed via asm statement

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

--- Comment #8 from John David Anglin <danglin at gcc dot gnu.org> 2011-07-09 12:23:27 UTC ---
Executing on host: /home/dave/gnu/gcc/objdir/gcc/xgcc
-B/home/dave/gnu/gcc/objdir/gcc/
/home/dave/gnu/gcc/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/strst
r-asm.c
/home/dave/gnu/gcc/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/strstr-asm-lib.c
/home/dave/gnu/gcc/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/lib/main.c 
-w  -O2 -flto -flto-partition=none   -lm   -o
/home/dave/gnu/gcc/objdir/gcc/testsuite/gcc/strstr-asm.x6    (timeout =
300)spawn /home/dave/gnu/gcc/objdir/gcc/xgcc -B/home/dave/gnu/gcc/objdir/gcc/
/home/dave/gnu/gcc/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/strstr-asm.c
/home
/dave/gnu/gcc/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/strstr-asm-lib.c
/home/dave/gnu/gcc/gcc/gcc/testsuite/gcc.c-torture/execute/builtins/lib/main.c
-w -O2 -flto -flto-partition=none -lm -o
/home/dave/gnu/gcc/objdir/gcc/testsuite/gcc/strstr-asm.x6`my_strstr' referenced
in section `.text.startup' of /tmp/cc35bdy9.lto.o: define
d in discarded section `.text' of /tmp/ccFClE2r.o (symbol from plugin)collect2:
error: ld returned 1 exit statuscompiler exited with status 1

dave@mx3210:~/gnu/gcc/objdir/gcc/testsuite/gcc$ ld --version
GNU ld (GNU Binutils) 2.21.52.20110625

[Bug middle-end/49463] [4.7 Regression] LTO doesn't work symbol renamed via asm statement

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

--- Comment #9 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-08-02 14:22:07 UTC ---
I still see

FAIL: gcc.c-torture/execute/builtins/strstr-asm.c compilation,  -O2 -flto
-flto-
partition=none 
UNRESOLVED: gcc.c-torture/execute/builtins/strstr-asm.c execution,  -O2 -flto
-f
lto-partition=none 
FAIL: gcc.c-torture/execute/builtins/strstr-asm.c compilation,  -O2 -flto 
UNRESOLVED: gcc.c-torture/execute/builtins/strstr-asm.c execution,  -O2 -flto 

on i?86 and x86_64.

[Bug middle-end/49463] [4.7 Regression] LTO doesn't work symbol renamed via asm statement

[hubicka at ucw dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

--- Comment #10 from Jan Hubicka <hubicka at ucw dot cz> 2011-08-05 14:50:55 UTC ---
I don't see those at my setup.  Will check.  Is that with the plugin?

Honza

[Bug middle-end/49463] [4.7 Regression] LTO doesn't work symbol renamed via asm statement

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

--- Comment #11 from Uros Bizjak <ubizjak at gmail dot com> 2011-08-05 15:39:32 UTC ---
(In reply to comment #10)
> I don't see those at my setup.  Will check.  Is that with the plugin?

Yes.

ld --version
GNU ld (Linux/GNU Binutils) 2.21.52.0.2.20110610

[Bug middle-end/49463] [4.7 Regression] LTO doesn't work symbol renamed via asm statement

[uweigand at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

Ulrich Weigand <uweigand at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |uweigand at gcc dot gnu.org

--- Comment #12 from Ulrich Weigand <uweigand at gcc dot gnu.org> 2011-08-10 13:35:41 UTC ---
I'm also seeing the problem on spu-elf.

In the 001.cgraph file, I get:

strstr/5 @0xf6f90348 (asm: strstr) analyzed externally_visible finalized
  called by:
  calls: my_strstr/4 (1.00 per call) abort/8
  References:  var:inside_main (read)
  Refering this function:
my_strstr/4 @0xf6f902a0 (asm: my_strstr) analyzed externally_visible
prevailing_def_ironly finalized
  called by: strstr/5 (1.00 per call)
  calls: strchr/6 (6.32 per call) strncmp/7 (6.62 per call) strchr/6 (0.61 per
call) abort/8 strcmp/9 (0.50 per call) strlen/10 (1.00 per call)
  References:  var:inside_main (read) var:p (read)
  Refering this function:
strstr/3 @0xf6f901f8 (asm: *my_strstr)
  called by: main_test/0 (1.00 per call)
  calls:
  References:
  Refering this function:

So it would appear that the call to the renamed strstr in main_test is not
properly associated with the definition of my_strstr, since in one case the asm
name is prefixed with a '*', and in the other it isn't ...

[Bug middle-end/49463] [4.7 Regression] LTO doesn't work symbol renamed via asm statement

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

--- Comment #13 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-09-27 16:28:37 UTC ---
Author: hubicka
Date: Tue Sep 27 16:28:24 2011
New Revision: 179280

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=179280
Log:
    PR middle-end/49463
    * gcc.c-torture/execute/builtins/strstr-asm-lib.c
    (my_strstr): Mark used.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.c-torture/execute/builtins/strstr-asm-lib.c

[Bug middle-end/49463] [4.7 Regression] LTO doesn't work symbol renamed via asm statement

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49463

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-09-27 16:42:57 UTC ---
It turns out that I forgot to commit the libstrstr patch and in meantime
configure script was modified so it no longer enabled -fuse-linker-plugin by
default.  Since I tend to always specify it by hand I did not noticed for quite
a while.

I suppose the problem is that I have plugin enabled LD in my install directory
while configure script is incorrectly querying the system wide LD?

Anyway testsuite should be clean with plugin now. Sorry for taking so long.