[Bug middle-end/49465] New: [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[Bug middle-end/49465] New: [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49465

           Summary: [4.7 Regression] Revision 175114 miscompiled 403.gcc
                    in SPEC CPU 2006
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com
                CC: law@redhat.com


On Linux/x86-64, revision 175114:

http://gcc.gnu.org/ml/gcc-cvs/2011-06/msg00603.html

miscompiled 403.gcc in SPEC CPU 2006 with

-O2 -ffast-math   -DSPEC_CPU_LP64:

Setting Up Run Directories
  Setting up 403.gcc ref base lnx32e-gcc default: created
(run_base_ref_lnx32e-gcc.0000)
Running Benchmarks
  Running 403.gcc ref base lnx32e-gcc default

*** Miscompare of expr.s; for details see
   
/export/regression/rrs/spec/2006/spec/benchspec/CPU2006/403.gcc/run/run_base_ref_lnx32e-gcc.0000/expr.s.mis

*** Miscompare of scilab.s; for details see
   
/export/regression/rrs/spec/2006/spec/benchspec/CPU2006/403.gcc/run/run_base_ref_lnx32e-gcc.0000/scilab.s.mis

[Bug middle-end/49465] [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[law at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49465

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.06.20 04:52:44
     Ever Confirmed|0                           |1

[Bug middle-end/49465] [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49465

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.0

[Bug middle-end/49465] [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[law at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49465

--- Comment #1 from Jeffrey A. Law <law at redhat dot com> 2011-06-20 17:05:56 UTC ---
Something goofy happens when we compile loop.c in cpu2k6...  Still
investigating.

[Bug middle-end/49465] [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[law at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49465

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |law at redhat dot com
                   |gnu.org                     |

--- Comment #2 from Jeffrey A. Law <law at redhat dot com> 2011-06-20 19:41:43 UTC ---
We're mucking up a PHI argument in one particular case...  I'm testing a fix.

[Bug middle-end/49465] [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[law at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49465

--- Comment #3 from Jeffrey A. Law <law at redhat dot com> 2011-06-20 22:51:17 UTC ---
Fix looking good.  Doing a cpu2k6 int test right now.

[Bug middle-end/49465] [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[kirill.yukhin at intel dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49465

--- Comment #4 from Yukhin Kirill <kirill.yukhin at intel dot com> 2011-06-22 04:23:34 UTC ---
(In reply to comment #3)
> Fix looking good.  Doing a cpu2k6 int test right now.

Jeffrey, could you please share your patch?

[Bug middle-end/49465] [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49465

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> 2011-06-23 13:05:29 UTC ---
(In reply to comment #3)
> Fix looking good.  Doing a cpu2k6 int test right now.

Hi Jeff, can I try your patch on my machine? Thanks.

[Bug middle-end/49465] [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[law at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49465

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Jeffrey A. Law <law at redhat dot com> 2011-06-23 20:26:57 UTC ---
Fixed per patch.

[Bug middle-end/49465] [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[law at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49465

--- Comment #6 from Jeffrey A. Law <law at gcc dot gnu.org> 2011-06-23 20:26:10 UTC ---
Author: law
Date: Thu Jun 23 20:26:07 2011
New Revision: 175351

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175351
Log:

    PR middle-end/49465
    * tree-ssa-threadupate.c (fix_duplicate_block_edges): Fix condition
    to detect threading through joiner block.  If there was already
    an edge to the new target, then do not change the PHI nodes.

*************** fix_duplicate_block_edges (struct redire

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-ssa-threadupdate.c

[Bug middle-end/49465] [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[law at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49465

--- Comment #7 from Jeffrey A. Law <law at redhat dot com> 2011-06-23 20:26:32 UTC ---
Fixed.

[Bug middle-end/49465] [4.7 Regression] Revision 175114 miscompiled 403.gcc in SPEC CPU 2006

[law at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49465

--- Comment #9 from Jeffrey A. Law <law at gcc dot gnu.org> 2011-06-23 21:26:08 UTC ---
Author: law
Date: Thu Jun 23 21:26:04 2011
New Revision: 175352

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175352
Log:

    PR middle-end/49465
    * tree-ssa-threadupate.c (fix_duplicate_block_edges): Fix condition
    to detect threading through joiner block.  If there was already
    an edge to the new target, then do not change the PHI nodes.


Modified:
    trunk/gcc/ChangeLog