public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "kkojima at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/49468] SH Target: inefficient integer abs code
Date: Wed, 29 Feb 2012 23:23:00 -0000	[thread overview]
Message-ID: <bug-49468-4-OLgmhrya64@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-49468-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49468

--- Comment #9 from Kazumoto Kojima <kkojima at gcc dot gnu.org> 2012-02-29 23:18:23 UTC ---
(In reply to comment #8)
Perhaps.  Anyway looks fine to me except one minor failure
on sh64-elf:

xsh64-elf-combined/combined/libgcc/libgcc2.c: In function '__powisf2':
xsh64-elf-combined/combined/libgcc/libgcc2.c:1779:1: error: unrecognizable
insn:
(insn 11 10 12 3 (set (reg:DI 170)
        (abs:DI (reg:DI 169)))
xsh64-elf-combined/combined/libgcc/libgcc2.c:1770 -1
     (nil))
xsh64-elf-combined/combined/libgcc/libgcc2.c:1779:1: internal compiler error:
in extract_insn, at recog.c:2123

The failure went away if restricting new absdi2 expander to TARGET_SH1.

--- gcc/config/sh/sh.md~    2012-02-29 10:52:16.000000000 +0900
+++ gcc/config/sh/sh.md    2012-02-29 11:07:42.000000000 +0900
@@ -4538,7 +4538,7 @@ label:
   [(set (match_operand:DI 0 "arith_reg_dest" "")
     (abs:DI (match_operand:DI 1 "arith_reg_operand" "")))
    (clobber (reg:SI T_REG))]
-  ""
+  "TARGET_SH1"
   "")

 (define_insn_and_split "*absdi2"


  parent reply	other threads:[~2012-02-29 23:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-19 15:15 [Bug target/49468] New: " oleg.endo@t-online.de
2011-06-19 15:30 ` [Bug target/49468] " oleg.endo@t-online.de
2011-06-19 15:49 ` oleg.endo@t-online.de
2011-06-22 22:38 ` kkojima at gcc dot gnu.org
2011-06-26 20:49 ` oleg.endo@t-online.de
2011-06-27  6:40 ` kkojima at gcc dot gnu.org
2011-06-29  1:37 ` oleg.endo@t-online.de
2011-09-25 12:53 ` oleg.endo@t-online.de
2012-02-26 23:38 ` olegendo at gcc dot gnu.org
2012-02-28  8:44 ` olegendo at gcc dot gnu.org
2012-02-29 23:23 ` kkojima at gcc dot gnu.org [this message]
2012-03-14 23:10 ` olegendo at gcc dot gnu.org
2013-12-05 19:26 ` olegendo at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-49468-4-OLgmhrya64@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).