public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "oleg.endo@t-online.de" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/49468] SH Target: inefficient integer abs code Date: Sun, 26 Jun 2011 20:49:00 -0000 [thread overview] Message-ID: <bug-49468-4-TQpXAFWSUh@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-49468-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49468 Oleg Endo <oleg.endo@t-online.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24560|0 |1 is obsolete| | --- Comment #4 from Oleg Endo <oleg.endo@t-online.de> 2011-06-26 20:48:19 UTC --- Created attachment 24603 --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24603 Proposed patch Thanks for checking. I missed to tell the expanders that the T bit is clobbered by insns such as negdi2 and abssi2 / absdi2. The negdi2 expander that I have changed caused the libstdc++ tests to fail when formatting a -1LL. Another (reduced) example: long long x (long long i, int j, long long k) { if (j & 5) return -i; return -k; } ..ended up as (the "j & 5" got lost)... mov.l @(4,r15),r1 clrt mov.l @r15,r2 negc r1,r1 negc r2,r0 bt/s .L8 clrt negc r5,r1 negc r4,r0 .L8: rts nop
next prev parent reply other threads:[~2011-06-26 20:49 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-19 15:15 [Bug target/49468] New: " oleg.endo@t-online.de 2011-06-19 15:30 ` [Bug target/49468] " oleg.endo@t-online.de 2011-06-19 15:49 ` oleg.endo@t-online.de 2011-06-22 22:38 ` kkojima at gcc dot gnu.org 2011-06-26 20:49 ` oleg.endo@t-online.de [this message] 2011-06-27 6:40 ` kkojima at gcc dot gnu.org 2011-06-29 1:37 ` oleg.endo@t-online.de 2011-09-25 12:53 ` oleg.endo@t-online.de 2012-02-26 23:38 ` olegendo at gcc dot gnu.org 2012-02-28 8:44 ` olegendo at gcc dot gnu.org 2012-02-29 23:23 ` kkojima at gcc dot gnu.org 2012-03-14 23:10 ` olegendo at gcc dot gnu.org 2013-12-05 19:26 ` olegendo at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-49468-4-TQpXAFWSUh@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).