[Bug regression/49500] New: [4.7 Regression]: gcc.dg/tls/alias-1.c

[Bug regression/49500] New: [4.7 Regression]: gcc.dg/tls/alias-1.c

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

           Summary: [4.7 Regression]: gcc.dg/tls/alias-1.c
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: regression
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hp@gcc.gnu.org
                CC: hubicka@gcc.gnu.org


With revision 175164 this test passed.
>From revision 175170 and on, this test has failed as follows:

Running /tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.dg/tls/tls.exp ...
FAIL: gcc.dg/tls/alias-1.c (test for excess errors)

The message in gcc.log being:
Executing on host: /tmp/hpautotest-gcc1/cris-elf/gccobj/gcc/xgcc
-B/tmp/hpautotest-gcc1/cris-elf/gccobj/gcc/
/tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.dg/tls/alias-1.c    -ansi
-pedantic-errors   -isystem
/tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/./newlib/targ-include -isystem
/tmp/hpautotest-gcc1/gcc/newlib/libc/include
-B/tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/./libgloss/cris/
-L/tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/./libgloss/cris
-L/tmp/hpautotest-gcc1/gcc/libgloss/cris 
-B/tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/./newlib/
-L/tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/./newlib -sim3  -lm   -o
alias-1.exe    (timeout = 300)
/tmp/ccjevxvZ.o: In function `_main':
alias-1.c:(.text+0xc): undefined reference to `___emutls_v.bar'
collect2: error: ld returned 1 exit status
compiler exited with status 1
output is:
/tmp/ccjevxvZ.o: In function `_main':
alias-1.c:(.text+0xc): undefined reference to `___emutls_v.bar'
collect2: error: ld returned 1 exit status

FAIL: gcc.dg/tls/alias-1.c (test for excess errors)
Excess errors:
alias-1.c:(.text+0xc): undefined reference to `___emutls_v.bar'

FWIW, cris-elf is an emutls target and I see on gcc-testresults@ that this test
fails for other emutls target since about that revision range.

Author of patches in suspect revision range CC:ed.

[Bug regression/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.0

[Bug regression/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[ramana at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ramana at gcc dot gnu.org

--- Comment #1 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> 2011-06-22 10:09:39 UTC ---
Also on arm-eabi. 

Ramana

[Bug regression/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.06.22 14:04:32
                 CC|                            |danglin at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #2 from John David Anglin <danglin at gcc dot gnu.org> 2011-06-22 14:04:32 UTC ---
Also on hppa*-*-hpux*.

[Bug regression/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot       |hubicka at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-23 17:11:45 UTC ---
This is most certainly mine, caused by varpool alias reorg removing some
seemingly nonsential tests in the finalization process.  This problem has
appeared once before because emultls is introducing variables without making
any visible references to them and then it introduces the references at
expansion time.  I will try to reproduce this in a crosscopmiler and try to
think of some more robust way of fixing this issue.

[Bug regression/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-23 19:43:09 UTC ---
Created attachment 24589
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24589
proposed patch

Hi,
the problem is that emultls introduces aliases later and it does not understand
the new representation of them.  Does the attached patch help?

Honza

[Bug regression/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[dave at hiauly1 dot hia.nrc.ca]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

--- Comment #5 from dave at hiauly1 dot hia.nrc.ca 2011-06-23 21:36:05 UTC ---
On Thu, 23 Jun 2011, hubicka at gcc dot gnu.org wrote:

> Hi,
> the problem is that emultls introduces aliases later and it does not understand
> the new representation of them.  Does the attached patch help?

There is a warning which may not be new:

../../gcc/gcc/tree-emutls.c: In function 'ipa_lower_emutls':
../../gcc/gcc/tree-emutls.c:776: warning: 'cvar' may be used uninitialized in
this function

Dave

[Bug regression/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24589|0                           |1
        is obsolete|                            |

--- Comment #6 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-07-01 10:47:45 UTC ---
Created attachment 24653
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24653
proposed fix II

Hi,
here is fixed version that does not warn.  Can someone try it out, please?

[Bug regression/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

--- Comment #7 from dave.anglin at bell dot net 2011-07-01 15:32:35 UTC ---
On 1-Jul-11, at 6:47 AM, hubicka at gcc dot gnu.org wrote:

> Hi,
> here is fixed version that does not warn.  Can someone try it out,  
> please?

While test on darwin9 and hpux.

Dave

[Bug regression/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

--- Comment #8 from dave.anglin at bell dot net 2011-07-04 17:27:08 UTC ---
On 7/1/2011 6:47 AM, hubicka at gcc dot gnu.org wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500
> Hi,
> here is fixed version that does not warn.  Can someone try it out, please?

Patch fixes regression on hppa64-hp-hpux11.11 and 
hppa2.0w-hp-hpux11.11.  I also
tested change on darwin9 and didn't see any problems.

[Bug regression/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

--- Comment #9 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2011-07-11 22:06:29 UTC ---
Honza, can you post and commit the patch so we can close this?  Thanks.

[Bug regression/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[uweigand at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

Ulrich Weigand <uweigand at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |uweigand at gcc dot gnu.org

--- Comment #10 from Ulrich Weigand <uweigand at gcc dot gnu.org> 2011-07-12 16:30:17 UTC ---
This problem exists on spu-elf as well, and the patch fixes it there too.

[Bug middle-end/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |cris-elf, spu-elf,
                   |                            |arm-eabi, hppa*-*-hpux*
          Component|regression                  |middle-end

--- Comment #11 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-08-02 14:24:37 UTC ---
Any updates?  Was the patch applied?

[Bug middle-end/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[amylaar at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amylaar at gcc dot gnu.org

--- Comment #12 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> 2011-08-02 14:26:00 UTC ---
(In reply to comment #6)
> Created attachment 24653 [details]
> proposed fix II
> 
> Hi,
> here is fixed version that does not warn.  Can someone try it out, please?

Works fine for my target too.

[Bug middle-end/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

--- Comment #13 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2011-08-02 15:43:35 UTC ---
(In reply to comment #11)
> Any updates?

Still failing at r177108 for cris-elf.  Not tested the patch, but it seems
everybody else has.

>  Was the patch applied?

Does not look committed.  I think it's just missing approval, hint, hint.

[Bug middle-end/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

--- Comment #14 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-08-03 20:11:16 UTC ---
It seems that I never submitted the patch. It is posted now.

Honza

[Bug middle-end/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

--- Comment #15 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-08-05 20:52:06 UTC ---
Author: hubicka
Date: Fri Aug  5 20:52:03 2011
New Revision: 177483

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=177483
Log:

    PR middle-end/49500
    * tree-emultls.c (new_emutls_decl):Add alias_of parameter;
    handle aliases.
    (create_emultls_var):New function.
    (ipa_lower_emutls): Handle aliases correctly.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-emutls.c

[Bug middle-end/49500] [4.7 Regression]: gcc.dg/tls/alias-1.c

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49500

Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #16 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2011-08-09 00:15:29 UTC ---
I can confirm that it's fixed for cris-elf and since everyone else already
successfully tested the patch, I'm closing this PR.