[Bug c++/49507] New: ICE because of defaulted template destructor

[Bug c++/49507] New: ICE because of defaulted template destructor

[sefi@s-e-f-i.de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49507

           Summary: ICE because of defaulted template destructor
           Product: gcc
           Version: 4.6.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: sefi@s-e-f-i.de


The following code makes rc1 of gcc-4.6.1 segfault:

template<typename T>
struct ConcretePoolKey
{
        virtual ~ConcretePoolKey();
};

template<typename T>
ConcretePoolKey<T>::~ConcretePoolKey() = default;

int main()
{
        ConcretePoolKey<int> foo;
}


/usr/bin/g++ -std=c++0x test.cpp
test.cpp: In destructor 'ConcretePoolKey<T>::~ConcretePoolKey() [with T =
int]':
test.cpp:13:1:   instantiated from here
test.cpp:2:8: internal compiler error: Segmentation fault

[Bug c++/49507] [4.6/4.7 Regression] ICE because of defaulted template destructor

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49507

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.06.23 09:50:47
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |jason at gcc dot gnu.org
   Target Milestone|---                         |4.6.1
            Summary|ICE because of defaulted    |[4.6/4.7 Regression] ICE
                   |template destructor         |because of defaulted
                   |                            |template destructor
     Ever Confirmed|0                           |1

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-06-23 09:50:47 UTC ---
Indeed, a regression from 4.6.0, caused by PR47544 fix
http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=174071
on the trunk and
http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=174159
on 4.6 branch.

#0  0x00000000006f972a in initialize_vtbl_ptrs (addr=0x0) at
../../gcc/cp/init.c:120
#1  0x000000000051f017 in begin_destructor_body () at ../../gcc/cp/decl.c:13001
#2  0x00000000005201f5 in begin_function_body () at ../../gcc/cp/decl.c:13090
#3  0x0000000000716b58 in synthesize_method (fndecl=0x7ffff1a1be00) at
../../gcc/cp/method.c:741
#4  0x00000000005c8d63 in instantiate_decl (d=0x7ffff1a1be00, defer_ok=0,
expl_inst_class_mem_p=0 '\000') at ../../gcc/cp/pt.c:17738
#5  0x00000000005c9b94 in instantiate_pending_templates (retries=1) at
../../gcc/cp/pt.c:17884
#6  0x0000000000647e2c in cp_write_global_declarations () at
../../gcc/cp/decl2.c:3719

ICEs because current_class_ptr is NULL.  Jason, as this is a regression from
4.6.0, it might be desirable to fix it for 4.6.1 instead of deferring for
4.6.2.

[Bug c++/49507] [4.6/4.7 Regression] ICE because of defaulted template destructor

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49507

--- Comment #2 from Jason Merrill <jason at gcc dot gnu.org> 2011-06-23 14:28:00 UTC ---
For 4.6.1 let's just revert r174159.  Will you do that or shall I?

[Bug c++/49507] [4.6/4.7 Regression] ICE because of defaulted template destructor

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49507

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jason at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Jason Merrill <jason at gcc dot gnu.org> 2011-06-23 15:10:01 UTC ---
Created attachment 24586
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24586
fix

Actually, this patch seems safe enough for 4.6.1.  Testing now.

[Bug c++/49507] [4.6/4.7 Regression] ICE because of defaulted template destructor

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49507

--- Comment #4 from Jason Merrill <jason at gcc dot gnu.org> 2011-06-23 16:53:06 UTC ---
Author: jason
Date: Thu Jun 23 16:53:03 2011
New Revision: 175342

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175342
Log:
    PR c++/49507
    * decl2.c (mark_used): Don't call synthesize_method for
    functions defaulted outside the class.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/defaulted30.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/decl2.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/49507] [4.6/4.7 Regression] ICE because of defaulted template destructor

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49507

--- Comment #5 from Jason Merrill <jason at gcc dot gnu.org> 2011-06-23 16:56:31 UTC ---
Author: jason
Date: Thu Jun 23 16:56:27 2011
New Revision: 175343

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175343
Log:
    PR c++/49507
    * decl2.c (mark_used): Don't call synthesize_method for
    functions defaulted outside the class.

Added:
    branches/gcc-4_6-branch/gcc/testsuite/g++.dg/cpp0x/defaulted30.C
Modified:
    branches/gcc-4_6-branch/gcc/cp/ChangeLog
    branches/gcc-4_6-branch/gcc/cp/decl2.c
    branches/gcc-4_6-branch/gcc/testsuite/ChangeLog

[Bug c++/49507] [4.6/4.7 Regression] ICE because of defaulted template destructor

[sefi@s-e-f-i.de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49507

--- Comment #6 from Philipp <sefi@s-e-f-i.de> 2011-06-24 10:26:06 UTC ---
Applying the changes on top of gcc-4.6.1 rc1 fixes the problem for me.
Thanks!

[Bug c++/49507] [4.6/4.7 Regression] ICE because of defaulted template destructor

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49507

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-06-24 19:55:26 UTC ---
Fixed.