* [Bug other/49533] Firefox profiled build issues
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
@ 2011-06-27 10:14 ` hubicka at gcc dot gnu.org
2011-06-27 10:25 ` markus at trippelsdorf dot de
` (15 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: hubicka at gcc dot gnu.org @ 2011-06-27 10:14 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
--- Comment #1 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-06-27 10:13:34 UTC ---
The patch you quote has the effect of disabling pure const discovery for
functions calling functions with an aliases defined. It is quite surprising
that this does make a difference, but I still think this is most likely effect
of PR47247.
The COMDAT problem causes inline functions with address taken to not be
optimized when their address is taken and indirect call profiling takes address
of all virtuals.
Carry made an gold update that will hopefully hit the CVS binutils soonish and
I will update then the GCC side. Until that happens, I would advice using
-fprofile-generate -fno-lto (i.e. LTO is not needed for the instrumented
compiler).
Honza
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] Firefox profiled build issues
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
2011-06-27 10:14 ` [Bug other/49533] " hubicka at gcc dot gnu.org
@ 2011-06-27 10:25 ` markus at trippelsdorf dot de
2011-06-27 10:53 ` hubicka at ucw dot cz
` (14 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: markus at trippelsdorf dot de @ 2011-06-27 10:25 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
--- Comment #2 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2011-06-27 10:25:13 UTC ---
(In reply to comment #1)
> The patch you quote has the effect of disabling pure const discovery for
> functions calling functions with an aliases defined. It is quite surprising
> that this does make a difference, but I still think this is most likely effect
> of PR47247.
>
> The COMDAT problem causes inline functions with address taken to not be
> optimized when their address is taken and indirect call profiling takes address
> of all virtuals.
>
> Carry made an gold update that will hopefully hit the CVS binutils soonish and
> I will update then the GCC side. Until that happens, I would advice using
> -fprofile-generate -fno-lto (i.e. LTO is not needed for the instrumented
> compiler).
Note that this happens with "-fprofile-generate" only (no lto involved).
Sprinkling "__attribute__((used))" all over the Javascript code, or using
ld.bfd solves the first issue, too.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] Firefox profiled build issues
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
2011-06-27 10:14 ` [Bug other/49533] " hubicka at gcc dot gnu.org
2011-06-27 10:25 ` markus at trippelsdorf dot de
@ 2011-06-27 10:53 ` hubicka at ucw dot cz
2011-06-28 14:51 ` markus at trippelsdorf dot de
` (13 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: hubicka at ucw dot cz @ 2011-06-27 10:53 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
--- Comment #3 from Jan Hubicka <hubicka at ucw dot cz> 2011-06-27 10:53:14 UTC ---
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
>
> --- Comment #2 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2011-06-27 10:25:13 UTC ---
> (In reply to comment #1)
> > The patch you quote has the effect of disabling pure const discovery for
> > functions calling functions with an aliases defined. It is quite surprising
> > that this does make a difference, but I still think this is most likely effect
> > of PR47247.
> >
> > The COMDAT problem causes inline functions with address taken to not be
> > optimized when their address is taken and indirect call profiling takes address
> > of all virtuals.
> >
> > Carry made an gold update that will hopefully hit the CVS binutils soonish and
> > I will update then the GCC side. Until that happens, I would advice using
> > -fprofile-generate -fno-lto (i.e. LTO is not needed for the instrumented
> > compiler).
>
> Note that this happens with "-fprofile-generate" only (no lto involved).
Hmm, sorry then it is different issue. I take a look.
Honza
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] Firefox profiled build issues
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (2 preceding siblings ...)
2011-06-27 10:53 ` hubicka at ucw dot cz
@ 2011-06-28 14:51 ` markus at trippelsdorf dot de
2011-07-07 16:21 ` [Bug other/49533] [4.7 regression] " markus at trippelsdorf dot de
` (12 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: markus at trippelsdorf dot de @ 2011-06-28 14:51 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
--- Comment #4 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2011-06-28 14:51:15 UTC ---
The patch attached to Bug 49538 fixes this problem.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Firefox profiled build issues
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (3 preceding siblings ...)
2011-06-28 14:51 ` markus at trippelsdorf dot de
@ 2011-07-07 16:21 ` markus at trippelsdorf dot de
2011-07-07 20:30 ` markus at trippelsdorf dot de
` (11 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: markus at trippelsdorf dot de @ 2011-07-07 16:21 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
--- Comment #5 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2011-07-07 16:20:44 UTC ---
This is caused by:
7791b0eb56c3c324004e6fffe2d5f21241c038f7 is the first bad commit
commit 7791b0eb56c3c324004e6fffe2d5f21241c038f7
Author: hubicka <hubicka@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Mon Jun 13 13:12:23 2011 +0000
* ipa-inline-transform.c (+can_remove_node_now_p_1): Break out from...
(can_remove_node_now_p): ... here; handle same comdat groups.
(clone_inlined_nodes): Update use of can_remove_node_now_p add TODO.
(inline_call): Update use of can_remove_node_now_p.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@174989
138bc75d-0d04-0410-961f-82ee72b054a4
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Firefox profiled build issues
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (4 preceding siblings ...)
2011-07-07 16:21 ` [Bug other/49533] [4.7 regression] " markus at trippelsdorf dot de
@ 2011-07-07 20:30 ` markus at trippelsdorf dot de
2011-07-11 19:45 ` [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions markus at trippelsdorf dot de
` (10 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: markus at trippelsdorf dot de @ 2011-07-07 20:30 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
--- Comment #6 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2011-07-07 20:29:44 UTC ---
With 7791b0eb56c3c324004e6fffe2d5f21241c038f7 reverted and after reverting the
following hunk: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49538#c6 , Firefox
builds and runs fine again.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (5 preceding siblings ...)
2011-07-07 20:30 ` markus at trippelsdorf dot de
@ 2011-07-11 19:45 ` markus at trippelsdorf dot de
2011-07-13 21:14 ` markus at trippelsdorf dot de
` (9 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: markus at trippelsdorf dot de @ 2011-07-11 19:45 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
Markus Trippelsdorf <markus at trippelsdorf dot de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.7 regression] Firefox |[4.7 regression] Revision
|profiled build issues |174989
| |(ipa-inline-transform.c)
| |regressions
--- Comment #7 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2011-07-11 19:45:06 UTC ---
Another instance of the same regression (caused by commit 7791b0eb56c3c):
stellarium build (without PGO) with latest gcc crashes on exit:
[Thread 0x7fffee9cb700 (LWP 16857) exited]
[Thread 0x7ffff4d5a700 (LWP 16821) exited]
Program received signal SIGSEGV, Segmentation fault.
0x0000000000000000 in ?? ()
(gdb) bt
#0 0x0000000000000000 in ?? ()
#1 0x00007ffff6c331b1 in __run_exit_handlers (status=0, listp=0x7ffff6d594c8,
run_list_atexit=true) at exit.c:78
#2 0x00007ffff6c33235 in exit (status=Unhandled dwarf expression opcode 0xf3
) at exit.c:100
#3 0x00007ffff6c1cf89 in __libc_start_main (main=0x60b500 <main>, argc=1,
ubp_av=0x7fffffffe158, init=Unhandled dwarf expression opcode 0xf3
) at libc-start.c:258
#4 0x00000000004a2589 in _start ()
Reverting 7791b0eb56c3c "solves" the problem.
And I guess Bug 49665 is a dup of the same issue.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (6 preceding siblings ...)
2011-07-11 19:45 ` [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions markus at trippelsdorf dot de
@ 2011-07-13 21:14 ` markus at trippelsdorf dot de
2011-08-01 14:31 ` rguenth at gcc dot gnu.org
` (8 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: markus at trippelsdorf dot de @ 2011-07-13 21:14 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
--- Comment #8 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2011-07-13 21:13:31 UTC ---
Hmm, that whole approach doesn't seem to work.
The following patch survives building of stellarium and explains the
failures that I've reported above:
diff --git a/gcc/ipa-inline-transform.c b/gcc/ipa-inline-transform.c
index c329bea..bef1d38 100644
--- a/gcc/ipa-inline-transform.c
+++ b/gcc/ipa-inline-transform.c
@@ -122,7 +122,10 @@ can_remove_node_now_p (struct cgraph_node *node, struct
cgraph_edge *e)
next != node; next = next->same_comdat_group)
if (node->callers && node->callers != e
&& !can_remove_node_now_p_1 (node))
- return false;
+ {
+ gcc_unreachable();
+ return false;
+ }
return true;
}
Even when one changes node to next in the if clause,
"next->callers == e" is always true and the following
patch also survives building of stellarium. But it merely
brings us back to the status quo before commit 7791b0eb56c3c
went in...
diff --git a/gcc/ipa-inline-transform.c b/gcc/ipa-inline-transform.c
index c329bea..2a09de8 100644
--- a/gcc/ipa-inline-transform.c
+++ b/gcc/ipa-inline-transform.c
@@ -120,9 +120,13 @@ can_remove_node_now_p (struct cgraph_node *node, struct
cgraph_edge *e)
return true;
for (next = node->same_comdat_group;
next != node; next = next->same_comdat_group)
- if (node->callers && node->callers != e
- && !can_remove_node_now_p_1 (node))
- return false;
+ if (next->callers
+ && !can_remove_node_now_p_1 (next))
+ {
+ gcc_assert (next->callers == e);
+ return false;
+ }
+ gcc_unreachable();
return true;
}
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (7 preceding siblings ...)
2011-07-13 21:14 ` markus at trippelsdorf dot de
@ 2011-08-01 14:31 ` rguenth at gcc dot gnu.org
2011-08-31 21:47 ` pinskia at gcc dot gnu.org
` (7 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-08-01 14:31 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.7.0
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (8 preceding siblings ...)
2011-08-01 14:31 ` rguenth at gcc dot gnu.org
@ 2011-08-31 21:47 ` pinskia at gcc dot gnu.org
2011-09-01 6:44 ` markus at trippelsdorf dot de
` (6 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: pinskia at gcc dot gnu.org @ 2011-08-31 21:47 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-08-31 21:05:14 UTC ---
has this been fixed?
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (9 preceding siblings ...)
2011-08-31 21:47 ` pinskia at gcc dot gnu.org
@ 2011-09-01 6:44 ` markus at trippelsdorf dot de
2011-09-13 10:15 ` hubicka at gcc dot gnu.org
` (5 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: markus at trippelsdorf dot de @ 2011-09-01 6:44 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
--- Comment #10 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2011-09-01 06:44:39 UTC ---
(In reply to comment #9)
> has this been fixed?
No.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (10 preceding siblings ...)
2011-09-01 6:44 ` markus at trippelsdorf dot de
@ 2011-09-13 10:15 ` hubicka at gcc dot gnu.org
2011-09-13 10:15 ` hubicka at gcc dot gnu.org
` (4 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: hubicka at gcc dot gnu.org @ 2011-09-13 10:15 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
--- Comment #12 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-09-13 10:14:30 UTC ---
*** Bug 50381 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (11 preceding siblings ...)
2011-09-13 10:15 ` hubicka at gcc dot gnu.org
@ 2011-09-13 10:15 ` hubicka at gcc dot gnu.org
2011-09-13 12:31 ` markus at trippelsdorf dot de
` (3 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: hubicka at gcc dot gnu.org @ 2011-09-13 10:15 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
Jan Hubicka <hubicka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24602|0 |1
is obsolete| |
--- Comment #11 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-09-13 10:09:17 UTC ---
Created attachment 25261
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=25261
Proposed fix
Hi,
there seems to be 3 bugs cooperating on this problem.
1) we sometimes forget to output alias in comdat group since assemble_alias
gets into wrong code path when called from cgraphunit
2) I made pasto while walking aliases testing always the master node instead of
alias
3) test checking aliases looks only for unremovable function that are called,
instead for functions that are either unremovable or called.
Honza
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (12 preceding siblings ...)
2011-09-13 10:15 ` hubicka at gcc dot gnu.org
@ 2011-09-13 12:31 ` markus at trippelsdorf dot de
2011-09-13 14:40 ` hubicka at gcc dot gnu.org
` (2 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: markus at trippelsdorf dot de @ 2011-09-13 12:31 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
--- Comment #13 from Markus Trippelsdorf <markus at trippelsdorf dot de> 2011-09-13 10:57:28 UTC ---
The fix is fine. Thanks.
Please don't forget to also close Bug 49665 when you close this bug.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (13 preceding siblings ...)
2011-09-13 12:31 ` markus at trippelsdorf dot de
@ 2011-09-13 14:40 ` hubicka at gcc dot gnu.org
2011-09-13 15:04 ` hubicka at gcc dot gnu.org
2011-09-14 18:29 ` d.g.gorbachev at gmail dot com
16 siblings, 0 replies; 18+ messages in thread
From: hubicka at gcc dot gnu.org @ 2011-09-13 14:40 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
--- Comment #14 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-09-13 14:28:47 UTC ---
Author: hubicka
Date: Tue Sep 13 14:28:39 2011
New Revision: 178810
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=178810
Log:
PR other/49533
* cgraphunit.c (assemble_thunks_and_aliases): Force alias to be output.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/cgraphunit.c
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (14 preceding siblings ...)
2011-09-13 14:40 ` hubicka at gcc dot gnu.org
@ 2011-09-13 15:04 ` hubicka at gcc dot gnu.org
2011-09-14 18:29 ` d.g.gorbachev at gmail dot com
16 siblings, 0 replies; 18+ messages in thread
From: hubicka at gcc dot gnu.org @ 2011-09-13 15:04 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
Jan Hubicka <hubicka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED
--- Comment #15 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-09-13 14:56:17 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 18+ messages in thread* [Bug other/49533] [4.7 regression] Revision 174989 (ipa-inline-transform.c) regressions
2011-06-26 19:47 [Bug other/49533] New: Firefox profiled build issues markus at trippelsdorf dot de
` (15 preceding siblings ...)
2011-09-13 15:04 ` hubicka at gcc dot gnu.org
@ 2011-09-14 18:29 ` d.g.gorbachev at gmail dot com
16 siblings, 0 replies; 18+ messages in thread
From: d.g.gorbachev at gmail dot com @ 2011-09-14 18:29 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49533
Dmitry Gorbachev <d.g.gorbachev at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |d.g.gorbachev at gmail dot
| |com
--- Comment #16 from Dmitry Gorbachev <d.g.gorbachev at gmail dot com> 2011-09-14 18:28:20 UTC ---
*** Bug 50226 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 18+ messages in thread