[Bug rtl-optimization/49619] New: ICE in simplify_subreg, at simplify-rtx.c:5362

[Bug rtl-optimization/49619] New: ICE in simplify_subreg, at simplify-rtx.c:5362

[arthur.j.odwyer at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49619

           Summary: ICE in simplify_subreg, at simplify-rtx.c:5362
           Product: gcc
           Version: 4.5.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: arthur.j.odwyer@gmail.com


Created attachment 24663
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24663
Output of "ajo-gcc -O1 -fno-tree-fre -c test.c -v"

This failure reproduces for me with svn revision 175547
(2011-06-27), and also with GCC 4.5.1, but not with 4.4.5. I'm on Ubuntu 10.10,
x86-64.

cat >test.c <<EOF
extern int g_27, g_115;
void func_1(int x) {
    g_27 = 2; g_115 = 0;
    g_115 = (g_27 && ((g_27 = 1, 0 >= g_115) || (short)(x + (g_115 & x))));
}
EOF
gcc -O1 -fno-tree-fre -c test.c

test.c: In function ‘func_1’:
test.c:5:1: internal compiler error: in simplify_subreg, at simplify-rtx.c:5362

GCC 4.5.1 also ICEs on this input. The line number in 4.5.1 is
simplify-rtx.c:5140.


This test case is reduced from the output of Csmith 2.1.0 (git hash 01aa8b04,
https://github.com/Quuxplusone/csmith/), using the following command line:
csmith --no-paranoid --longlong --no-pointers --no-arrays --no-jumps
--no-consts --no-volatiles --checksum --no-divs --no-muls --bitfields
--packed-struct -s 1343472353

[Bug rtl-optimization/49619] [4.5/4.6/4.7 Regression] ICE in simplify_subreg, at simplify-rtx.c:5362

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49619

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x86_64-*-*
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.07.04 09:43:58
   Target Milestone|---                         |4.5.4
            Summary|ICE in simplify_subreg, at  |[4.5/4.6/4.7 Regression]
                   |simplify-rtx.c:5362         |ICE in simplify_subreg, at
                   |                            |simplify-rtx.c:5362
     Ever Confirmed|0                           |1

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-07-04 09:43:58 UTC ---
Confirmed.

[Bug rtl-optimization/49619] [4.5/4.6/4.7 Regression] ICE in simplify_subreg, at simplify-rtx.c:5362

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49619

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-04 10:30:10 UTC ---
Started with http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=145494

[Bug rtl-optimization/49619] [4.5/4.6/4.7 Regression] ICE in simplify_subreg, at simplify-rtx.c:5362

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49619

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-04 14:11:50 UTC ---
The problem is that simplify_gen_binary (IOR, mode, ....); can simplify
into anything, in this case into a (subreg:HI (reg:SI ...) 0), so we really
don't know the argument of its first operand.  It could be mode, but can be
anything else too.  I don't think it is actually useful to pass it at all
though, if IOR was with two CONST_INT arguments, it would have been simplified
into constant already by simplify_gen_binary.

[Bug rtl-optimization/49619] [4.5/4.6/4.7 Regression] ICE in simplify_subreg, at simplify-rtx.c:5362

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49619

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-04 14:13:21 UTC ---
Created attachment 24675
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24675
gcc47-pr49619.patch

Untested fix.  The second part perhaps should be trunk only, not backported to
the branches.

[Bug rtl-optimization/49619] [4.5/4.6/4.7 Regression] ICE in simplify_subreg, at simplify-rtx.c:5362

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49619

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-04 21:04:57 UTC ---
Author: jakub
Date: Mon Jul  4 21:04:54 2011
New Revision: 175825

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175825
Log:
    PR rtl-optimization/49619
    * combine.c (combine_simplify_rtx): In PLUS -> IOR simplification
    pass VOIDmode as op0_mode to recursive call, and return temp even
    when different from tor, just if it is not IOR of the original
    PLUS arguments.

    * gcc.dg/pr49619.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr49619.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/combine.c
    trunk/gcc/simplify-rtx.c
    trunk/gcc/testsuite/ChangeLog

[Bug rtl-optimization/49619] [4.5/4.6/4.7 Regression] ICE in simplify_subreg, at simplify-rtx.c:5362

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49619

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-04 21:10:44 UTC ---
Author: jakub
Date: Mon Jul  4 21:10:42 2011
New Revision: 175829

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175829
Log:
    PR rtl-optimization/49619
    * combine.c (combine_simplify_rtx): In PLUS -> IOR simplification
    pass VOIDmode as op0_mode to recursive call, and return temp even
    when different from tor, just if it is not IOR of the original
    PLUS arguments.

    * gcc.dg/pr49619.c: New test.

Added:
    branches/gcc-4_6-branch/gcc/testsuite/gcc.dg/pr49619.c
Modified:
    branches/gcc-4_6-branch/gcc/ChangeLog
    branches/gcc-4_6-branch/gcc/combine.c
    branches/gcc-4_6-branch/gcc/testsuite/ChangeLog

[Bug rtl-optimization/49619] [4.5 Regression] ICE in simplify_subreg, at simplify-rtx.c:5362

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49619

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.5/4.6/4.7 Regression]    |[4.5 Regression] ICE in
                   |ICE in simplify_subreg, at  |simplify_subreg, at
                   |simplify-rtx.c:5362         |simplify-rtx.c:5362

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-04 21:16:33 UTC ---
Fixed for 4.6+ so far.

[Bug rtl-optimization/49619] [4.5 Regression] ICE in simplify_subreg, at simplify-rtx.c:5362

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49619

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-19 12:58:57 UTC ---
Author: jakub
Date: Tue Jul 19 12:58:54 2011
New Revision: 176454

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176454
Log:
    Backport from mainline
    2011-07-04  Jakub Jelinek  <jakub@redhat.com>

    PR rtl-optimization/49619
    * combine.c (combine_simplify_rtx): In PLUS -> IOR simplification
    pass VOIDmode as op0_mode to recursive call.

    * gcc.dg/pr49619.c: New test.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/pr49619.c
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/combine.c
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog

[Bug rtl-optimization/49619] [4.5 Regression] ICE in simplify_subreg, at simplify-rtx.c:5362

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49619

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-19 19:32:15 UTC ---
Author: jakub
Date: Tue Jul 19 19:32:12 2011
New Revision: 176485

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176485
Log:
    Backport from mainline
    2011-07-04  Jakub Jelinek  <jakub@redhat.com>

    PR rtl-optimization/49619
    * combine.c (combine_simplify_rtx): In PLUS -> IOR simplification
    pass VOIDmode as op0_mode to recursive call.

    * gcc.dg/pr49619.c: New test.

Added:
    branches/gcc-4_4-branch/gcc/testsuite/gcc.dg/pr49619.c
Modified:
    branches/gcc-4_4-branch/gcc/ChangeLog
    branches/gcc-4_4-branch/gcc/combine.c
    branches/gcc-4_4-branch/gcc/testsuite/ChangeLog

[Bug rtl-optimization/49619] [4.5 Regression] ICE in simplify_subreg, at simplify-rtx.c:5362

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49619

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-19 19:51:32 UTC ---
Fixed.