public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "joseph at codesourcery dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/49623] Segfault of "gfortran -L" if no argument follows the "-L"
Date: Mon, 04 Jul 2011 11:05:00 -0000	[thread overview]
Message-ID: <bug-49623-4-VNMyORCJjD@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-49623-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49623

--- Comment #2 from joseph at codesourcery dot com <joseph at codesourcery dot com> 2011-07-04 11:04:36 UTC ---
On Mon, 4 Jul 2011, jakub at gcc dot gnu.org wrote:

> Created attachment 24666
>   --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24666
> gcc47-pr49623.patch
> 
> Untested fix.  Unfortunately it is hard to create a dejagnu testcase for this,
> as lots of options are appended after dg-options.

I think it would be better to repeat the logic in the next loop (that 
avoids looking in detail at options with CL_ERR_MISSING_ARG set) before 
the switch statement in this loop, so that if any more options are added 
to this loop that involve looking at the arguments it isn't necessary for 
each to check individually for the case of a missing argument.


  parent reply	other threads:[~2011-07-04 11:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04  6:30 [Bug fortran/49623] New: " burnus at gcc dot gnu.org
2011-07-04  7:23 ` [Bug fortran/49623] " jakub at gcc dot gnu.org
2011-07-04 11:05 ` joseph at codesourcery dot com [this message]
2011-07-04 21:13 ` jakub at gcc dot gnu.org
2011-07-04 21:14 ` jakub at gcc dot gnu.org
2011-07-04 21:15 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-49623-4-VNMyORCJjD@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).