public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/49628] [4.7 Regression] 447.dealII in SPEC CPU 2006 failed to build
Date: Mon, 04 Jul 2011 15:07:00 -0000	[thread overview]
Message-ID: <bug-49628-4-9Dve3qxZD0@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-49628-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49628

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |irar at gcc dot gnu.org

--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-07-04 15:06:51 UTC ---
Vectorizing the loop

<bb 8>:
  # __position_11 = PHI <__position_34(9), __position$_M_current_15(7)>
  D.2964_46 = __x_copy.values[0];
  __position_11->values[0] = D.2964_46;
  D.2964_51 = __x_copy.values[1];
  __position_11->values[1] = D.2964_51;
  D.2964_56 = __x_copy.values[2];
  __position_11->values[2] = D.2964_56;
  __position_34 = __position_11 + 24;
  if (D.2961_29 != __position_34)
    goto <bb 9>;
  else
    goto <bb 10>;

<bb 9>:
  goto <bb 8>;

I wonder where we are supposed to set GROUP_SIZE here and how it possibly
can connect to my change ... ah, the invariant loads from __x_copy.values
no longer will inhibit vectorization early.  The group is now indeed
the __x_copy.values[] loads.

The following fixes it (or rather, avoids looking at this group):

Index: gcc/tree-vect-data-refs.c
===================================================================
--- gcc/tree-vect-data-refs.c   (revision 175802)
+++ gcc/tree-vect-data-refs.c   (working copy)
@@ -1495,12 +1495,19 @@ vect_enhance_data_refs_alignment (loop_v
           && GROUP_FIRST_ELEMENT (stmt_info) != stmt)
         continue;

+      /* For invariant accesses there is nothing to enhance.  */
+      if (integer_zerop (DR_STEP (dr)))
+       continue;
+
       supportable_dr_alignment = vect_supportable_dr_alignment (dr, true);
       do_peeling = vector_alignment_reachable_p (dr);
       if (do_peeling)


  parent reply	other threads:[~2011-07-04 15:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04 13:27 [Bug middle-end/49628] New: " hjl.tools at gmail dot com
2011-07-04 13:39 ` [Bug middle-end/49628] " rguenth at gcc dot gnu.org
2011-07-04 14:02 ` hjl.tools at gmail dot com
2011-07-04 14:26 ` rguenth at gcc dot gnu.org
2011-07-04 14:33 ` rguenth at gcc dot gnu.org
2011-07-04 15:07 ` rguenth at gcc dot gnu.org [this message]
2011-07-05  6:44 ` irar at il dot ibm.com
2011-07-05  8:18 ` irar at il dot ibm.com
2011-07-05  8:54 ` rguenth at gcc dot gnu.org
2011-07-05 11:25 ` rguenth at gcc dot gnu.org
2011-07-05 11:27 ` rguenth at gcc dot gnu.org
2011-07-06  8:11 ` rguenth at gcc dot gnu.org
2011-09-08 10:49 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-49628-4-9Dve3qxZD0@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).