[Bug c/49644] New: [ 4.5/4.6 Regression ] post-increment of promoted operand is incorrect.

[Bug c/49644] New: [ 4.5/4.6 Regression ] post-increment of promoted operand is incorrect.

[orion at cora dot nwra.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

           Summary: [ 4.5/4.6 Regression ] post-increment of promoted
                    operand is incorrect.
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: c
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: orion@cora.nwra.com


#include <stdio.h>
#include <complex.h>

int main(int argc, char *argv[]) {

 double data[6] = {1.0, 2.0, 3.0, 4.0, 5.0, 6.0},*d;
 double complex *c, s = 3.0 + 0.0I;
 int i;

 d=data;
 for (i = 0; i<6; i++) {
  printf("c(%p), d(%p)=%lf\n",c,d,*d);
  *c++ = *d++ * s;
 }
 return 0;
}


With gcc 4.4.5 (compiles without warnings with -Wall):
c(0x7fff16e86a00), d(0x7fff16e868d0)=1.000000
c(0x7fff16e86a10), d(0x7fff16e868d8)=2.000000
c(0x7fff16e86a20), d(0x7fff16e868e0)=3.000000
c(0x7fff16e86a30), d(0x7fff16e868e8)=4.000000
c(0x7fff16e86a40), d(0x7fff16e868f0)=5.000000
c(0x7fff16e86a50), d(0x7fff16e868f8)=6.000000

With gcc 4.5.1 and 4.6.0:
c(0x7fff5411f2f0), d(0x7fff5411f1c0)=1.000000
c(0x7fff5411f300), d(0x7fff5411f1d0)=3.000000
c(0x7fff5411f310), d(0x7fff5411f1e0)=5.000000
c(0x7fff5411f320), d(0x7fff5411f1f0)=0.000000
c(0x7fff5411f330), d(0x7fff5411f200)=0.000000
c(0x7fff5411f340), d(0x7fff5411f210)=0.000000

It appears that the right hand side  pointer is being incremented at the rate
of its promoted size.  If you remove the " * s" from the increment line, the
code works as expected.  Same problem with 32-bit and 64-bit machines.

[Bug c/49644] [ 4.5/4.6 Regression ] post-increment of promoted to complex operand is incorrect.

[orion at cora dot nwra.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

Orion Poplawski <orion at cora dot nwra.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[ 4.5/4.6 Regression ]      |[ 4.5/4.6 Regression ]
                   |post-increment of promoted  |post-increment of promoted
                   |operand is incorrect.       |to complex operand is
                   |                            |incorrect.

--- Comment #1 from Orion Poplawski <orion at cora dot nwra.com> 2011-07-05 15:41:08 UTC ---
May only apply to complex variables.  I can't reproduce with promotion of float
to double.

[Bug c/49644] [4.5/4.6 Regression] post-increment of promoted operand is incorrect.

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      Known to work|                            |4.4.6
           Keywords|                            |wrong-code
   Last reconfirmed|                            |2011.07.05 15:41:41
                 CC|                            |jsm28 at gcc dot gnu.org
     Ever Confirmed|0                           |1
            Summary|[ 4.5/4.6 Regression ]      |[4.5/4.6 Regression]
                   |post-increment of promoted  |post-increment of promoted
                   |to complex operand is       |operand is incorrect.
                   |incorrect.                  |
   Target Milestone|---                         |4.5.4

--- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-07-05 15:41:41 UTC ---
The frontend generates

  *c++  = COMPLEX_EXPR <*d++  * REALPART_EXPR <SAVE_EXPR <s>>, *d++  *
IMAGPART_EXPR <SAVE_EXPR <s>>>;

and thus increments d twice.

[Bug c/49644] [4.5/4.6 Regression] post-increment of promoted operand is incorrect.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-05 19:46:30 UTC ---
The testcase looks wrong though, I don't see c being initialized anywhere.

[Bug c/49644] [4.5/4.6 Regression] post-increment of promoted operand is incorrect.

[orion at cora dot nwra.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

--- Comment #4 from Orion Poplawski <orion at cora dot nwra.com> 2011-07-05 20:01:27 UTC ---
Yeah, I screwed that up.  But it doesn't make any difference to the problem. 
This should be correct though.

#include <stdio.h>
#include <complex.h>

int main(int argc, char *argv[]) {

 double data[6] = {1.0, 2.0, 3.0, 4.0, 5.0, 6.0},*d;
 double complex ddata[6], *c, s = 3.0;
 int i;

 d=data;
 c=ddata;
 for (i = 0; i<6; i++) {
  printf("c(%p), d(%p)=%f\n",c,d,*d);
  *c++ = *d++ * s;
 }
 return 0;
}

[Bug c/49644] [4.5/4.6/4.7 Regression] post-increment of promoted operand is incorrect.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-07 09:54:13 UTC ---
Created attachment 24704
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24704
gcc47-pr49644.patch

Untested fix.

[Bug c/49644] [4.5/4.6/4.7 Regression] post-increment of promoted operand is incorrect.

[orion at cora dot nwra.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

--- Comment #6 from Orion Poplawski <orion at cora dot nwra.com> 2011-07-07 09:54:59 UTC ---
I am on vacation and will be out of the office until Thursay, July 21st.

Your message has been saved and I will respond if needed when I return.

If this is an urgent CoRA computing issue, please send email to
coracomputer@cora.nwra.com.

Cheers,

   Orion

--

Orion Poplawski
Technical Manager                     303-415-9701 x222
NWRA/CoRA Division                    FAX: 303-415-9702
3380 Mitchell Lane                  orion@cora.nwra.com
Boulder, CO 80301              http://www.cora.nwra.com

[Bug c/49644] [4.5/4.6/4.7 Regression] post-increment of promoted operand is incorrect.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-07 19:11:29 UTC ---
Author: jakub
Date: Thu Jul  7 19:11:27 2011
New Revision: 176004

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176004
Log:
    PR c/49644
    * c-typeck.c (build_binary_op): For MULT_EXPR and TRUNC_DIV_EXPR with
    one non-complex and one complex argument, call c_save_expr on both
    operands.

    * gcc.c-torture/execute/pr49644.c: New test.

Added:
    trunk/gcc/testsuite/gcc.c-torture/execute/pr49644.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-typeck.c
    trunk/gcc/testsuite/ChangeLog

[Bug c/49644] [4.5/4.6/4.7 Regression] post-increment of promoted operand is incorrect.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-07 19:14:41 UTC ---
Author: jakub
Date: Thu Jul  7 19:14:38 2011
New Revision: 176005

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176005
Log:
    PR c/49644
    * c-typeck.c (build_binary_op): For MULT_EXPR and TRUNC_DIV_EXPR with
    one non-complex and one complex argument, call c_save_expr on both
    operands.

    * gcc.c-torture/execute/pr49644.c: New test.

Added:
    branches/gcc-4_6-branch/gcc/testsuite/gcc.c-torture/execute/pr49644.c
Modified:
    branches/gcc-4_6-branch/gcc/ChangeLog
    branches/gcc-4_6-branch/gcc/c-typeck.c
    branches/gcc-4_6-branch/gcc/testsuite/ChangeLog

[Bug c/49644] [4.5/4.6/4.7 Regression] post-increment of promoted operand is incorrect.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-07 19:19:52 UTC ---
Fixed for C in 4.6+ so far, C++ patch is waiting for review.

[Bug c/49644] [4.5/4.6/4.7 Regression] post-increment of promoted operand is incorrect.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-07 19:41:57 UTC ---
Author: jakub
Date: Thu Jul  7 19:41:55 2011
New Revision: 176006

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176006
Log:
    PR c/49644
    * typeck.c (cp_build_binary_op): For MULT_EXPR and TRUNC_DIV_EXPR with
    one non-complex and one complex argument, call save_expr on both
    operands.

    * g++.dg/torture/pr49644.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/torture/pr49644.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/typeck.c
    trunk/gcc/testsuite/ChangeLog

[Bug c/49644] [4.5/4.6/4.7 Regression] post-increment of promoted operand is incorrect.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-07 19:43:03 UTC ---
Author: jakub
Date: Thu Jul  7 19:42:58 2011
New Revision: 176007

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176007
Log:
    PR c/49644
    * typeck.c (cp_build_binary_op): For MULT_EXPR and TRUNC_DIV_EXPR with
    one non-complex and one complex argument, call save_expr on both
    operands.

    * g++.dg/torture/pr49644.C: New test.

Added:
    branches/gcc-4_6-branch/gcc/testsuite/g++.dg/torture/pr49644.C
Modified:
    branches/gcc-4_6-branch/gcc/cp/ChangeLog
    branches/gcc-4_6-branch/gcc/cp/typeck.c
    branches/gcc-4_6-branch/gcc/testsuite/ChangeLog

[Bug c/49644] [4.5 Regression] post-increment of promoted operand is incorrect.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-19 13:07:27 UTC ---
Author: jakub
Date: Tue Jul 19 13:07:23 2011
New Revision: 176456

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176456
Log:
    Backport from mainline
    2011-07-07  Jakub Jelinek  <jakub@redhat.com>

    PR c/49644
    * c-typeck.c (build_binary_op): For MULT_EXPR and TRUNC_DIV_EXPR with
    one non-complex and one complex argument, call c_save_expr on both
    operands.

    * gcc.c-torture/execute/pr49644.c: New test.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.c-torture/execute/pr49644.c
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/c-typeck.c
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog

[Bug c/49644] [4.5 Regression] post-increment of promoted operand is incorrect.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-19 13:08:36 UTC ---
Author: jakub
Date: Tue Jul 19 13:08:33 2011
New Revision: 176457

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176457
Log:
    Backport from mainline
    2011-07-07  Jakub Jelinek  <jakub@redhat.com>

    PR c/49644
    * typeck.c (cp_build_binary_op): For MULT_EXPR and TRUNC_DIV_EXPR with
    one non-complex and one complex argument, call save_expr on both
    operands.

    * g++.dg/torture/pr49644.C: New test.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/g++.dg/torture/pr49644.C
Modified:
    branches/gcc-4_5-branch/gcc/cp/ChangeLog
    branches/gcc-4_5-branch/gcc/cp/typeck.c
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog

[Bug c/49644] [4.5 Regression] post-increment of promoted operand is incorrect.

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-07-19 13:48:36 UTC ---
Fixed.

[Bug c/49644] [4.5 Regression] post-increment of promoted operand is incorrect.

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49644

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.pippig at
                   |                            |mathematik dot
                   |                            |tu-chemnitz.de

--- Comment #15 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-08-01 14:50:17 UTC ---
*** Bug 49933 has been marked as a duplicate of this bug. ***