public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/49648] ICE(segfault) with MATHMUL and function-result actual argument
Date: Tue, 05 Jul 2011 19:47:00 -0000	[thread overview]
Message-ID: <bug-49648-4-jTafUGfVx1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-49648-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49648

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-07-05 19:46:45 UTC ---
Draft patch, which should also save some memory, .mod file-size and should
slightly speed the program.

It fixes the test case in comment 0 and comment 2, but I have not yet regtested
it (currently bootstrapping). A modification would be to not write it at all -
and simply add "sym->result = sym" if sym->attr.function. (This will break .mod
compatibility, which was last done 2011-03-29 - though I am not 100% sure that
4.6 and 4.7 are indeed still compatible.)

--- a/gcc/fortran/module.c
+++ b/gcc/fortran/module.c
@@ -3631,7 +3637,10 @@ mio_symbol (gfc_symbol *sym)

   mio_array_spec (&sym->as);

-  mio_symbol_ref (&sym->result);
+  if (iomode == IO_OUTPUT && sym->result != sym)
+    mio_symbol_ref (&sym);
+  else
+    mio_symbol_ref (&sym->result);

   if (sym->attr.cray_pointee)
     mio_symbol_ref (&sym->cp_pointer);


  parent reply	other threads:[~2011-07-05 19:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 17:06 [Bug fortran/49648] New: " burnus at gcc dot gnu.org
2011-07-05 17:15 ` [Bug fortran/49648] " burnus at gcc dot gnu.org
2011-07-05 17:31 ` burnus at gcc dot gnu.org
2011-07-05 19:01 ` burnus at gcc dot gnu.org
2011-07-05 19:47 ` burnus at gcc dot gnu.org [this message]
2011-07-05 22:52 ` burnus at gcc dot gnu.org
2011-07-06  6:44 ` [Bug fortran/49648] ICE(segfault) with MATMUL " burnus at gcc dot gnu.org
2011-07-06 14:25 ` mikael at gcc dot gnu.org
2011-07-06 15:01 ` mikael at gcc dot gnu.org
2011-07-06 16:54 ` burnus at gcc dot gnu.org
2011-07-06 17:28 ` mikael at gcc dot gnu.org
2011-07-07  8:53 ` dominiq at lps dot ens.fr
2011-07-07 20:59 ` mikael at gcc dot gnu.org
2011-07-07 21:04 ` mikael at gcc dot gnu.org
2011-07-07 21:13 ` mikael at gcc dot gnu.org
2011-07-18 20:32 ` mikael at gcc dot gnu.org
2011-07-18 20:36 ` mikael at gcc dot gnu.org
2011-07-18 20:43 ` mikael at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-49648-4-jTafUGfVx1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).