[Bug bootstrap/49794] New: [4.7 regression] Solaris 10/x86 bootstrap broken by C++ build

[Bug bootstrap/49794] New: [4.7 regression] Solaris 10/x86 bootstrap broken by C++ build

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49794

           Summary: [4.7 regression] Solaris 10/x86 bootstrap broken by
                    C++ build
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ro@gcc.gnu.org
                CC: ian@airs.com
              Host: i386-pc-solaris2.10
            Target: i386-pc-solaris2.10
             Build: i386-pc-solaris2.10


Solaris 10/x86 bootstrap is broken as of r176500: there are two failures in
stage2 libcpp:

/vol/gcc/src/hg/trunk/local/libcpp/charset.c: In function 'bool
convert_using_iconv(iconv_t, const uchar*, size_t, _cpp_strbuf*)':
/vol/gcc/src/hg/trunk/local/libcpp/charset.c:579:62: error: invalid conversion
from 'const char**' to 'char**' [-fpermissive]

The problem is that <iconv.h> has two variant iconv() declarations:

#ifdef _XPG6
extern size_t    iconv(iconv_t, char **_RESTRICT_KYWD,
        size_t *_RESTRICT_KYWD, char **_RESTRICT_KYWD,
        size_t *_RESTRICT_KYWD);
#else
extern size_t    iconv(iconv_t, const char **_RESTRICT_KYWD,
        size_t *_RESTRICT_KYWD, char **_RESTRICT_KYWD,
        size_t *_RESTRICT_KYWD);
#endif

libcpp configure is run with xgcc, which doesn't define _XOPEN_SOURCE 600, but
g++, which is used to compile libcpp, does, so the value of ICONV_CONST is
wrong.

The next failures is in init.c:

/vol/gcc/src/hg/trunk/local/libcpp/init.c:61:3: error: expected identifier
before '='
/vol/gcc/src/hg/trunk/local/libcpp/init.c:61:3: error: type '<lambda>' with no
linkage used to declare function 'void<lambda>::operator()() const' with
linkage [-fpermissive]
/vol/gcc/src/hg/trunk/local/libcpp/init.c: In lambda function:
/vol/gcc/src/hg/trunk/local/libcpp/init.c:61:3: error: expected '{' before '='
token
/vol/gcc/src/hg/trunk/local/libcpp/init.c: At global scope:
/vol/gcc/src/hg/trunk/local/libcpp/init.c:61:3: error: lambda expressions only
available with -std=c++0x or -std=gnu++0x [-Werror]
/vol/gcc/src/hg/trunk/local/libcpp/init.c:61:3: error: no match for 'operator='
in '{} = '#''
/vol/gcc/src/hg/trunk/local/libcpp/init.c:61:3: note: candidate is:
/vol/gcc/src/hg/trunk/local/libcpp/init.c:61:3: note:
<lambda()>&<lambda()>::operator=(const<lambda()>&)
/vol/gcc/src/hg/trunk/local/libcpp/init.c:61:3: note:   no known conversion for
argument 1 from 'char' to 'const<lambda()>&'

And many more errors.  The relevant section in the -g3 -save-temps outputis

__extension__ const uchar _cpp_trigraph_map[(127 * 2 + 1) + 1] = {
  ['='] = '#', [')'] = ']', ['!'] = '|',
  ['('] = '[', ['\''] = '^', ['>'] = '}',
  ['/'] = '\\', ['<'] = '{', ['-'] = '~',
};

[Bug bootstrap/49794] [4.7 regression] Solaris 10/x86 bootstrap broken by C++ build

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49794

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.0

[Bug bootstrap/49794] [4.7 regression] Solaris 10/x86 bootstrap broken by C++ build

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49794

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2011-07/msg01646.htm
                   |                            |l
   Last reconfirmed|                            |2011.07.20 16:39:43
         AssignedTo|unassigned at gcc dot       |ro at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> 2011-07-20 16:39:43 UTC ---
Mine, initial patch posted.

[Bug bootstrap/49794] [4.7 regression] Solaris 10/x86 bootstrap broken by C++ build

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49794

--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> 2011-07-22 08:58:28 UTC ---
Author: ro
Date: Fri Jul 22 08:58:25 2011
New Revision: 176620

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176620
Log:
2011-07-20  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
        Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

    gcc:
    PR bootstrap/49794
    * configure.ac: Test AM_ICONV with CXX.
    * configure: Regenerate.
    * config/sol2-c.c (solaris_format_types): Use EXPORTED_CONST.

    gcc/ada:
    PR bootstrap/49794
    * init.c [sun && __SVR4 && !__vxworks] (__gnat_install_handler):
    Assign to act.sa_sigaction.
    * tracebak.c [USE_GENERIC_UNWINDER] (__gnat_backtrace): Cast
    current->return_address to char * before arithmetic.

    libcpp:
    PR bootstrap/49794
    * configure.ac: Test AM_ICONV with CXX.
    * configure: Regenerate.
    * system.h (HAVE_DESIGNATED_INITIALIZERS): Never define for C++.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/init.c
    trunk/gcc/ada/tracebak.c
    trunk/gcc/config/sol2-c.c
    trunk/gcc/configure
    trunk/gcc/configure.ac
    trunk/libcpp/ChangeLog
    trunk/libcpp/configure
    trunk/libcpp/configure.ac
    trunk/libcpp/system.h

[Bug bootstrap/49794] [4.7 regression] Solaris 10/x86 bootstrap broken by C++ build

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49794

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                URL|http://gcc.gnu.org/ml/gcc-p |http://gcc.gnu.org/ml/gcc-p
                   |atches/2011-07/msg01646.htm |atches/2011-07/msg01750.htm
                   |l                           |l
         Resolution|                            |FIXED

--- Comment #3 from Rainer Orth <ro at gcc dot gnu.org> 2011-07-22 09:00:47 UTC ---
Fixed for 4.7.0.