[Bug c++/49894] New: Uniform initialization in constructor (C++0x)

[Bug c++/49894] New: Uniform initialization in constructor (C++0x)

[d.v.a at ngs dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

           Summary: Uniform initialization in constructor (C++0x)
           Product: gcc
           Version: 4.6.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: d.v.a@ngs.ru


#include<pthread.h>

class cond_variable
{
    ::pthread_cond_t cond;
public:
    constexpr cond_variable() : cond(PTHREAD_COND_INITIALIZER) {}
};
int main() {}

test.cpp: In constructor 'constexpr cond_variable::cond_variable()':
test.cpp:7:84: error: could not convert '{{0, 0}, 0, "", 0}' from
'<brace-enclosed initializer list>' to 'pthread_cond_t'

Variant
constexpr cond_variable() : cond((::pthread_cond_t)PTHREAD_COND_INITIALIZER) {}
is Ok.

[Bug c++/49894] Uniform initialization in constructor (C++0x)

[d.v.a at ngs dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

--- Comment #1 from __vic <d.v.a at ngs dot ru> 2011-07-29 06:28:47 UTC ---
class mutex
{
    ::pthread_mutex_t mtx;
public:
    constexpr mutex() : mtx(PTHREAD_MUTEX_INITIALIZER) {}
};

Compiles fine... What is the difference?

[Bug c++/49894] Uniform initialization in constructor (C++0x)

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2011.07.29 10:08:10
     Ever Confirmed|0                           |1

--- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-07-29 10:08:10 UTC ---
That your libc does not provide a C++ compatible initializer for
pthread_cond_t?

Without preprocessed source we can't tell.   Please attach that.

[Bug c++/49894] Uniform initialization in constructor (C++0x)

[d.v.a at ngs dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

--- Comment #3 from __vic <d.v.a at ngs dot ru> 2011-07-29 10:13:16 UTC ---
> test.cpp:7:84: error: could not convert '{{0, 0}, 0, "", 0}' from
> '<brace-enclosed initializer list>' to 'pthread_cond_t'
> 

Initializer is:

{{0, 0}, 0, "", 0}

[Bug c++/49894] Uniform initialization in constructor (C++0x)

[d.v.a at ngs dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

--- Comment #4 from __vic <d.v.a at ngs dot ru> 2011-07-29 10:17:35 UTC ---
Created attachment 24861
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24861
Preprocessor output

[Bug libstdc++/49894] [C++0x] Uniform initialization in constructor

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW
                 CC|                            |jason at gcc dot gnu.org
          Component|c++                         |libstdc++

--- Comment #5 from Jason Merrill <jason at gcc dot gnu.org> 2011-10-14 19:28:42 UTC ---
The request to support ({ ... }) for array mem-initializers was rejected by
core:

http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_closed.html#1339

Now that the compiler supports non-static data member initializers, the library
should use that instead of a mem-initializer.

  ::pthread_cond_t cond = PTHREAD_COND_INITIALIZER;

should work in all cases.

[Bug libstdc++/49894] [C++0x] Uniform initialization in constructor

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwakely.gcc at gmail dot
                   |                            |com

--- Comment #6 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-10-14 23:04:27 UTC ---
Jon, did you follow this?

[Bug libstdc++/49894] [C++0x] Uniform initialization in constructor

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-10-15 12:25:41 UTC ---
Yeah, this pr inspired http://gcc.gnu.org/ml/libstdc++/2011-10/msg00016.html

[Bug libstdc++/49894] [C++0x] Uniform initialization in constructor

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |redi at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.7.0

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-10-15 12:53:47 UTC ---
I'll deal with this after PR 50196

[Bug libstdc++/49894] [C++0x] Uniform initialization in constructor

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|jwakely.gcc at gmail dot    |
                   |com                         |

--- Comment #9 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-10-15 19:53:22 UTC ---
Indeed. Thanks a lot!

[Bug libstdc++/49894] [C++0x] Uniform initialization in constructor

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

--- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-10-24 23:26:29 UTC ---
Author: redi
Date: Mon Oct 24 23:26:25 2011
New Revision: 180411

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=180411
Log:
    PR libstdc++/49894
    * include/std/mutex (__mutex_base,__recursive_mutex_base): Define new
    base classes to manage construction/destruction of native mutexes,
    using NSDMI when INIT macros are defined.
    (mutex,recursive_mutex,timed_mutex,recursive_timed_mutex): Derive from
    new base classes.
    * include/std/condition_variable (condition_variable): Use NSDMI when
    INIT macro is defined. Use noexcept.
    * src/condition_variable.cc (condition_variable): Explicitly-default
    constructor/destructor when using NSDMI. Use noexcept.
    (condition_variable_any): Likewise.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/std/condition_variable
    trunk/libstdc++-v3/include/std/mutex
    trunk/libstdc++-v3/src/condition_variable.cc

[Bug libstdc++/49894] [C++0x] Uniform initialization in constructor

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-10-24 23:29:38 UTC ---
Fixed for 4.7 - mutexes and condition_variables use NSDMI to initialize the
native types when possible

[Bug libstdc++/49894] [C++0x] Uniform initialization in constructor

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

--- Comment #12 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-11-05 13:33:38 UTC ---
Author: redi
Date: Sat Nov  5 13:33:29 2011
New Revision: 181013

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181013
Log:
    PR libstdc++/49894
    PR bootstrap/50982
    * include/std/mutex (once_flag): Use NSDMI.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/std/mutex

[Bug libstdc++/49894] [C++0x] Uniform initialization in constructor

[d.v.a at ngs dot ru]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49894

__vic <d.v.a at ngs dot ru> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from __vic <d.v.a at ngs dot ru> 2012-06-15 08:51:36 UTC ---
NSDMI works fine. Thanx