From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8604 invoked by alias); 2 Aug 2011 08:41:27 -0000 Received: (qmail 8595 invoked by uid 22791); 2 Aug 2011 08:41:27 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Aug 2011 08:41:10 +0000 From: "rguenther at suse dot de" To: gcc-bugs@gcc.gnu.org Subject: [Bug bootstrap/49914] call to abs(long long) in gcc/fold-const.c X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: bootstrap X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: rguenther at suse dot de X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: paolo.carlini at oracle dot com X-Bugzilla-Target-Milestone: 4.7.0 X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Tue, 02 Aug 2011 08:41:00 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg00135.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49914 --- Comment #7 from rguenther at suse dot de 2011-08-02 08:40:24 UTC --- On Mon, 1 Aug 2011, paolo.carlini at oracle dot com wrote: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49914 > > Paolo Carlini changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > CC| |paolo.carlini at oracle dot > | |com, rguenth at gcc dot > | |gnu.org > > --- Comment #3 from Paolo Carlini 2011-08-01 16:36:54 UTC --- > So, Richard, what shall we do here? Add to tree.h just: > > #define ABS(X) ((X >= 0) ? (X) : (-X)) > > and use it in all those places? Or a static inline? Better name? No, I'd say have a abs_hwi in hwint.h and use that (ISTR sebastian pop adding one in a (pending?) patch)