[Bug other/49930] New: Need some adjustments for bionic

[Bug other/49930] New: Need some adjustments for bionic

[mh+gcc at glandium dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49930

           Summary: Need some adjustments for bionic
           Product: gcc
           Version: 4.6.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: mh+gcc@glandium.org


Created attachment 24879
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24879
Patch

The following things are bionic specificities that the gcc source code doesn't
handle well:
- sincos is not supported
- getpagesize is defined as an inline in the headers
- prctl is defined with the prototype as per the linux manual page:
  int prctl(int option, unsigned long arg2, unsigned long arg3,
            unsigned long arg4, unsigned long arg5)
  and not prctl(int option, ...) as in glibc headers.

With the attached patch, I was able to build gcc 4.6.1 for use with the Android
NDK.

[Bug other/49930] Need some adjustments for bionic

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49930

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-08-02 05:40:59 UTC ---
The libiberty patch is not needed anymore as it is not built for the target.

[Bug other/49930] Need some adjustments for bionic

[michael.hope at linaro dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49930

Michael Hope <michael.hope at linaro dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.hope at linaro dot
                   |                            |org

--- Comment #2 from Michael Hope <michael.hope at linaro dot org> 2011-09-07 02:30:14 UTC ---
Note that sincos() was introduced with Android 2.3.  The initial version calls
sin() then calls cos() so there's no immediate advantage.

[Bug other/49930] Need some adjustments for bionic

[lool at dooz dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49930

Loïc Minier <lool at dooz dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lool at dooz dot org

--- Comment #3 from Loïc Minier <lool at dooz dot org> 2011-09-07 08:28:57 UTC ---
So just the getpagesize remains?

[Bug other/49930] Need some adjustments for bionic

[mh+gcc at glandium dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49930

--- Comment #4 from Mike Hommey <mh+gcc at glandium dot org> 2011-09-07 08:54:11 UTC ---
(In reply to comment #3)
> So just the getpagesize remains?

getpagesize is in libiberty, it shouldn't matter anymore

(In reply to comment #2)
> Note that sincos() was introduced with Android 2.3.  The initial version calls
> sin() then calls cos() so there's no immediate advantage.

As you say, sincos() was introduced with Android 2.3, which means you can build
native binaries for that target without the patch, but you can't build native
binaries for older targets. There are too many Android < 2.3 devices out there
to just ignore the problem.