[Bug ada/49944] New: [4.5/4.6/4.7 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[Bug ada/49944] New: [4.5/4.6/4.7 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[ludovic@ludovic-brenta.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

           Summary: [4.5/4.6/4.7 regression] Bootstrapping on
                    x86_64-pc-kfreebsd-gnu fails with
                    "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is
                    undefined (more references follow)"
           Product: gcc
           Version: 4.5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ludovic@ludovic-brenta.org
              Host: x86_64-pc-kfreebsd-gnu
            Target: x86_64-pc-kfreebsd-gnu
             Build: x86_64-pc-kfreebsd-gnu


The following commit changed s-osinte-linux.ads but not
s-osinte-kfreebsd-gnu.ads; this breaks bootstrapping on GNU/kFreeBSD:


        * adaint.c (__gnat_pthread_setaffinity_np,
        __gnat_pthread_attr_setaffinity_np): Remove wrappers, no longer needed.
        * s-osinte-linux.ads (pthread_setaffinity_np,
        pthread_attr_setaffinity_np): Remove use of wrappers.
        * s-taprop-linux.adb (Create_Task, Initialize): Restore check to verify
        whether the affinity functionality is available in the OS.
        * gcc-interface/utils.c: Set TREE_STATIC on functions only when there
        are defined.



    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@165635
138bc75d-0d04-0410-961f-82ee72b054a4

This is because GNU/kFreeBSD uses s-taprop-linux.adb, which uses subprograms
defined in either s-osint-linux.ads or s-osint-kfreebsd-gnu.ads depending on
the host.

[Bug ada/49944] [4.5/4.6/4.7 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[charlet at adacore dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

--- Comment #1 from charlet at adacore dot com <charlet at adacore dot com> 2011-08-02 10:51:19 UTC ---
> This is because GNU/kFreeBSD uses s-taprop-linux.adb, which uses
> subprograms

Well, then that's the bug: kFreeBSD should cheat and try to reuse linux
files, that's bound to cause this kind of error.

Arno

Re: [Bug ada/49944] [4.5/4.6/4.7 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[Arnaud Charlet]

> > This is because GNU/kFreeBSD uses s-taprop-linux.adb, which uses
> > subprograms
> 
> Well, then that's the bug: kFreeBSD should cheat and try to reuse linux

Sorry, I meant of course "shouldN'T cheat"

> files, that's bound to cause this kind of error.

[Bug ada/49944] [4.5/4.6/4.7 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[charlet at adacore dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

--- Comment #2 from charlet at adacore dot com <charlet at adacore dot com> 2011-08-02 10:53:47 UTC ---
> > This is because GNU/kFreeBSD uses s-taprop-linux.adb, which uses
> > subprograms
> 
> Well, then that's the bug: kFreeBSD should cheat and try to reuse linux

Sorry, I meant of course "shouldN'T cheat"

> files, that's bound to cause this kind of error.

[Bug ada/49944] [4.5/4.6/4.7 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[ludovic@ludovic-brenta.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

--- Comment #3 from Ludovic Brenta <ludovic@ludovic-brenta.org> 2011-08-02 17:30:43 UTC ---
I would not be so assertive as Arno.  It seems to me (but I may be wrong) that
s-taprop-linux.adb really only calls glibc and libpthread, not the kernel, and
therefore should be called s-taprop-glibc.adb.  It looks like the
kernel-specific calls are all in s-osinte-{linux,freebsd,kfreebsd-gnu}.ads,
which have the proper names.  GNU/kFreeBSD uses the GNU glibc instead of
FreeBSD's libc, so I think s-taprop-linux.adb is appropriate there.

Re: [Bug ada/49944] [4.5/4.6/4.7 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[Arnaud Charlet]

> I would not be so assertive as Arno.

Really? As the person who wrote this file and as the main tasking expert
of GNAT, I think I can be so assertive on this topic.

> It seems to me (but I may be wrong) that
> s-taprop-linux.adb really only calls glibc and libpthread, not the
> kernel, and
> therefore should be called s-taprop-glibc.adb.  It looks like the
> kernel-specific calls are all in
> s-osinte-{linux,freebsd,kfreebsd-gnu}.ads,

No, s-taprop-linux.adb is only meant to be used under Linux and only
guaranteed to work under linux.

Using this file on non linux systems is bound to cause troubles and is not a
good idea.

If you're looking for a file shared among several platforms with a known
API, then as I said, using s-taprop-posix.adb is the way to go. That's what
I would do anyway if I were to port GNAT to kfreebsd properly.

Arno

[Bug ada/49944] [4.5/4.6/4.7 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[charlet at adacore dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

--- Comment #4 from charlet at adacore dot com <charlet at adacore dot com> 2011-08-02 17:42:05 UTC ---
> I would not be so assertive as Arno.

Really? As the person who wrote this file and as the main tasking expert
of GNAT, I think I can be so assertive on this topic.

> It seems to me (but I may be wrong) that
> s-taprop-linux.adb really only calls glibc and libpthread, not the
> kernel, and
> therefore should be called s-taprop-glibc.adb.  It looks like the
> kernel-specific calls are all in
> s-osinte-{linux,freebsd,kfreebsd-gnu}.ads,

No, s-taprop-linux.adb is only meant to be used under Linux and only
guaranteed to work under linux.

Using this file on non linux systems is bound to cause troubles and is not a
good idea.

If you're looking for a file shared among several platforms with a known
API, then as I said, using s-taprop-posix.adb is the way to go. That's what
I would do anyway if I were to port GNAT to kfreebsd properly.

Arno

[Bug ada/49944] [4.5/4.6/4.7 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[ludovic@ludovic-brenta.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

--- Comment #5 from Ludovic Brenta <ludovic@ludovic-brenta.org> 2011-08-04 10:21:20 UTC ---
OK, here is another patch which changes GCC to use s-taprop-posix.ad[bs] on
GNU/kFreeBSD.  The changes in s-osinte-kfreebsd-gnu.ads are more extensive than
in the previous patch I sent to gcc-patches; they greatly reduce the difference
between s-osinte-kfreebsd-gnu.ads and s-osinte-freebsd.ads.

http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00440.html

[Bug ada/49944] [4.5/4.6/4.7 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.5.4

[Bug ada/49944] [4.5/4.6/4.7 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug ada/49944] [4.6/4.7/4.8 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.5.4                       |4.6.4

[Bug ada/49944] [4.7/4.8/4.9 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.6.4                       |4.7.4

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-04-12 15:15:41 UTC ---
GCC 4.6.4 has been released and the branch has been closed.

[Bug ada/49944] [4.7/4.8/4.9/4.10 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.7.4                       |4.8.4

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
The 4.7 branch is being closed, moving target milestone to 4.8.4.

[Bug ada/49944] [4.8/4.9/5 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.4                       |4.8.5

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.

[Bug ada/49944] [4.8/4.9/5/6 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.8.5                       |4.9.3

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
The gcc-4_8-branch is being closed, re-targeting regressions to 4.9.3.

[Bug ada/49944] [4.9/5/6 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.9.3 has been released.

[Bug ada/49944] [4.9/5/6 regression] Bootstrapping on x86_64-pc-kfreebsd-gnu fails with "s-taprop.adb:856:10: "pthread_attr_setaffinity_np" is undefined (more references follow)"

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49944

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.9.3                       |4.9.4