[Bug tree-optimization/49963] New: ICE: in abs_hwi, at hwint.c:108

[Bug tree-optimization/49963] New: ICE: in abs_hwi, at hwint.c:108

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

           Summary: ICE: in abs_hwi, at hwint.c:108
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: gjl@gcc.gnu.org
              Host: x86-linux-gnu
            Target: avr
             Build: x86-linux-gnu


Observed this ICE in the test suite for 4.7 trunk r177267 after upgrading from
177070:

gcc.c-torture/execute/divconst-2.c: In function 'std_eqn':

gcc.c-torture/execute/divconst-2.c:20:3: internal compiler error: in abs_hwi,
at hwint.c:108


FAIL: gcc.c-torture/execute/divconst-2.c compilation,  -O0  (internal compiler
error)
FAIL: gcc.c-torture/execute/divconst-2.c compilation,  -O1  (internal compiler
error)
FAIL: gcc.c-torture/execute/divconst-2.c compilation,  -O2  (internal compiler
error)
...

== configure ========================================================

Target: avr
Configured with: ../../gcc.gnu.org/trunk/configure --target=avr
--prefix=/local/gnu/install/gcc-4.7 --disable-nls --disable-shared
--enable-languages=c,c++ --with-dwarf2 --disable-lto
Thread model: single
gcc version 4.7.0 20110803 (experimental) (GCC)
GNU C (GCC) version 4.7.0 20110803 (experimental) (avr)
        compiled by GNU C version 4.3.2 [gcc-4_3-branch revision 141291], GMP
version 5.0.1, MPFR version 3.0.0-p8, MPC version 0.8.2
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096

== hwint.c:abs_hwi() ================================================

hwint.c:abs_hwi() reads

/* Compute the absolute value of X.  */

HOST_WIDE_INT
abs_hwi (HOST_WIDE_INT x)
{
  gcc_checking_assert (x != HOST_WIDE_INT_MIN);
  return x >= 0 ? x : -x;
}

== Backtrace =========================================================


#0  fancy_abort (file=0x8890660 "../../../gcc.gnu.org/trunk/gcc/hwint.c",
line=108, function=0x889069b "abs_hwi") at
../../../gcc.gnu.org/trunk/gcc/diagnostic.c:893
#1  0x08395087 in abs_hwi (x=-2147483648) at
../../../gcc.gnu.org/trunk/gcc/hwint.c:108
#2  0x08306e8a in fold_plusminus_mult_expr (loc=2983, code=PLUS_EXPR,
type=0xb7d5d420, arg0=0xb7dcdcb0, arg1=0xb7dce24c) at
../../../gcc.gnu.org/trunk/gcc/fold-const.c:7040
#3  0x082bbef6 in fold_binary_loc (loc=2983, code=PLUS_EXPR, type=0xb7d5d420,
op0=0xb7dcdcb0, op1=0xb7dce24c) at
../../../gcc.gnu.org/trunk/gcc/fold-const.c:9685
#4  0x083174d5 in fold (expr=0xb7dcdccc) at
../../../gcc.gnu.org/trunk/gcc/fold-const.c:13666
#5  0x0813c46c in c_fully_fold_internal (expr=0xb7dcdccc, in_init=0 '\0',
maybe_const_operands=0xbfffdf4b "\001\030", maybe_const_itself=0xbfffde6a
"\001\001ÌÜÜ· ÔÕ·") at ../../../gcc.gnu.org/trunk/gcc/c-family/c-common.c:1238
#6  0x0813d19b in c_fully_fold (expr=0xb7dcdccc, in_init=212 'Ô',
maybe_const=0xbfffdf4b "\001\030") at
../../../gcc.gnu.org/trunk/gcc/c-family/c-common.c:1029
#7  0x080eadcb in build_binary_op (location=2989, code=EQ_EXPR,
orig_op0=0xb7dcdccc, orig_op1=0xb7dce150, convert_p=1) at
../../../gcc.gnu.org/trunk/gcc/c-typeck.c:10172
#8  0x080ef279 in parser_build_binary_op (location=2989, code=EQ_EXPR,
arg1={value = 0xb7dcdccc, original_code = PLUS_EXPR, original_type = 0x0},
arg2={value = 0xb7dce150, original_code = ERROR_MARK, original_type =
0xb7d5d420}) at ../../../gcc.gnu.org/trunk/gcc/c-typeck.c:3218
#9  0x080fbe57 in c_parser_binary_expression (parser=0xb7dcda9c, after=<value
optimized out>, prec=PREC_NONE) at
../../../gcc.gnu.org/trunk/gcc/c-parser.c:5663
#10 0x080fc49f in c_parser_conditional_expression (parser=0xb7dcda9c,
after=0x80000000) at ../../../gcc.gnu.org/trunk/gcc/c-parser.c:5330
#11 0x080fc9c8 in c_parser_expr_no_commas (parser=0xb7dcda9c, after=0x80000000)
at ../../../gcc.gnu.org/trunk/gcc/c-parser.c:5250
#12 0x080fce68 in c_parser_expression (parser=0xb7d97dd4) at
../../../gcc.gnu.org/trunk/gcc/c-parser.c:6716
#13 0x080fe5f3 in c_parser_expression_conv (parser=0xb7dcda9c) at
../../../gcc.gnu.org/trunk/gcc/c-parser.c:6747
#14 0x080f887a in c_parser_statement_after_labels (parser=0xb7dcda9c) at
../../../gcc.gnu.org/trunk/gcc/c-parser.c:4416
#15 0x080f997a in c_parser_compound_statement_nostart (parser=0xb7dcda9c) at
../../../gcc.gnu.org/trunk/gcc/c-parser.c:4147
#16 0x08107852 in c_parser_compound_statement (parser=0xb7dcda9c) at
../../../gcc.gnu.org/trunk/gcc/c-parser.c:3984
#17 0x080f7fc3 in c_parser_declaration_or_fndef (parser=0xb7dcda9c, fndef_ok=1
'\001', static_assert_ok=<value optimized out>, empty_ok=1 '\001', nested=0
'\0', start_attr_ok=<value optimized out>, objc_foreach_object_declaration=0x0)
at ../../../gcc.gnu.org/trunk/gcc/c-parser.c:1749
#18 0x081081da in c_parser_external_declaration (parser=0xb7dcda9c) at
../../../gcc.gnu.org/trunk/gcc/c-parser.c:1354
#19 0x08108a1b in c_parse_file () at
../../../gcc.gnu.org/trunk/gcc/c-parser.c:1242
#20 0x081501b5 in c_common_parse_file () at
../../../gcc.gnu.org/trunk/gcc/c-family/c-opts.c:1094
#21 0x084b0ecf in toplev_main (argc=12, argv=0xbfffe5e4) at
../../../gcc.gnu.org/trunk/gcc/toplev.c:548
#22 0x08169932 in main (argc=Cannot access memory at address 0x80000000
) at ../../../gcc.gnu.org/trunk/gcc/main.c:36
(gdb)

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.08.03 15:26:26
                 CC|                            |paolo.carlini at oracle dot
                   |                            |com, rth at gcc dot
                   |                            |gnu.org, spop at gcc dot
                   |                            |gnu.org
   Target Milestone|---                         |4.7.0
            Summary|ICE: in abs_hwi, at         |[4.7 Regression] ICE: in
                   |hwint.c:108                 |abs_hwi, at hwint.c:108
     Ever Confirmed|0                           |1

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-08-03 15:26:26 UTC ---
Well - as I said.  Here we go.

Please fix :P

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

--- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-08-03 15:27:36 UTC ---
Probably fails on any 32bit HWI platform.

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-08-03 15:45:06 UTC ---
Eh, my way of fixing it would be removing the assert ;) Seriously, too bad, I
can try to look a bit into it but help is welcome of course, I don't think the
project wants to rely on my judgment about this vs 49914...

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[joseph at codesourcery dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

--- Comment #4 from joseph at codesourcery dot com <joseph at codesourcery dot com> 2011-08-03 18:59:33 UTC ---
I think this is a case for a function absu_hwi or similar that returns an 
unsigned HOST_WIDE_INT value.

(Actually it's a case for operating properly on the INTEGER_CSTs or on 
double_ints without being conditional on whether the values pass 
host_integerp, but that's a more complicated fix.)

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-08-03 20:29:51 UTC ---
Created attachment 24909
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24909
Draft patch

I'm attaching a patch which tries to implement what Joseph suggests (thanks!).
Essentially, I'm replacing all uses of abs_hwi outside hwint.c itself, besides
three in tree-ssa-math-opts.c which seem correct anyway: the argument is an
HOST_WIDE_INT / 2 or / 3 and the result is passed to a function taking a plain
HOST_WIDE_INT. Type-wise the patch makes a lot of sense to me.

Maybe submitter could test it? I'm sanity checking it on x86_64.

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

--- Comment #6 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2011-08-08 08:28:46 UTC ---
(In reply to comment #5)
> Created attachment 24909 [details]
> Draft patch
> 
> I'm attaching a patch which tries to implement what Joseph suggests (thanks!).
> Essentially, I'm replacing all uses of abs_hwi outside hwint.c itself, besides
> three in tree-ssa-math-opts.c which seem correct anyway: the argument is an
> HOST_WIDE_INT / 2 or / 3 and the result is passed to a function taking a plain
> HOST_WIDE_INT. Type-wise the patch makes a lot of sense to me.
> 
> Maybe submitter could test it? I'm sanity checking it on x86_64.

That works for me, i.e. gcc.c-torture/execute/divconst-2.c passes with your 
patch.

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

--- Comment #7 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2011-08-10 09:45:12 UTC ---
Is this related to PR42146, an ICE on array size of 0x80000000?

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu.org

--- Comment #8 from John David Anglin <danglin at gcc dot gnu.org> 2011-08-10 14:13:06 UTC ---
Also occurs on hppa2.0w-hp-hpux11.11.

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenther at suse dot de

--- Comment #9 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-08-17 07:32:46 UTC ---
So, what do people think? Shall we go ahead with something like the patchlet I
attached?

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[rguenther at suse dot de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

--- Comment #10 from rguenther at suse dot de <rguenther at suse dot de> 2011-08-17 11:25:02 UTC ---
On Wed, 17 Aug 2011, paolo.carlini at oracle dot com wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963
> 
> Paolo Carlini <paolo.carlini at oracle dot com> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |rguenther at suse dot de
> 
> --- Comment #9 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-08-17 07:32:46 UTC ---
> So, what do people think? Shall we go ahead with something like the patchlet I
> attached?

Sure, please post patches to gcc-patches@, bugzilla isn't the place
to get attention to them

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

--- Comment #11 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-08-17 17:22:16 UTC ---
Ok, thanks, will do later today.

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

--- Comment #12 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-08-18 11:30:50 UTC ---
Author: paolo
Date: Thu Aug 18 11:30:42 2011
New Revision: 177848

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=177848
Log:
2011-08-18  Paolo Carlini  <paolo.carlini@oracle.com>
        Joseph Myers  <joseph@codesourcery.com>

    PR tree-optimization/49963
    * hwint.c (absu_hwi): Define.
    * hwint.h (absu_hwi): Declare.
    * fold-const.c (fold_plusminus_mult_expr): Use absu_hwi instead
    of abs_hwi.
    * tree-ssa-math-opts.c (gimple_expand_builtin_pow): Likewise.
    * tree-ssa-loop-prefetch.c (prune_ref_by_group_reuse): Likewise.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/fold-const.c
    trunk/gcc/hwint.c
    trunk/gcc/hwint.h
    trunk/gcc/tree-ssa-loop-prefetch.c
    trunk/gcc/tree-ssa-math-opts.c

[Bug tree-optimization/49963] [4.7 Regression] ICE: in abs_hwi, at hwint.c:108

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49963

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-08-18 11:33:54 UTC ---
Fixed.