[Bug middle-end/49968] New: ICE in calls.c:3141 / assert after emit_stack_restore

[Bug middle-end/49968] New: ICE in calls.c:3141 / assert after emit_stack_restore

[uweigand at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49968

           Summary: ICE in calls.c:3141 / assert after emit_stack_restore
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: uweigand@gcc.gnu.org
                CC: rth@gcc.gnu.org
            Target: spu-elf


I'm seeing ICEs in calls.c:3141 on spu-elf after this patch went in:
http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00075.html

One test case showing this problem is:
gcc.c-torture/compile/20030224-1.c

The problem here is that SPU's restore_stack_block generates insn
sequences that do not terminate in a SET of stack_pointer_rtx,
see this for further discussion:
http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00326.html

[Bug middle-end/49968] ICE in calls.c:3141 / assert after emit_stack_restore

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49968

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.08.03 17:18:39
         AssignedTo|unassigned at gcc dot       |rth at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.7.0
     Ever Confirmed|0                           |1

--- Comment #1 from Richard Henderson <rth at gcc dot gnu.org> 2011-08-03 17:18:39 UTC ---
Mine.

[Bug middle-end/49968] ICE in calls.c:3141 / assert after emit_stack_restore

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49968

--- Comment #2 from Richard Henderson <rth at gcc dot gnu.org> 2011-08-03 18:00:21 UTC ---
Created attachment 24908
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=24908
proposed patch

I believe this will solve the problem.

[Bug middle-end/49968] ICE in calls.c:3141 / assert after emit_stack_restore

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49968

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING

[Bug middle-end/49968] ICE in calls.c:3141 / assert after emit_stack_restore

[uweigand at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49968

--- Comment #3 from Ulrich Weigand <uweigand at gcc dot gnu.org> 2011-08-03 21:21:32 UTC ---
The patch did indeed fix the testcase, thanks!

Running a full regression now ...

[Bug middle-end/49968] ICE in calls.c:3141 / assert after emit_stack_restore

[uweigand at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49968

--- Comment #4 from Ulrich Weigand <uweigand at gcc dot gnu.org> 2011-08-04 09:10:44 UTC ---
Tests have completed now; the patch fixes all regressions introduced by the
original commit, and introduced no new ones.  Looks good to me.

[Bug middle-end/49968] ICE in calls.c:3141 / assert after emit_stack_restore

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49968

--- Comment #5 from Richard Henderson <rth at gcc dot gnu.org> 2011-08-04 15:39:43 UTC ---
Author: rth
Date: Thu Aug  4 15:39:40 2011
New Revision: 177404

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=177404
Log:
PR middle-end/49968
        * calls.c (expand_call): Use fixup_args_size_notes for
        emit_stack_restore.
        * expr.c (fixup_args_size_notes): Allow STACK_POINTER_REGNUM sets
        in non-standard modes.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/calls.c
    trunk/gcc/expr.c

[Bug middle-end/49968] ICE in calls.c:3141 / assert after emit_stack_restore

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49968

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Richard Henderson <rth at gcc dot gnu.org> 2011-08-04 19:10:36 UTC ---
Fixed.