public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "mikpe at it dot uu.se" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/50012] [4.5/4.6/4.7 Regression] C++ front end misses -Wsign-compare warnings when extraneous parentheses are present Date: Sun, 14 Aug 2011 12:43:00 -0000 [thread overview] Message-ID: <bug-50012-4-TbajeCS03d@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-50012-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50012 --- Comment #2 from Mikael Pettersson <mikpe at it dot uu.se> 2011-08-14 12:25:12 UTC --- The warning is lost due to this fragment of r148952 (with the rest of r148952 disabled): --- gcc/cp/typeck.c (revision 148951) +++ gcc/cp/typeck.c (revision 148952) @@ -4018,6 +4018,8 @@ cp_build_binary_op (location_t location, if ((short_compare || code == MIN_EXPR || code == MAX_EXPR) && warn_sign_compare + && !TREE_NO_WARNING (orig_op0) + && !TREE_NO_WARNING (orig_op1) /* Do not warn until the template is instantiated; we cannot bound the ranges of the arguments until that point. */ && !processing_template_decl In this test case (the foo() function) the LHS is a parenthesized expression, and cp/semantics.c:finish_parenthesized_expr() contains the following gem: tree finish_parenthesized_expr (tree expr) { if (EXPR_P (expr)) /* This inhibits warnings in c_common_truthvalue_conversion. */ TREE_NO_WARNING (expr) = 1; Disabling either the setting of TREE_NO_WARNING in finish_parenthesized_expr or the && !TREE_NO_WARNING check in cp_build_binary_op restores the warning for this test case. Alas I'm sure something else will break in that case ...
next prev parent reply other threads:[~2011-08-14 12:25 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-07 11:22 [Bug c++/50012] New: " mikpe at it dot uu.se 2011-08-07 19:52 ` [Bug c++/50012] " mikpe at it dot uu.se 2011-08-08 10:09 ` [Bug c++/50012] [4.5/4.6/4.7 Regression] " rguenth at gcc dot gnu.org 2011-08-14 12:43 ` mikpe at it dot uu.se [this message] 2011-08-19 7:34 ` jakub at gcc dot gnu.org 2011-10-10 12:19 ` rguenth at gcc dot gnu.org 2011-12-19 15:00 ` jakub at gcc dot gnu.org 2012-01-05 17:43 ` jakub at gcc dot gnu.org 2012-01-07 1:32 ` ian at airs dot com 2012-01-14 0:26 ` ian at gcc dot gnu.org 2012-01-14 0:27 ` [Bug c++/50012] [4.5/4.6 " ian at airs dot com 2012-07-02 12:07 ` rguenth at gcc dot gnu.org 2012-11-13 11:24 ` [Bug c++/50012] [4.6 " paolo.carlini at oracle dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-50012-4-TbajeCS03d@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).