* [Bug libffi/50051] MIPS libffi does not compile for mips64octeon-linux-gnu
2011-08-11 22:08 [Bug libffi/50051] New: MIPS libffi does not compile for mips64octeon-linux-gnu pinskia at gcc dot gnu.org
@ 2011-08-11 22:33 ` pinskia at gcc dot gnu.org
2011-08-11 22:59 ` pinskia at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2011-08-11 22:33 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50051
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |build
Target| |mips64octeon-linux-gnu
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-08-11 22:33:28 UTC ---
libtool: compile: /data/src/gcc-fsf/local/gcc/objdir-mips64/./gcc/xgcc
-B/data/src/gcc-fsf/local/gcc/objdir-mips64/./gcc/
-B/data/src/gcc-cavium/clean/trunk/tools/mips64-octeon-linux-gnu/bin/
-B/data/src/gcc-cavium/clean/trunk/tools/mips64-octeon-linux-gnu/lib/ -isystem
/data/src/gcc-cavium/clean/trunk/tools/mips64-octeon-linux-gnu/include -isystem
/data/src/gcc-cavium/clean/trunk/tools/mips64-octeon-linux-gnu/sys-include
-DHAVE_CONFIG_H -I. -I/data/src/gcc-fsf/local/gcc/objdir-mips64/../libffi -I.
-I/data/src/gcc-fsf/local/gcc/objdir-mips64/../libffi/include -Iinclude
-I/data/src/gcc-fsf/local/gcc/objdir-mips64/../libffi/src -I.
-I/data/src/gcc-fsf/local/gcc/objdir-mips64/../libffi/include -Iinclude
-I/data/src/gcc-fsf/local/gcc/objdir-mips64/../libffi/src -g -O2
-minterlink-mips16 -MT src/mips/n32.lo -MD -MP -MF src/mips/.deps/n32.Tpo -c
/data/src/gcc-fsf/local/gcc/objdir-mips64/../libffi/src/mips/n32.S -fPIC -DPIC
-o src/mips/.libs/n32.o
/data/src/gcc-fsf/local/gcc/objdir-mips64/../libffi/src/mips/n32.S: Assembler
messages:
/data/src/gcc-fsf/local/gcc/objdir-mips64/../libffi/src/mips/n32.S:115: Error:
opcode not supported on this processor: octeon (mips64r2) `l.s $f12,0*8($25)'
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libffi/50051] MIPS libffi does not compile for mips64octeon-linux-gnu
2011-08-11 22:08 [Bug libffi/50051] New: MIPS libffi does not compile for mips64octeon-linux-gnu pinskia at gcc dot gnu.org
2011-08-11 22:33 ` [Bug libffi/50051] " pinskia at gcc dot gnu.org
@ 2011-08-11 22:59 ` pinskia at gcc dot gnu.org
2011-12-07 11:00 ` green at redhat dot com
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2011-08-11 22:59 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50051
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-08-11 22:59:28 UTC ---
Simple fix which works for me:
Index: src/mips/n32.S
===================================================================
--- src/mips/n32.S (revision 177681)
+++ src/mips/n32.S (working copy)
@@ -43,6 +43,7 @@
#ifdef __GNUC__
.abicalls
#endif
+ .set mips4
.text
.align 2
.globl ffi_call_N32
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libffi/50051] MIPS libffi does not compile for mips64octeon-linux-gnu
2011-08-11 22:08 [Bug libffi/50051] New: MIPS libffi does not compile for mips64octeon-linux-gnu pinskia at gcc dot gnu.org
2011-08-11 22:33 ` [Bug libffi/50051] " pinskia at gcc dot gnu.org
2011-08-11 22:59 ` pinskia at gcc dot gnu.org
@ 2011-12-07 11:00 ` green at redhat dot com
2011-12-07 16:00 ` pinskia at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: green at redhat dot com @ 2011-12-07 11:00 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50051
Anthony Green <green at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2011-12-07
CC| |green at redhat dot com
Ever Confirmed|0 |1
--- Comment #3 from Anthony Green <green at redhat dot com> 2011-12-07 11:00:05 UTC ---
(In reply to comment #2)
> Simple fix which works for me:
> Index: src/mips/n32.S
> ===================================================================
> --- src/mips/n32.S (revision 177681)
> +++ src/mips/n32.S (working copy)
> @@ -43,6 +43,7 @@
> #ifdef __GNUC__
> .abicalls
> #endif
> + .set mips4
> .text
> .align 2
> .globl ffi_call_N32
Thanks Andrew. Does this force the generation of FP instructions, which are
then emulated through OS traps?
AG
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libffi/50051] MIPS libffi does not compile for mips64octeon-linux-gnu
2011-08-11 22:08 [Bug libffi/50051] New: MIPS libffi does not compile for mips64octeon-linux-gnu pinskia at gcc dot gnu.org
` (2 preceding siblings ...)
2011-12-07 11:00 ` green at redhat dot com
@ 2011-12-07 16:00 ` pinskia at gcc dot gnu.org
2011-12-07 21:48 ` green at redhat dot com
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2011-12-07 16:00 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50051
--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-12-07 16:00:25 UTC ---
(In reply to comment #3)
> Thanks Andrew. Does this force the generation of FP instructions, which are
> then emulated through OS traps?
Yes and the traps are always enabled in newish kernels.
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libffi/50051] MIPS libffi does not compile for mips64octeon-linux-gnu
2011-08-11 22:08 [Bug libffi/50051] New: MIPS libffi does not compile for mips64octeon-linux-gnu pinskia at gcc dot gnu.org
` (3 preceding siblings ...)
2011-12-07 16:00 ` pinskia at gcc dot gnu.org
@ 2011-12-07 21:48 ` green at redhat dot com
2011-12-07 22:59 ` pinskia at gcc dot gnu.org
2011-12-07 23:00 ` pinskia at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: green at redhat dot com @ 2011-12-07 21:48 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50051
--- Comment #5 from Anthony Green <green at redhat dot com> 2011-12-07 21:48:29 UTC ---
(In reply to comment #4)
> (In reply to comment #3)
> > Thanks Andrew. Does this force the generation of FP instructions, which are
> > then emulated through OS traps?
>
> Yes and the traps are always enabled in newish kernels.
I'm OK with this change. Andrew - could you please commit it to GCC and I'll
pull it into the libffi sidestream project?
Thanks!
AG
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libffi/50051] MIPS libffi does not compile for mips64octeon-linux-gnu
2011-08-11 22:08 [Bug libffi/50051] New: MIPS libffi does not compile for mips64octeon-linux-gnu pinskia at gcc dot gnu.org
` (4 preceding siblings ...)
2011-12-07 21:48 ` green at redhat dot com
@ 2011-12-07 22:59 ` pinskia at gcc dot gnu.org
2011-12-07 23:00 ` pinskia at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2011-12-07 22:59 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50051
--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-12-07 22:59:10 UTC ---
Author: pinskia
Date: Wed Dec 7 22:59:06 2011
New Revision: 182092
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182092
Log:
2011-12-07 Andrew Pinski <apinski@cavium.com>
PR libffi/50051
* src/mips/n32.S: Add ".set mips4".
Modified:
trunk/libffi/ChangeLog
^ permalink raw reply [flat|nested] 8+ messages in thread* [Bug libffi/50051] MIPS libffi does not compile for mips64octeon-linux-gnu
2011-08-11 22:08 [Bug libffi/50051] New: MIPS libffi does not compile for mips64octeon-linux-gnu pinskia at gcc dot gnu.org
` (5 preceding siblings ...)
2011-12-07 22:59 ` pinskia at gcc dot gnu.org
@ 2011-12-07 23:00 ` pinskia at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2011-12-07 23:00 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50051
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
Target Milestone|--- |4.7.0
--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-12-07 22:59:23 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 8+ messages in thread