public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/50070] Segmentation fault at size_binop_loc in fold-const.c Date: Tue, 16 Aug 2011 09:37:00 -0000 [thread overview] Message-ID: <bug-50070-4-WxzgtrvJaE@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-50070-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50070 --- Comment #10 from janus at gcc dot gnu.org 2011-08-16 09:19:07 UTC --- Here is a patch which rejects the test case with a different error message than comment #6: Index: gcc/fortran/resolve.c =================================================================== --- gcc/fortran/resolve.c (revision 177779) +++ gcc/fortran/resolve.c (working copy) @@ -10169,15 +10169,22 @@ resolve_fl_variable (gfc_symbol *sym, int mp_flag) if (!gfc_is_constant_expr (e) && !(e->expr_type == EXPR_VARIABLE - && e->symtree->n.sym->attr.flavor == FL_PARAMETER) - && sym->ns->proc_name - && (sym->ns->proc_name->attr.flavor == FL_MODULE - || sym->ns->proc_name->attr.is_main_program) - && !sym->attr.use_assoc) + && e->symtree->n.sym->attr.flavor == FL_PARAMETER)) { - gfc_error ("'%s' at %L must have constant character length " - "in this context", sym->name, &sym->declared_at); - return FAILURE; + if (!sym->attr.use_assoc && sym->ns->proc_name + && (sym->ns->proc_name->attr.flavor == FL_MODULE + || sym->ns->proc_name->attr.is_main_program)) + { + gfc_error ("'%s' at %L must have constant character length " + "in this context", sym->name, &sym->declared_at); + return FAILURE; + } + if (sym->attr.in_common) + { + gfc_error ("COMMON variable '%s' at %L must have constant " + "character length", sym->name, &sym->declared_at); + return FAILURE; + } } }
next prev parent reply other threads:[~2011-08-16 9:19 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-13 7:12 [Bug fortran/50070] New: " zeccav at gmail dot com 2011-08-13 11:23 ` [Bug fortran/50070] " janus at gcc dot gnu.org 2011-08-13 12:06 ` janus at gcc dot gnu.org 2011-08-13 12:09 ` janus at gcc dot gnu.org 2011-08-14 12:08 ` janus at gcc dot gnu.org 2011-08-14 12:25 ` janus at gcc dot gnu.org 2011-08-14 13:21 ` janus at gcc dot gnu.org 2011-08-14 14:11 ` dominiq at lps dot ens.fr 2011-08-15 9:20 ` janus at gcc dot gnu.org 2011-08-15 9:53 ` janus at gcc dot gnu.org 2011-08-16 9:37 ` janus at gcc dot gnu.org [this message] 2011-08-17 9:26 ` janus at gcc dot gnu.org 2011-08-17 11:13 ` janus at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-50070-4-WxzgtrvJaE@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).