[Bug middle-end/50113] New: soft-float MIPS64 compiler is miscompiling ggc-page.c

[Bug middle-end/50113] New: soft-float MIPS64 compiler is miscompiling ggc-page.c

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50113

             Bug #: 50113
           Summary: soft-float MIPS64 compiler is miscompiling ggc-page.c
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: pinskia@gcc.gnu.org


Building a n32 MIPS64 GCC with soft-float on the trunk currently miscompiles
ggc-page.c and the check if it should collect or not.  Changing the variables
to unsigned instead of float allows the bootstrap to continue in a nice way.

[Bug middle-end/50113] [4.7 Regression] soft-float MIPS64 compiler is miscompiling ggc-page.c

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50113

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build, wrong-code
             Target|                            |mips64octeon-linux-gnu
                 CC|                            |ddaney at caviumnetworks
                   |                            |dot com
   Target Milestone|---                         |4.7.0
            Summary|soft-float MIPS64 compiler  |[4.7 Regression] soft-float
                   |is miscompiling ggc-page.c  |MIPS64 compiler is
                   |                            |miscompiling ggc-page.c

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-08-18 06:00:31 UTC ---
Oh printing out the variables via an int type shows they are 0 which is wrong.

[Bug middle-end/50113] [4.7 Regression] soft-float MIPS64 compiler is miscompiling ggc-page.c

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50113

--- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-08-18 09:07:29 UTC ---
Can you try disabling the VRP code that changes unsigned -> float to
int -> float (simplify_float_conversion_using_ranges)?

[Bug middle-end/50113] [4.7 Regression] soft-float MIPS64 compiler is miscompiling ggc-page.c

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50113

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-08-18 19:11:13 UTC ---
FAIL: gcc.c-torture/execute/ieee/920518-1.c execution,  -O0 
FAIL: gcc.c-torture/execute/ieee/920518-1.c execution,  -O1 
FAIL: gcc.c-torture/execute/ieee/920518-1.c execution,  -O2 
FAIL: gcc.c-torture/execute/ieee/920518-1.c execution,  -O3
-fomit-frame-pointer 
FAIL: gcc.c-torture/execute/ieee/920518-1.c execution,  -O3 -g 
FAIL: gcc.c-torture/execute/ieee/920518-1.c execution,  -Os 
FAIL: gcc.c-torture/execute/ieee/920518-1.c execution,  -O2 -flto
-flto-partition=none 

And many more which means the soft-float under MIPS is broken somehow.

[Bug middle-end/50113] [4.7 Regression] soft-float MIPS64 compiler is miscompiling ggc-page.c

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50113

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-08-18 19:14:54 UTC ---
-       dsll    $4,$4,32
        move    $5,$2
-       dsll    $5,$5,32

[Bug middle-end/50113] [4.7 Regression] soft-float MIPS64 compiler is miscompiling ggc-page.c

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50113

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
             Status|UNCONFIRMED                 |NEW
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2011-08/msg00735.htm
                   |                            |l
   Last reconfirmed|                            |2011-08-18
     Ever Confirmed|0                           |1

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-08-18 19:19:45 UTC ---
So Richard Sandiford reported this same bug and provided a fix:
http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00735.html

[Bug middle-end/50113] [4.7 Regression] soft-float MIPS64 compiler is miscompiling ggc-page.c

[rsandifo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50113

rsandifo@gcc.gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |rsandifo at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |rsandifo at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #6 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> 2011-08-19 08:13:34 UTC ---
Related to PR50061 (although that's for hard rather than
soft float).

[Bug middle-end/50113] [4.7 Regression] soft-float MIPS64 compiler is miscompiling ggc-page.c

[rsandifo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50113

--- Comment #7 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> 2011-09-22 12:26:48 UTC ---
Author: rsandifo
Date: Thu Sep 22 12:26:41 2011
New Revision: 179085

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=179085
Log:
gcc/
    PR middle-end/50113
    PR middle-end/50061
    * calls.c (emit_library_call_value_1): Use BLOCK_REG_PADDING to
    get the locate.where_pad value for register-only arguments.
    * config/arm/arm.c (arm_pad_arg_upward): Remove HFmode handling.
    (arm_pad_reg_upward): Handle null types.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/calls.c
    trunk/gcc/config/arm/arm.c

[Bug middle-end/50113] [4.7 Regression] soft-float MIPS64 compiler is miscompiling ggc-page.c

[rsandifo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50113

rsandifo@gcc.gnu.org <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from rsandifo at gcc dot gnu.org <rsandifo at gcc dot gnu.org> 2011-10-02 17:48:40 UTC ---
Patch applied to trunk.