From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28532 invoked by alias); 2 Sep 2011 11:00:32 -0000 Received: (qmail 28502 invoked by uid 22791); 2 Sep 2011 11:00:31 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Sep 2011 11:00:16 +0000 From: "marc.glisse at normalesup dot org" To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/50268] [C++0x] bitset doesn't sanitize input Date: Fri, 02 Sep 2011 11:00:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libstdc++ X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: marc.glisse at normalesup dot org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: paolo.carlini at oracle dot com X-Bugzilla-Target-Milestone: 4.6.2 X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg00127.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50268 --- Comment #11 from Marc Glisse 2011-09-02 10:59:46 UTC --- (In reply to comment #10) > (by the way, if you can see a neat enough way to improve _M_are_all_aux, you > are welcome to propose it! I'm definitely not an expert in this area, and when > I implemented it, I remember just quickly hacking something close to what we > have elsewhere, which I could easily convince myself was correct) all(), when it reaches the last chunk, checks (nbchunk-1)*chunksize+popcount(lastchunk)==size(). It seems to me that it should check instead lastchunk==mask (where mask is something like ~(~0UL<