[Bug lto/50293] New: -flto fails if GCC is installed in directory with space in path name

[Bug lto/50293] New: -flto fails if GCC is installed in directory with space in path name

[jon at beniston dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50293

             Bug #: 50293
           Summary: -flto fails if GCC is installed in directory with
                    space in path name
    Classification: Unclassified
           Product: gcc
           Version: 4.6.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jon@beniston.com


The majority of GCC seems to run fine if installed in a directory with spaces
in the filename. However, there seems to be an issue if -flto is used in 4.6.1
that wasn't an issue in 4.5.1.

collect2 version 4.6.1 (arm/ELF)
/cygdrive/c/Program
Files/gnu/bin/../lib/gcc/arm-elf/4.6.1/../../../../arm-elf/bin/ld -plugin
/cygdrive/c/Program
Files/gnu/bin/../libexec/gcc/arm-elf/4.6.1/cyglto_plugin-0.dll
-plugin-opt=/cygdrive/c/Program
Files/gnu/bin/../libexec/gcc/arm-elf/4.6.1/lto-wrapper.exe
-plugin-opt=-fresolution=/tmp/ccRdw4BE.res -plugin-opt=-pass-through=-lgcc
-plugin-opt=-pass-through=-lgcc --relax -EL -v -L/cygdrive/c/Program
Files/gnu/bin/../lib/gcc/arm-elf/4.6.1/cyclone -L/cygdrive/c/Program
Files/gnu/bin/../lib/gcc/arm-elf/4.6.1/../../../../arm-elf/lib/cyclone
-L/cygdrive/c/Program Files/gnu/bin/../lib/gcc/arm-elf/4.6.1
-L/cygdrive/c/Program Files/gnu/bin/../lib/gcc -L/cygdrive/c/Program
Files/gnu/bin/../lib/gcc/arm-elf/4.6.1/../../../../arm-elf/lib /tmp/cciZHvSE.o
-lgcc -T crt0.ld -lgcc -T cyclone.ld
/cygdrive/c/Program
Files/gnu/bin/../lib/gcc/arm-elf/4.6.1/../../../../arm-elf/bin/ld:
/cygdrive/c/Program: error in plugin cleanup (ignored)
/cygdrive/c/Program
Files/gnu/bin/../lib/gcc/arm-elf/4.6.1/../../../../arm-elf/bin/ld:
/cygdrive/c/Program: error loading plugin
collect2: ld returned 1 exit status

I tried quoting the options in the specs file, but that didn't seem to help.
i.e.:

 -plugin "%(linker_plugin_file)"     -plugin-opt="%(lto_wrapper)"

[Bug lto/50293] -flto fails if GCC is installed in directory with space in path name

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50293

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-09-05 11:14:08 UTC ---
I'm not sure the quoting will survive, it is, for example, passed to the
collect-ld script and re-issued from lto-wrapper itself.

[Bug lto/50293] -flto fails if GCC is installed in directory with space in path name

[jmesmon at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50293

--- Comment #2 from Cody Schafer <jmesmon at gmail dot com> 2012-10-14 00:58:44 UTC ---
I've just run into the same issue with gcc 4.7.2 (using the binary here:
http://www.makehackvoid.com/sites/default/files/MHV_AVR_Tools_20121007.exe )

Disabling LTO allows the link to complete.

[Bug lto/50293] -flto fails if GCC is installed in directory with space in path name

[jye2 at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50293

--- Comment #3 from jye2 at gcc dot gnu.org 2013-03-06 06:32:15 UTC ---
Author: jye2
Date: Wed Mar  6 06:32:03 2013
New Revision: 196485

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=196485
Log:
2013-03-06  Joey Ye  <joey.ye@arm.com>

    PR lto/50293
    * gcc.c (convert_white_space): New function.
    (main): Handles white space in function name.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gcc.c

[Bug lto/50293] -flto fails if GCC is installed in directory with space in path name

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50293

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |lto
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-03-06
     Ever Confirmed|0                           |1
      Known to fail|                            |4.6.2, 4.7.2

--- Comment #4 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2013-03-06 19:29:47 UTC ---
Thanks for the patch.  I tested it together with a --target=avr
--host=i386-mingw32 --build=i686-linux-gnu canadian cross with spaces in the
install pass.

Will this be backported?

[Bug lto/50293] -flto fails if GCC is installed in directory with space in path name

[jye2 at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50293

--- Comment #5 from jye2 at gcc dot gnu.org 2013-03-08 07:25:17 UTC ---
Author: jye2
Date: Fri Mar  8 07:25:09 2013
New Revision: 196534

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=196534
Log:
013-03-08  Joey Ye  <joey.ye@arm.com>

    Backport from mainline
    2013-03-06  Joey Ye  <joey.ye@arm.com>

    PR lto/50293
    * gcc.c (convert_white_space): New function.
    (main): Handles white space in function name.

Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/gcc.c

[Bug lto/50293] -flto fails if GCC is installed in directory with space in path name

[gjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50293

Georg-Johann Lay <gjl at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.3

[Bug lto/50293] -flto fails if GCC is installed in directory with space in path name

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50293

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.