From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27253 invoked by alias); 28 Nov 2011 13:47:44 -0000 Received: (qmail 27241 invoked by uid 22791); 28 Nov 2011 13:47:43 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00,TW_TM X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Nov 2011 13:47:27 +0000 From: "matz at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug debug/50317] [4.7 Regression] missing DW_OP_GNU_implicit_pointer Date: Mon, 28 Nov 2011 14:18:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: debug X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: matz at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 4.7.0 X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg02649.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50317 --- Comment #7 from Michael Matz 2011-11-28 13:46:45 UTC --- (In reply to comment #6) > Patch to drop ={v} {CLOBBER} stmts when the lhs lost TREE_ADDRESSABLE bit > during execute_update_addresses_taken. Actually it's not only the loss of TREE_ADDRESSABLE, but more specifically that the symbol is marked for renaming now (i.e. will become a SSA name). There are other decls (not of gimple_reg type) that aren't marked addressed but still aren't renamed (and therefore the clobbers are still useful). I see that your patch does the right thing for this, but just wanted to mention it because it's really the renaming, not the loss of TREE_ADDRESSABLE that makes removing the clobber a good idea. I think your condition is a bit too verbose. marked_for_renaming implies !TREE_ADDRESSABLE, and a clobber statement should always have a gimple_vdef. Then, adding another IL walk just for this? Why does your first patch ICE? Can't that be fixed up somehow?