[Bug tree-optimization/50318] New: ICE optimizing widening multiply-and-accumulate

[Bug tree-optimization/50318] New: ICE optimizing widening multiply-and-accumulate

[ams at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50318

             Bug #: 50318
           Summary: ICE optimizing widening multiply-and-accumulate
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ams@gcc.gnu.org


The widening mulitply pass creates a bad expression when using constants with
types that don't match the other operand:

(This testcase is reduced from the Linux kernel)

long long test (unsigned int sec, unsigned long long nsecs)
{
 return (long long)(long)sec * 1000000000L + (long long)(unsigned
long)nsecs;
}

dummy.i: In function ‘test’:
dummy.i:2:11: error: type mismatch in widening multiply-accumulate
expression
long long int
unsigned int
long int
long long int
D.4708_8 = WIDEN_MULT_PLUS_EXPR <sec_1(D), 1000000000, D.4720_11>;

dummy.i:2:11: internal compiler error: verify_gimple failed

[Bug tree-optimization/50318] ICE optimizing widening multiply-and-accumulate

[ams at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50318

Andrew Stubbs <ams at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011-09-07
         AssignedTo|unassigned at gcc dot       |ams at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #1 from Andrew Stubbs <ams at gcc dot gnu.org> 2011-09-07 11:08:06 UTC ---
The problem is a bug in my recent widening-multiplies patch. :(

[Bug tree-optimization/50318] ICE optimizing widening multiply-and-accumulate

[ams at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50318

--- Comment #2 from Andrew Stubbs <ams at gcc dot gnu.org> 2011-09-08 19:45:41 UTC ---
Author: ams
Date: Thu Sep  8 19:45:37 2011
New Revision: 178708

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=178708
Log:
2011-09-08  Andrew Stubbs  <ams@codesourcery.com>

    PR tree-optimization/50318

    gcc/
    * tree-ssa-math-opts.c (convert_plusminus_to_widen): Correct
    typo in use of mult_rhs1 and mult_rhs2.

    gcc/testsuite/
    * gcc.target/arm/pr50318-1.c: New file.



Added:
    trunk/gcc/testsuite/gcc.target/arm/pr50318-1.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-math-opts.c

[Bug tree-optimization/50318] ICE optimizing widening multiply-and-accumulate

[ams at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50318

Andrew Stubbs <ams at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Andrew Stubbs <ams at gcc dot gnu.org> 2011-09-08 19:52:11 UTC ---
This should be resolved now.