[Bug target/50355] New: Comparison is always true in alpha config code

[Bug target/50355] New: Comparison is always true in alpha config code

[dcb314 at hotmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50355

             Bug #: 50355
           Summary: Comparison is always true in alpha config code
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dcb314@hotmail.com


I just tried the cppcheck tool over the source code of
gcc 4.7 snapshot 20110910.

The tool said

[gcc/config/alpha/alpha.c:5059]: (style) Mismatching comparison, the result is
always true

The source code is

      && (INTVAL (x) & 7) != 8)

Maybe the 8 should be changed to some other integer constant ?

[Bug target/50355] Comparison is always true in alpha config code

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=50355

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egallager at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2020-11-06

--- Comment #2 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Eric Gallager from comment #1)
> I can't seem to find the code in question in the source file any longer...

WAITING for David to reconfirm

[Bug target/50355] Comparison is always true in alpha config code

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=50355

--- Comment #3 from David Binderman <dcb314 at hotmail dot com> ---
$ fgrep INTVAL /home/dcb/gcc/trunk.git/gcc/config/alpha/alpha.c | fgrep 8
      && INTVAL (XEXP (x, 1)) == -8)
  mod_f = memmodel_from_int (INTVAL (operands[8]));
               (INTVAL (x) & 0xffff) - 2 * (INTVAL (x) & 0x8000));
               (INTVAL (x) == 8 ? "b"
      fprintf (file, HOST_WIDE_INT_PRINT_DEC, INTVAL (x) / 8);

So some nine years later, the code doesn't seem to exist anymore.

[Bug target/50355] Comparison is always true in alpha config code

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=50355

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|WAITING                     |RESOLVED

--- Comment #4 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to David Binderman from comment #3)
> $ fgrep INTVAL /home/dcb/gcc/trunk.git/gcc/config/alpha/alpha.c | fgrep 8
>       && INTVAL (XEXP (x, 1)) == -8)
>   mod_f = memmodel_from_int (INTVAL (operands[8]));
> 	       (INTVAL (x) & 0xffff) - 2 * (INTVAL (x) & 0x8000));
> 	       (INTVAL (x) == 8 ? "b"
>       fprintf (file, HOST_WIDE_INT_PRINT_DEC, INTVAL (x) / 8);
> 
> So some nine years later, the code doesn't seem to exist anymore.

ok, closing as FIXED then