[Bug target/50356] New: Poor if condition in h8300 config code

[Bug target/50356] New: Poor if condition in h8300 config code

[dcb314 at hotmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50356

             Bug #: 50356
           Summary: Poor if condition in h8300 config code
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dcb314@hotmail.com


I just tried the cppcheck tool over the source code of
gcc 4.7 snapshot 20110910.

The tool said

[gcc/config/h8300/h8300.c:1209]: (warning) Mutual exclusion over || always
evaluates to true. Did you intend to use && instead?

The source code is

   if (-4 <= n || n <= 4)

Maybe better code might be

   if (-4 <= n && n <= 4)

[Bug target/50356] Poor if condition in h8300 config code

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50356

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kazu at codesourcery dot
                   |                            |com, law at redhat dot com,
                   |                            |manu at gcc dot gnu.org

--- Comment #1 from Manuel López-Ibáñez <manu at gcc dot gnu.org> 2012-10-04 09:20:41 UTC ---
GCC would have caught this with -Wlogical-op, if it was enabled.

[Bug target/50356] Poor if condition in h8300 config code

[law at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50356

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-10-04
     Ever Confirmed|0                           |1

--- Comment #2 from Jeffrey A. Law <law at redhat dot com> 2012-10-04 19:04:45 UTC ---
Note that this bug will only effect the quality of the code we generate as this
bug is in a costing function.  I'll have it fixed shortly.

[Bug target/50356] Poor if condition in h8300 config code

[law at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50356

--- Comment #3 from Jeffrey A. Law <law at gcc dot gnu.org> 2012-10-04 20:58:33 UTC ---
Author: law
Date: Thu Oct  4 20:58:30 2012
New Revision: 192103

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=192103
Log:
    * PR target/50356
    * config/h8300/h8300.c (h8300_rtx_costs): Fix typo in CONST_INT case.



Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/h8300/h8300.c

[Bug target/50356] Poor if condition in h8300 config code

[law at redhat dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50356

Jeffrey A. Law <law at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Jeffrey A. Law <law at redhat dot com> 2012-10-04 20:59:44 UTC ---
Obvious typo fixed.