public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ebotcazou at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/50494] gcc.dg/vect/vect-reduc-2char.c fails spuriously on ppc with -flto
Date: Tue, 05 Mar 2013 13:51:00 -0000	[thread overview]
Message-ID: <bug-50494-4-tZLbAhCFCl@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-50494-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50494

--- Comment #26 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2013-03-05 13:51:28 UTC ---
> The question is why we don't hit lto-lang.c:lto_set_decl_assembler_name
> mangling of !TREE_PUBLIC decls when streaming in the decl for the constant
> pool entries (or when computing the assembler name at some point).
> I suppose we never compute decl-assembler-name for the constant pool entries
> but emit them in a special way?

Right, see make_decl_rtl:

  /* If this variable belongs to the global constant pool, retrieve the
     pre-computed RTL or recompute it in LTO mode.  */
  if (TREE_CODE (decl) == VAR_DECL && DECL_IN_CONSTANT_POOL (decl))
    {
      SET_DECL_RTL (decl, output_constant_def_1 (DECL_INITIAL (decl),
                         decl, 1));
      return;
    }

> At least build_constant_desc seems to create a raw SYMBOL_RER using the raw
> created label?  But then, as we don't stream the constant-descs, the RTL 
> should refer to unique labels (but DECL_NAME and the SYMBOL_REF symbol do not
> agree).

I think the problem is that, with your patch, the DECLs are not unified when
they have the same DECL_INITIAL (decl), even if they have the same RTL in the
end.


  parent reply	other threads:[~2013-03-05 13:51 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23 14:47 [Bug target/50494] New: " vries at gcc dot gnu.org
2011-09-23 15:05 ` [Bug target/50494] " vries at gcc dot gnu.org
2011-09-23 15:30 ` vries at gcc dot gnu.org
2011-09-23 22:23 ` vries at gcc dot gnu.org
2012-01-02  7:02 ` irar at il dot ibm.com
2013-02-12 18:14 ` meissner at gcc dot gnu.org
2013-02-12 18:19 ` meissner at gcc dot gnu.org
2013-02-12 18:26 ` [Bug lto/50494] " meissner at gcc dot gnu.org
2013-02-12 18:36 ` rguenth at gcc dot gnu.org
2013-02-12 19:07 ` meissner at gcc dot gnu.org
2013-02-12 19:17 ` meissner at gcc dot gnu.org
2013-02-13  9:05 ` rguenther at suse dot de
2013-02-13 10:55 ` rguenth at gcc dot gnu.org
2013-02-13 10:56 ` rguenth at gcc dot gnu.org
2013-02-13 22:14 ` ebotcazou at gcc dot gnu.org
2013-02-13 22:38 ` meissner at gcc dot gnu.org
2013-02-14  8:56 ` rguenther at suse dot de
2013-02-14  9:19 ` ebotcazou at gcc dot gnu.org
2013-02-14 10:41 ` rguenther at suse dot de
2013-02-14 12:25 ` rguenth at gcc dot gnu.org
2013-02-14 12:25 ` rguenth at gcc dot gnu.org
2013-03-04 15:32 ` ebotcazou at gcc dot gnu.org
2013-03-04 15:43 ` rguenth at gcc dot gnu.org
2013-03-04 16:11 ` ebotcazou at gcc dot gnu.org
2013-03-05 10:18 ` rguenth at gcc dot gnu.org
2013-03-05 13:20 ` rguenth at gcc dot gnu.org
2013-03-05 13:51 ` ebotcazou at gcc dot gnu.org [this message]
2013-03-05 13:58 ` rguenther at suse dot de
2013-03-05 14:23 ` ebotcazou at gcc dot gnu.org
2013-03-05 14:26 ` rguenther at suse dot de
2013-03-05 14:39 ` ebotcazou at gcc dot gnu.org
2013-03-05 15:09 ` rguenther at suse dot de
2013-03-05 15:32 ` ebotcazou at gcc dot gnu.org
2013-03-05 15:49 ` rguenther at suse dot de
2013-03-05 16:06 ` ebotcazou at gcc dot gnu.org
2013-03-06  8:39 ` rguenth at gcc dot gnu.org
2013-03-06  8:46 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-50494-4-tZLbAhCFCl@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).