[Bug c++/50500] New: [C++0x] [DR 1082] move constructor should cause copy constructor to be deleted, but still declared

[Bug c++/50500] New: [C++0x] [DR 1082] move constructor should cause copy constructor to be deleted, but still declared

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50500

             Bug #: 50500
           Summary: [C++0x] [DR 1082] move constructor should cause copy
                    constructor to be deleted, but still declared
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jason@gcc.gnu.org


G++ still suppresses the copy constructor declaration when there is a move
constructor, which was changed by DR 1082.

This should complain about a deleted function:


template <class T> T&& move(T& t);

struct X
{
  X() : x(1) {}
  explicit X(X&& other) : x(other.x) { other.x = -1; }
  int x;
};

int main()
{
  X x;
  X x2 = move(x); // { dg-error "deleted" }                                     
}

[Bug c++/50500] [C++0x] [DR 1082] move constructor should cause copy constructor to be deleted, but still declared

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50500

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011-10-17
         AssignedTo|unassigned at gcc dot       |jason at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

[Bug c++/50500] [C++0x] [DR 1082] move constructor should cause copy constructor to be deleted, but still declared

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50500

--- Comment #1 from Jason Merrill <jason at gcc dot gnu.org> 2011-10-18 17:39:26 UTC ---
Author: jason
Date: Tue Oct 18 17:39:15 2011
New Revision: 180159

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=180159
Log:
    PR c++/50500
    DR 1082
    * class.c (type_has_user_declared_move_constructor): New.
    (type_has_user_declared_move_assign): New.
    (add_implicitly_declared_members): Add lazy copy ops
    even if there's a move.
    * method.c (lazily_declare_fn): Delete implicit copies
    if there's a move.
    (maybe_explain_implicit_delete): Explain this.  Use inform rather
    than error.
    * cp-tree.h: Declare new fns.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/implicit12.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/class.c
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/method.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/cpp0x/defaulted20.C
    trunk/gcc/testsuite/g++.dg/cpp0x/defaulted21.C
    trunk/gcc/testsuite/g++.dg/cpp0x/implicit-copy.C
    trunk/gcc/testsuite/g++.dg/cpp0x/implicit4.C
    trunk/gcc/testsuite/g++.dg/cpp0x/implicit5.C
    trunk/gcc/testsuite/g++.dg/cpp0x/implicit8.C
    trunk/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-ice2.C
    trunk/gcc/testsuite/g++.dg/cpp0x/not_special.C
    trunk/gcc/testsuite/g++.dg/cpp0x/rv-trivial-bug.C
    trunk/gcc/testsuite/g++.dg/cpp0x/rv1n.C
    trunk/gcc/testsuite/g++.dg/cpp0x/rv2n.C
    trunk/gcc/testsuite/g++.dg/cpp0x/rv3n.C
    trunk/gcc/testsuite/g++.dg/cpp0x/rv4n.C
    trunk/gcc/testsuite/g++.dg/cpp0x/rv5n.C
    trunk/gcc/testsuite/g++.dg/cpp0x/rv6n.C
    trunk/gcc/testsuite/g++.dg/cpp0x/rv7n.C
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/bits/shared_ptr.h
    trunk/libstdc++-v3/testsuite/20_util/weak_ptr/comparison/cmp_neg.cc
    trunk/libstdc++-v3/testsuite/util/testsuite_allocator.h
    trunk/libstdc++-v3/testsuite/util/testsuite_rvalref.h

[Bug c++/50500] [C++0x] [DR 1082] move constructor should cause copy constructor to be deleted, but still declared

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50500

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.0

--- Comment #2 from Jason Merrill <jason at gcc dot gnu.org> 2011-10-18 18:06:02 UTC ---
Fixed.

[Bug c++/50500] [C++0x] [DR 1082] move constructor should cause copy constructor to be deleted, but still declared

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50500

--- Comment #3 from Jason Merrill <jason at gcc dot gnu.org> 2011-11-01 13:48:21 UTC ---
Author: jason
Date: Tue Nov  1 13:48:16 2011
New Revision: 180738

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=180738
Log:
    PR c++/50500
    DR 1082
    * search.c (lookup_fnfields_idx_nolazy): Split out from...
    (lookup_fnfields_1): ...here.
    (lookup_fnfields_slot_nolazy): Use it.
    * cp-tree.h: Declare it.
    * class.c (type_has_move_assign): Use it.
    (type_has_user_declared_move_assign): Likewise.

Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/class.c
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/search.c