[Bug middle-end/50607] New: [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[Bug middle-end/50607] New: [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

             Bug #: 50607
           Summary: [4.7 Regression] FAIL: gcc.dg/bconstp-3.c
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com
                CC: artyom.shinkaroff@gmail.com


On Linux/x86, revision 179463 gave

FAIL: gcc.dg/bconstp-3.c (test for excess errors)

Revision 179447 was OK.  I got

Executing on host: /export/build/gnu/gcc-x32/build-x86_64-linux/gcc/xgcc
-B/export/build/gnu/gcc-x32/build-x86_64-linux/gcc/
/export/gnu/import/git/gcc/gcc/testsuite/gcc.dg/bconstp-3.c     -ansi
-pedantic-errors -S  -o bconstp-3.s    (timeout = 300)
spawn -ignore SIGHUP /export/build/gnu/gcc-x32/build-x86_64-linux/gcc/xgcc
-B/export/build/gnu/gcc-x32/build-x86_64-linux/gcc/
/export/gnu/import/git/gcc/gcc/testsuite/gcc.dg/bconstp-3.c -ansi
-pedantic-errors -S -o bconstp-3.s^M
/export/gnu/import/git/gcc/gcc/testsuite/gcc.dg/bconstp-3.c:23:3: error:
initializer element is not a constant expression^M
/export/gnu/import/git/gcc/gcc/testsuite/gcc.dg/bconstp-3.c:23:3: error: (near
initialization for 'tests[4]')^M
/export/gnu/import/git/gcc/gcc/testsuite/gcc.dg/bconstp-3.c:24:3: error:
initializer element is not a constant expression^M
/export/gnu/import/git/gcc/gcc/testsuite/gcc.dg/bconstp-3.c:24:3: error: (near
initialization for 'tests[5]')^M
...

It is caused by revision 179462:

http://gcc.gnu.org/ml/gcc-cvs/2011-10/msg00055.html

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

--- Comment #1 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2011-10-03 23:09:44 UTC ---
For cris-elf too (unsurprisingly as the error seems universal), plus I'm seeing
a:

FAIL: gcc.c-torture/execute/pr23135.c compilation,  -O2 -flto  (internal
compiler error)

gcc.log:
Executing on host: /tmp/hpautotest-gcc1/cris-elf/gccobj/gcc/xgcc
-B/tmp/hpautotest-gcc1/cris-elf/gccobj/gcc/
/tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.c-torture/execute/pr23135.c   -w 
-O2 -flto -flto-partition=none    -isystem
/tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/./newlib/targ-include -isystem
/tmp/hpautotest-gcc1/gcc/newlib/libc/include
-B/tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/./libgloss/cris/
-L/tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/./libgloss/cris
-L/tmp/hpautotest-gcc1/gcc/libgloss/cris 
-B/tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/./newlib/
-L/tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/./newlib -sim3  -lm   -o
/tmp/hpautotest-gcc1/cris-elf/gccobj/gcc/testsuite/gcc/pr23135.x6    (timeout =
300)
In file included from :0:0:
/tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.c-torture/execute/pr23135.c: In
function 'main':
/tmp/hpautotest-gcc1/gcc/gcc/testsuite/gcc.c-torture/execute/pr23135.c:31:1:
internal compiler error: Segmentation fault

(No SIMD thingies on this target; the test-case is vector-related so badness in
the generic-vector machinery.)

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[artyom.shinkaroff at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

--- Comment #2 from Artem Shinkarov <artyom.shinkaroff at gmail dot com> 2011-10-03 23:17:22 UTC ---
That seems to be the changes caused by the patch I have committed. However, may
be this is a test-case that needs adjustment. 

I'll have to consult with Joseph. He asked to change the behavior of both
functions.

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[artyom.shinkaroff at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

--- Comment #3 from Artem Shinkarov <artyom.shinkaroff at gmail dot com> 2011-10-03 23:32:47 UTC ---
(In reply to comment #1)
> For cris-elf too (unsurprisingly as the error seems universal), plus I'm seeing
> a:
> 
> FAIL: gcc.c-torture/execute/pr23135.c compilation,  -O2 -flto  (internal
> compiler error)

This is very unlikely that my patch caused this. The testcase as I can see uses
8-byte vectors and standard arithmetic operations. My patch introduces vector
shuffling on 16-byte vectors. The way the operations from pr23135.c are
performed didn't change.

On x86 linux the testcase does not cause segfaults, so may be you could
investigate via gdb which function cause segfault on cris-elf.


Thanks,
Artem.

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

--- Comment #4 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2011-10-04 00:04:54 UTC ---
(In reply to comment #3)
> On x86 linux the testcase does not cause segfaults, so may be you could
> investigate via gdb which function cause segfault on cris-elf.

I cloned this PR, see PR50609.

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu.org
   Target Milestone|---                         |4.7.0

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[Greta.Yorsh at arm dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

Greta Yorsh <Greta.Yorsh at arm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Greta.Yorsh at arm dot com

--- Comment #5 from Greta Yorsh <Greta.Yorsh at arm dot com> 2011-10-04 14:32:55 UTC ---
This test also fails on arm-none-eabi for trunk r :

FAIL: gcc.dg/bconstp-3.c (test for excess errors)

It fails with trunk revision r179462 and passes with r179447.

The new tests added by revision r179462 also fail.

/gcc/testsuite/gcc.c-torture/execute/vect-shuffle-1.c
    trunk/gcc/testsuite/gcc.c-torture/execute/vect-shuffle-2.c
    trunk/gcc/testsuite/gcc.c-torture/execute/vect-shuffle-3.c
    trunk/gcc/testsuite/gcc.c-torture/execute/vect-shuffle-4.c
    trunk/gcc/testsuite/gcc.c-torture/execute/vect-shuffle-5.c


http://gcc.gnu.org/ml/gcc-cvs/2011-10/msg00055.html


arm-none-eabi-gcc gcc/testsuite/gcc.dg/bconstp-3.c -ansi -pedantic-errors
-DSTACK_SIZE=16384 -S    -o bconstp-3.s 
...
Excess errors:
/arm/scratch/pdtltest/work/sandboxes/fsf/trunk/source/gcc-fsf/gcc/testsuite/gcc.dg/bconstp-3.c:23:3:
error: initializer element is not a constant expression
/arm/scratch/pdtltest/work/sandboxes/fsf/trunk/source/gcc-fsf/gcc/testsuite/gcc.dg/bconstp-3.c:23:3:
error: (near initialization for 'tests[4]')
/arm/scratch/pdtltest/work/sandboxes/fsf/trunk/source/gcc-fsf/gcc/testsuite/gcc.dg/bconstp-3.c:24:3:
error: initializer element is not a constant expression
/arm/scratch/pdtltest/work/sandboxes/fsf/trunk/source/gcc-fsf/gcc/testsuite/gcc.dg/bconstp-3.c:24:3:
error: (near initialization for 'tests[5]')
/arm/scratch/pdtltest/work/sandboxes/fsf/trunk/source/gcc-fsf/gcc/testsuite/gcc.dg/bconstp-3.c:25:3:
error: initializer element is not a constant expression
/arm/scratch/pdtltest/work/sandboxes/fsf/trunk/source/gcc-fsf/gcc/testsuite/gcc.dg/bconstp-3.c:25:3:
error: (near initialization for 'tests[6]')
/arm/scratch/pdtltest/work/sandboxes/fsf/trunk/source/gcc-fsf/gcc/testsuite/gcc.dg/bconstp-3.c:27:1:
error: initializer element is not a constant expression
/arm/scratch/pdtltest/work/sandboxes/fsf/trunk/source/gcc-fsf/gcc/testsuite/gcc.dg/bconstp-3.c:27:1:
error: (near initialization for 'tests[7]')

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[artyom.shinkaroff at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

--- Comment #6 from Artem Shinkarov <artyom.shinkaroff at gmail dot com> 2011-10-04 15:12:54 UTC ---
Created attachment 25410
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=25410
Fixes the failure caused by non-preserving original_code of c_expr.

Bootstrapped and regteted on all the tests that include modified __builtin_XXX
functions:

-- All the tests that use __builtin_choose_expr
gcc/testsuite/gcc.dg/gnu89-const-expr-2.c
gcc/testsuite/gcc.dg/Wunused-var-2.c
gcc/testsuite/gcc.dg/builtin-choose-expr.c
gcc/testsuite/gcc.dg/builtin-choose-expr-2.c
gcc/testsuite/gcc.dg/bconstp-3.c
gcc/testsuite/gcc.dg/bconstp-4.c
gcc/testsuite/gcc.dg/gnu99-const-expr-2.c

-- All the tests that use __builtin_complex
gcc/testsuite/gcc.dg/builtin-complex-err-2.c
gcc/testsuite/gcc.dg/torture/builtin-complex-1.c
gcc/testsuite/gcc.dg/dfp/builtin-complex.c
gcc/testsuite/gcc.dg/builtin-complex-err-1.c

-- All the tests that use __builtin_shuffle
gcc/testsuite/gcc.c-torture/execute/vect-shuffle-3.c
gcc/testsuite/gcc.c-torture/execute/vect-shuffle-2.c
gcc/testsuite/gcc.c-torture/execute/vect-shuffle-1.c
gcc/testsuite/gcc.c-torture/execute/vect-shuffle-4.c
gcc/testsuite/gcc.c-torture/execute/vect-shuffle-5.c

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[artyom.shinkaroff at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

--- Comment #7 from Artem Shinkarov <artyom.shinkaroff at gmail dot com> 2011-10-06 02:07:38 UTC ---
bconstp-3.c failure is fixed with the commit 179588.

2011-10-06  Artjoms Sinkarovs  <artyom.shinkaroff@gmail.com>
        * c-tree.h (c_expr_t): New typedef for struct c_expr.
        (C_EXPR_APPEND): New macro.
        * c-parser.c (c_parser_get_builtin_args): Preserve 
        original_tree_code of c_expr structure. Fixes bconstp-3.c
        failure of PR50607.
        (c_parser_postfix_expression): Adjust to the new function.


The problem of vect-shuffle tests should be resolved by commit 179564.


Thanks,
Artem.

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

--- Comment #8 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2011-10-06 07:04:32 UTC ---
(In reply to comment #7)
> bconstp-3.c failure is fixed with the commit 179588.
> 
> The problem of vect-shuffle tests should be resolved by commit 179564.

Confirmed gone tested r179590 for cris-elf. Thanks.

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[Greta.Yorsh at arm dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

--- Comment #9 from Greta Yorsh <Greta.Yorsh at arm dot com> 2011-10-06 10:44:34 UTC ---
There is still a problem on arm: vect-shuffle-2.c and vect-shuffle-5.c fail
with ICE at all optimization levels above -O0 (other vect-shuffle-*.c tests
pass).
ICE is a segfault in expand_vec_shuffle_expr (optabs.c:6660), here are the
details:

$ arm-eabi-gcc vect-shuffle-2.c  -O1 -c 

vect-shuffle-2.c: In function 'main':
vect-shuffle-2.c:30:8: internal compiler error: Segmentation fault

Trunk revision r179558.
Configured with: --with-cpu=cortex-a9 --with-float=softfp --with-fpu=neon 
--target=arm-eabi --enable-checking=release --disable-gdbtk --disable-werror
--disable-tui --disable-rda --disable-sid --disable-utils --disable-lto
--disable-lto --disable-werror --disable-shared --disable-nls --disable-threads
--disable-tls --enable-checking=yes --enable-languages=c,c++,fortran
--with-newlib

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[hp at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

--- Comment #10 from Hans-Peter Nilsson <hp at gcc dot gnu.org> 2011-10-06 12:39:07 UTC ---
(In reply to comment #9)
> There is still a problem on arm: vect-shuffle-2.c and vect-shuffle-5.c fail
> with ICE at all optimization levels above -O0 (other vect-shuffle-*.c tests
> pass).
> ICE is a segfault in expand_vec_shuffle_expr (optabs.c:6660), here are the
> details:
> 
> $ arm-eabi-gcc vect-shuffle-2.c  -O1 -c 

Please open a separate bug report, the problems are gone for i686, at least
according to <http://gcc.gnu.org/ml/gcc-testresults/2011-10/msg00664.html>.

(At the first suspicion that an additional observation is a separate bug, clone
or open a separate report, thanks.)

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[Greta.Yorsh at arm dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

--- Comment #11 from Greta Yorsh <Greta.Yorsh at arm dot com> 2011-10-06 13:40:33 UTC ---
> Please open a separate bug report, the problems are gone for i686, at least
> according to <http://gcc.gnu.org/ml/gcc-testresults/2011-10/msg00664.html>.

Cloned: PR50629

[Bug middle-end/50607] [4.7 Regression] FAIL: gcc.dg/bconstp-3.c

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50607

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-10-10 15:17:40 UTC ---
Fixed.