[Bug c++/50744] New: ice in good_cloning_opportunity_p

[Bug c++/50744] New: ice in good_cloning_opportunity_p

[dcb314 at hotmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50744

             Bug #: 50744
           Summary: ice in good_cloning_opportunity_p
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dcb314@hotmail.com


Created attachment 25514
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=25514
C++ source code

I just tried to compile the package polyml-5.4.1-1
on latest trunk snapshot 20111015 on an AMD x86_64 box.

The compiler said

foreign.cpp: At global scope:
foreign.cpp:1919:1: internal compiler error: in good_cloning_opportunity_p, at
ipa-cp.c:1228
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Preprocessed source code attached. Flag -O3 required.

[Bug c++/50744] ice in good_cloning_opportunity_p

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50744

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu.org

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-10-16 12:21:44 UTC ---
tree-optimization?

[Bug tree-optimization/50744] [4.7 Regression] ice in good_cloning_opportunity_p

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50744

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|rguenth at gcc dot gnu.org  |jamborm at gcc dot gnu.org
          Component|c++                         |tree-optimization
   Target Milestone|---                         |4.7.0
            Summary|ice in                      |[4.7 Regression] ice in
                   |good_cloning_opportunity_p  |good_cloning_opportunity_p

[Bug tree-optimization/50744] [4.7 Regression] ice in good_cloning_opportunity_p

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50744

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011-10-27
     Ever Confirmed|0                           |1

--- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-10-27 11:03:25 UTC ---
Confirmed.

[Bug tree-optimization/50744] [4.7 Regression] ice in good_cloning_opportunity_p

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50744

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jamborm at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Martin Jambor <jamborm at gcc dot gnu.org> 2011-11-14 16:50:02 UTC ---
Hm, apparently the effect propagation can still go wild on recursive code and
size effects can overflow to negtive values, triggering this assert.  Mine.

[Bug tree-optimization/50744] [4.7 Regression] ice in good_cloning_opportunity_p

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50744

--- Comment #4 from Martin Jambor <jamborm at gcc dot gnu.org> 2011-11-15 00:25:12 UTC ---
Created attachment 25822
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=25822
Testcase suitable for the testsuite

Testcase suitable for the test suite - it is not that difficult to make it
overflow, after all.  I will submit a patch with a simple cutoff when
accumulating benefits tomorrow.

[Bug tree-optimization/50744] [4.7 Regression] ice in good_cloning_opportunity_p

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50744

--- Comment #5 from Martin Jambor <jamborm at gcc dot gnu.org> 2011-11-18 18:06:18 UTC ---
Proposed fix posted to the mailing list:

http://gcc.gnu.org/ml/gcc-patches/2011-11/msg01935.html

[Bug tree-optimization/50744] [4.7 Regression] ice in good_cloning_opportunity_p

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50744

--- Comment #6 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-12-06 13:52:58 UTC ---
Also see PR51362 which looks related (is it a dup? size overflowing to zero?)

[Bug tree-optimization/50744] [4.7 Regression] ice in good_cloning_opportunity_p

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50744

--- Comment #7 from Martin Jambor <jamborm at gcc dot gnu.org> 2011-12-07 10:30:55 UTC ---
Author: jamborm
Date: Wed Dec  7 10:30:49 2011
New Revision: 182076

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182076
Log:
2011-12-07  Martin Jambor  <mjambor@suse.cz>

    PR tree-optimization/50744
    * ipa-cp.c (good_cloning_opportunity_p): Assert size_cost is positive,
    compute evaluation in HOST_WIDEST_INT.
    (safe_add): New function
    (propagate_effects): Use safe_add to accumulate effects.

    * testsuite/gcc.dg/ipa/pr50744.c: New test.


Added:
    trunk/gcc/testsuite/gcc.dg/ipa/pr50744.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-cp.c
    trunk/gcc/testsuite/ChangeLog

[Bug tree-optimization/50744] [4.7 Regression] ice in good_cloning_opportunity_p

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50744

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Martin Jambor <jamborm at gcc dot gnu.org> 2011-12-07 10:36:48 UTC ---
Fixed.