[Bug bootstrap/50777] New: [4.7 regression] bootstrap fails on Solaris 10

[Bug bootstrap/50777] New: [4.7 regression] bootstrap fails on Solaris 10

[gseanmcg at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50777

             Bug #: 50777
           Summary: [4.7 regression] bootstrap fails on Solaris 10
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: gseanmcg@gmail.com


Bootstrap is failing on i386-pc-solaris2.10 after revision 180093 with
madvise() being undeclared.

According to Oracle this function requires sys/types.h and sys/mman.h on
Solaris -- are they included elsewhere?

[Bug bootstrap/50777] [4.7 regression] bootstrap fails on Solaris 10

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50777

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-10-18 15:26:08 UTC ---
My guess would not be a missing header, but missing feature test macro

[Bug bootstrap/50777] [4.7 regression] bootstrap fails on Solaris 10

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50777

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011-10-18
                 CC|                            |bonzini at gnu dot org, ian
                   |                            |at airs dot com
   Target Milestone|---                         |4.7.0
     Ever Confirmed|0                           |1

--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> 2011-10-18 16:09:06 UTC ---
They are, via system.h.  The problem is twofold:

* madvise(3) is declared in <sys/mman.h> conditionally: in the Solaris 10
  version of the header, we have:

#ifdef    __STDC__
#if (_POSIX_C_SOURCE > 2) || defined(_XPG4_2)
...
#else    /* (_POSIX_C_SOURCE > 2) || defined(_XPG4_2) */
...
extern int madvise(caddr_t, size_t, int)...
...
#endif    /* (_POSIX_C_SOURCE > 2)  || defined(_XPG4_2) */

* configure uses the C compiler to detect support for madvise() and finds it,
  while the actual compilation happens with g++, which defines
_XOPEN_SOURCE=600,
  among others, which hides the declaration.

In Solaris 11, there's no issue AFAICS since with __EXTENSIONS__ defined (which
configure takes care of), the madivse() prototype is visible.  I'm currently
running a bootstrap to verify this.

There are two options:

* Actually perform the configure tests with the compiler to be used (g++)
instead
  of gcc.  Everything else is bound to yield bogus results once in a while, or
  at least do so for madvise.

* Hack around this with fixincludes, but in this case I'd consider this a bug
  by itself.

Paolo, Ian, suggestions?

  Rainer

[Bug bootstrap/50777] [4.7 regression] bootstrap fails on Solaris 10

[ian at airs dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50777

--- Comment #3 from Ian Lance Taylor <ian at airs dot com> 2011-10-18 21:07:12 UTC ---
I would advise handling madvise in the same way that we handle AM_ICONV in
gcc/configure.ac, to work around a similar issue.

[Bug bootstrap/50777] [4.7 regression] bootstrap fails on Solaris 10

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50777

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2011-10/msg01726.htm
                   |                            |l
         AssignedTo|unassigned at gcc dot       |ro at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> 2011-10-19 14:19:24 UTC ---
Mine, patch submitted.

[Bug bootstrap/50777] [4.7 regression] bootstrap fails on Solaris 10

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50777

--- Comment #5 from Rainer Orth <ro at gcc dot gnu.org> 2011-10-19 16:02:35 UTC ---
Author: ro
Date: Wed Oct 19 16:02:30 2011
New Revision: 180195

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=180195
Log:
Properly test for madvise on Solaris 10 (PR bootstrap/50777)

    PR bootstrap/50777
    * configure.ac: Save and restore CXXFLAGS around
    gcc_AC_CHECK_DECLS uses.
    Check for madvise() declaration with g++ if --enable-build-with-cxx.
    * configure: Regenerate.
    * config.in: Regenerate.
    * ggc-page.c (USING_MADVISE): Also check HAVE_DECL_MADVISE.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config.in
    trunk/gcc/configure   (contents, props changed)
    trunk/gcc/configure.ac
    trunk/gcc/ggc-page.c

[Bug bootstrap/50777] [4.7 regression] bootstrap fails on Solaris 10

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50777

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> 2011-10-19 16:21:35 UTC ---
Fixed for 4.7.0.

[Bug bootstrap/50777] [4.7 regression] bootstrap fails on Solaris 10

[gseanmcg at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50777

--- Comment #7 from Sean McGovern <gseanmcg at gmail dot com> 2011-10-19 16:39:15 UTC ---
Thanks for the fix, bootstrapping that revision now.

-- Sean McG.
------Original Message------
From: ro at gcc dot gnu.org
To: McGovern, Sean
Subject: [Bug bootstrap/50777] [4.7 regression] bootstrap fails on Solaris 10
Sent: Oct 19, 2011 12:21

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50777

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> 2011-10-19 12:21:35 EDT
---
Fixed for 4.7.0.