[Bug target/50842] New: gnatmake fails to link in stage3 with undefined symbol _iconv_close

[Bug target/50842] New: gnatmake fails to link in stage3 with undefined symbol _iconv_close

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

             Bug #: 50842
           Summary: gnatmake fails to link in stage3 with undefined symbol
                    _iconv_close
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: danglin@gcc.gnu.org
              Host: i686-apple-darwin9
            Target: i686-apple-darwin9
             Build: i686-apple-darwin9


../../xgcc -B../../  -I- -I../rts -I. -I/Users/dave/gnu/gcc/gcc/gcc/ada
-DIN_GCC
  -g -O2 -W -Wall  -o ../../gnatmake b_gnatm.o a-except.o ali.o ali-util.o
aspec
ts.o s-casuti.o alloc.o atree.o binderr.o butil.o casing.o csets.o debug.o
elist
s.o einfo.o errout.o erroutc.o errutil.o err_vars.o fmap.o fname.o fname-uf.o
fn
ame-sf.o gnatmake.o gnatvsn.o hostparm.o interfac.o i-c.o i-cstrin.o krunch.o
li
b.o make.o makeusg.o makeutl.o mlib.o mlib-fil.o mlib-prj.o mlib-tgt.o
mlib-tgt-
specific.o mlib-utl.o namet.o nlists.o opt.o osint.o osint-m.o output.o prj.o
pr
j-attr.o prj-attr-pm.o prj-com.o prj-dect.o prj-env.o prj-conf.o prj-pp.o
prj-er
r.o prj-ext.o prj-nmsc.o prj-pars.o prj-part.o prj-proc.o prj-strt.o prj-tree.o 
prj-util.o restrict.o rident.o s-exctab.o s-secsta.o s-stalib.o s-stoele.o
scans
.o scng.o sdefault.o sfn_scan.o s-purexc.o s-htable.o scil_ll.o sem_aux.o
sinfo.
o sinput.o sinput-c.o sinput-p.o snames.o stand.o stringt.o styleg.o stylesw.o
s
ystem.o validsw.o switch.o switch-m.o table.o targparm.o tempdir.o tree_io.o
typ
es.o uintp.o uname.o urealp.o usage.o widechar.o  \
                    ../../libcommon-target.a ../../libcommon.a
../../../libcpp/l
ibcpp.a targext.o link.o ../rts/libgnat.a  ../../../libiberty/libiberty.a  
Undefined symbols:
  "_iconv_close", referenced from:
      __cpp_destroy_iconv in libcpp.a(charset.o)
      __cpp_destroy_iconv in libcpp.a(charset.o)
      __cpp_destroy_iconv in libcpp.a(charset.o)
      __cpp_destroy_iconv in libcpp.a(charset.o)
      __cpp_destroy_iconv in libcpp.a(charset.o)
      __cpp_convert_input in libcpp.a(charset.o)
  "_iconv", referenced from:
      convert_using_iconv(void*, unsigned char const*, unsigned long,
_cpp_strbu
f*) in libcpp.a(charset.o)
      convert_using_iconv(void*, unsigned char const*, unsigned long,
_cpp_strbu
f*) in libcpp.a(charset.o)
      convert_using_iconv(void*, unsigned char const*, unsigned long,
_cpp_strbu
f*) in libcpp.a(charset.o)
      convert_using_iconv(void*, unsigned char const*, unsigned long,
_cpp_strbu
f*) in libcpp.a(charset.o)
  "_iconv_open", referenced from:
      init_iconv_desc(cpp_reader*, char const*, char const*) in
libcpp.a(charset
.o)
ld: symbol(s) not found

dave@MACPRO:~/gnu/gcc/objdir/gcc$ ./xgcc -B./ -v
Reading specs from ./specs
COLLECT_GCC=./xgcc
COLLECT_LTO_WRAPPER=./lto-wrapper
Target: i686-apple-darwin9
Configured with: ../gcc/configure --build=i686-apple-darwin9
--host=i686-apple-darwin9 --target=i686-apple-darwin9 --with-tune=generic
--prefix=/opt/gnu/gcc/gcc-4.7.0 --with-gmp=/opt/gnu/gcc/gcc-4.7.0
--enable-debug=no --disable-nls --disable-multilib
--enable-languages=c,c++,objc,fortran,obj-c++,java,ada --enable-threads=posix
--enable-__cxa_atexit --enable-java-gc=boehm : (reconfigured) ../gcc/configure
--build=i686-apple-darwin9 --host=i686-apple-darwin9
--target=i686-apple-darwin9 --with-tune=generic --prefix=/opt/gnu/gcc/gcc-4.7.0
--with-gmp=/opt/gnu/gcc/gcc-4.7.0 --enable-debug=no --disable-nls
--disable-multilib --enable-languages=c,c++,objc,fortran,obj-c++,java,ada
--enable-threads=posix --enable-__cxa_atexit --enable-java-gc=boehm
Thread model: posix
gcc version 4.7.0 20111023 (experimental) [trunk revision 180354] (GCC)

[Bug target/50842] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

--- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> 2011-10-26 12:03:12 UTC ---
gnatmake needs to be linked against /usr/lib/libiconv.dylib.

[Bug ada/50842] [4.7 Regression] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011-10-26
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org
         AssignedTo|unassigned at gcc dot       |ebotcazou at gcc dot
                   |gnu.org                     |gnu.org
     Ever Confirmed|0                           |1

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-10-26 21:26:42 UTC ---
> gnatmake needs to be linked against /usr/lib/libiconv.dylib.

Which Makefile variable contains the -liconv flag?

[Bug ada/50842] [4.7 Regression] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

--- Comment #3 from dave.anglin at bell dot net 2011-10-26 22:36:15 UTC ---
On 26-Oct-11, at 5:26 PM, ebotcazou at gcc dot gnu.org wrote:

>> gnatmake needs to be linked against /usr/lib/libiconv.dylib.
>
> Which Makefile variable contains the -liconv flag?


The gcc  Makefile has

LIBICONV = /usr/lib/libiconv.dylib
LIBICONV_DEP =

LIBICONV is subsequently used in the LIBS variable.

Dave
--
John David Anglin    dave.anglin@bell.net

[Bug ada/50842] [4.7 Regression] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.7.0

[Bug ada/50842] [4.7 Regression] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

--- Comment #4 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-10-27 10:21:38 UTC ---
Created attachment 25627
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=25627
Tentative fix

Would you mind giving it a try?

[Bug ada/50842] [4.7 Regression] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

--- Comment #5 from dave.anglin at bell dot net 2011-10-27 15:25:41 UTC ---
On 10/27/2011 6:21 AM, ebotcazou at gcc dot gnu.org wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842
>
> --- Comment #4 from Eric Botcazou<ebotcazou at gcc dot gnu.org>  2011-10-27 10:21:38 UTC ---
> Created attachment 25627
>    -->  http://gcc.gnu.org/bugzilla/attachment.cgi?id=25627
> Tentative fix
>
> Would you mind giving it a try?
>
Didn't work.  I looked at the generated Makefile in 
gcc/ada/gcc-interface and the LIBICONV
variable wasn't set to anything.

Dave

[Bug ada/50842] [4.7 Regression] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

--- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-10-27 19:12:09 UTC ---
> Didn't work.  I looked at the generated Makefile in 
> gcc/ada/gcc-interface and the LIBICONV
> variable wasn't set to anything.

So OUTPUT_OPTION is set to the same value but not LIBICONV?

[Bug ada/50842] [4.7 Regression] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-10-27 19:23:02 UTC ---
For the record, in order to bootstrap Ada on powerpc-apple-darwin9, I have the
following patch

--- ../_gcc_clean/gcc/ada/gcc-interface/Makefile.in    2011-10-27
17:40:15.000000000 +0200
+++ ../work/gcc/ada/gcc-interface/Makefile.in    2011-10-27 19:25:49.000000000
+0200
@@ -175,6 +175,10 @@ top_builddir = ../..
 LIBINTL = @LIBINTL@
 LIBINTL_DEP = @LIBINTL_DEP@

+# Character encoding conversion library.
+LIBICONV = @LIBICONV@
+LIBICONV_DEP = @LIBICONV_DEP@
+
 # Any system libraries needed just for GNAT.
 SYSLIBS = @GNAT_LIBEXC@

@@ -242,11 +246,11 @@ LIBIBERTY = ../../libiberty/libiberty.a

 # How to link with both our special library facilities
 # and the system's installed libraries.
-LIBS = $(LIBINTL) $(LIBIBERTY) $(SYSLIBS)
-LIBDEPS = $(LIBINTL_DEP) $(LIBIBERTY)
+LIBS = $(LIBINTL) $(LIBICONV) $(LIBIBERTY) $(SYSLIBS)
+LIBDEPS = $(LIBINTL_DEP) $(LIBICONV_DEP) $(LIBIBERTY)
 # Default is no TGT_LIB; one might be passed down or something
 TGT_LIB =
-TOOLS_LIBS = $(EXTRA_GNATTOOLS_OBJS) targext.o link.o $(LIBGNAT) $(LIBINTL)
../../../libiberty/libiberty.a $(SYSLIBS) $(TGT_LIB)
+TOOLS_LIBS = $(EXTRA_GNATTOOLS_OBJS) targext.o link.o $(LIBGNAT) $(LIBINTL)
$(LIBICONV) ../../../libiberty/libiberty.a $(SYSLIBS) $(TGT_LIB)

 # Convert the target variable into a space separated list of architecture,
 # manufacturer, and operating system and assign each of those to its own

with looks similar to the one in comment #4.

[Bug ada/50842] [4.7 Regression] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iains at gcc dot gnu.org

--- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-10-27 19:29:00 UTC ---
I am using

../work/configure --prefix=/opt/gcc/gcc4.7w
--enable-languages=c,c++,fortran,objc,obj-c++,java,ada,lto --with-gmp=/sw
--with-libiconv-prefix=/usr --with-system-zlib --with-cloog=/sw --enable-lto
--enable-cloog-backend=isl

Note that I have never been able to bootstrap gcc without
'--with-libiconv-prefix=something'. We have been discussing the issue since
some time with Iain Sandoe.

[Bug ada/50842] [4.7 Regression] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

--- Comment #9 from Iain Sandoe <iains at gcc dot gnu.org> 2011-10-27 19:42:42 UTC ---
1/ FTR on *-darwin9 and x86_64-darwin10
 (default system configurations, bar GCC pre-requisites).

I can bootstrap from the 'macada' 4.3 or the Adacore libre 4.5 compilers with
or without --with-libiconv-prefix=/xxx and with it pointed to /usr or to
/opt/local (macports) or /sw64 (fink).

2/ I specifically don't allow macports/fink to add to my PATHs so that I can
test GCC against a 'standard' OSX distribution - unless I specifically append
one of them

3/ I have sneakily provided Ada in the uploaded gfortran distributions :
http://gcc.gnu.org/wiki/GFortranBinaries (for darwin 9 & 10).

4/ I am not disputing that there are issues for other folk -
  - I have a hunch that the places to look are
 (a) library PATHS being set by <your favorite> distro.
 (b) library paths embedded in the GMP/MPFR/MPC shared objects.

... I haven't been able to reproduce the problem yet (but I haven't yet tried a
'full' install of fink including allowing it to set paths).

[Bug ada/50842] [4.7 Regression] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[dave.anglin at bell dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

--- Comment #10 from dave.anglin at bell dot net 2011-10-28 02:24:45 UTC ---
On 27-Oct-11, at 3:12 PM, ebotcazou at gcc dot gnu.org wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842
>
> --- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org>  
> 2011-10-27 19:12:09 UTC ---
>> Didn't work.  I looked at the generated Makefile in
>> gcc/ada/gcc-interface and the LIBICONV
>> variable wasn't set to anything.
>
> So OUTPUT_OPTION is set to the same value but not LIBICONV?


Actually, the patch does work for me both with and without --with- 
libiconv-prefix=/usr.  In testing,
I had tried defining LIBS and this seems to interfere with the  
configure checks.  Removing the
define for LIBS fixed the problem with LIBICONV.   The substitution  
for OUTPUT_OPTION occurs
correctly.

Dave
--
John David Anglin    dave.anglin@bell.net

[Bug ada/50842] [4.7 Regression] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

--- Comment #11 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-10-28 07:13:49 UTC ---
Author: ebotcazou
Date: Fri Oct 28 07:13:44 2011
New Revision: 180605

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=180605
Log:
    PR ada/50842
    * gcc-interface/Makefile.in (SYMDEPS): Delete.
    (LIBICONV): New variable.
    (LIBICONV_DEP): Likewise.
    (LIBS): Add $(LIBICONV).
    (LIBDEPS): Add $(LIBICONV_DEP).
    (EXTRA_GNATTOOLS_OBJS): Merge into...
    (TOOLS_LIBS): ...this.  Add $(LIBICONV).

Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/gcc-interface/Makefile.in

[Bug ada/50842] [4.7 Regression] gnatmake fails to link in stage3 with undefined symbol _iconv_close

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50842

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-10-28 07:18:15 UTC ---
Patch applied.