* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
@ 2011-10-27 18:42 ` jakub at gcc dot gnu.org
2011-10-27 18:54 ` mark at gcc dot gnu.org
` (14 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-10-27 18:42 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-10-27 18:40:45 UTC ---
This affects 4.6.2 too and most probably 4.5.x too.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
2011-10-27 18:42 ` [Bug bootstrap/50888] " jakub at gcc dot gnu.org
@ 2011-10-27 18:54 ` mark at gcc dot gnu.org
2011-10-27 23:15 ` mark at gcc dot gnu.org
` (13 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mark at gcc dot gnu.org @ 2011-10-27 18:54 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
Mark Wielaard <mark at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |green at gcc dot gnu.org
--- Comment #2 from Mark Wielaard <mark at gcc dot gnu.org> 2011-10-27 18:53:35 UTC ---
(In reply to comment #0)
> or replace use of isspace (c)
> with memchr (" \t\n\r\v", c, 5) != NULL (the standard POSIX "C" locale isspace
> characters), or use safe-ctype, etc.
I think that is the best solution, or even only check for a literal space.
This code is only used to "parse" properties provided by the GCJ_PROPERTIES
environment variable. Which is a gcj extension.
It was added in 1999 and it hasn't been changed since then.
http://gcc.gnu.org/ml/java-patches/1999-q4/msg00014.html
Any opinions Anthony?
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
2011-10-27 18:42 ` [Bug bootstrap/50888] " jakub at gcc dot gnu.org
2011-10-27 18:54 ` mark at gcc dot gnu.org
@ 2011-10-27 23:15 ` mark at gcc dot gnu.org
2011-10-31 5:30 ` christian.joensson at gmail dot com
` (12 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: mark at gcc dot gnu.org @ 2011-10-27 23:15 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
--- Comment #3 from Mark Wielaard <mark at gcc dot gnu.org> 2011-10-27 23:14:02 UTC ---
<antgreen> I don't think isspace() is really needed. We can just check for ' '
and maybe tab.
<antgreen> wow - 1999 was a long time ago
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (2 preceding siblings ...)
2011-10-27 23:15 ` mark at gcc dot gnu.org
@ 2011-10-31 5:30 ` christian.joensson at gmail dot com
2011-11-16 21:18 ` pinskia at gcc dot gnu.org
` (11 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: christian.joensson at gmail dot com @ 2011-10-31 5:30 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
--- Comment #4 from Christian Joensson <christian.joensson at gmail dot com> 2011-10-31 05:29:38 UTC ---
Recent bootstrap/build on i686/linux
libtool: link: /usr/local/src/trunk/objdir/./gcc/gcj
-B/usr/local/src/trunk/objdir/i686-redhat-linux/libjava/
-B/usr/local/src/trunk/objdir/./gcc/ -B/usr/i686-redhat-linux/bin/
-B/usr/i686-redhat-linux/lib/ -isystem /usr/i686-redhat-linux/include -isystem
/usr/i686-redhat-linux/sys-include -ffloat-store -fomit-frame-pointer -Usun -g
-O2 -o .libs/jv-convert --main=gnu.gcj.convert.Convert -shared-libgcc
-L/usr/local/src/trunk/objdir/i686-redhat-linux/libjava/.libs
-L/usr/local/src/trunk/objdir/i686-redhat-linux/libjava ./.libs/libgcj.so
-lpthread -lrt -ldl -lz -Wl,-rpath -Wl,/usr/lib
./.libs/libgcj.so: undefined reference to `__cxa_call_unexpected'
collect2: error: ld returned 1 exit status
make[3]: *** [jv-convert] Error 1
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (3 preceding siblings ...)
2011-10-31 5:30 ` christian.joensson at gmail dot com
@ 2011-11-16 21:18 ` pinskia at gcc dot gnu.org
2011-11-21 19:22 ` aph at gcc dot gnu.org
` (10 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: pinskia at gcc dot gnu.org @ 2011-11-16 21:18 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hjl.tools at gmail dot com
--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> 2011-11-16 20:48:34 UTC ---
*** Bug 51177 has been marked as a duplicate of this bug. ***
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (4 preceding siblings ...)
2011-11-16 21:18 ` pinskia at gcc dot gnu.org
@ 2011-11-21 19:22 ` aph at gcc dot gnu.org
2011-11-22 15:37 ` jakub at gcc dot gnu.org
` (9 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: aph at gcc dot gnu.org @ 2011-11-21 19:22 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
--- Comment #6 from Andrew Haley <aph at gcc dot gnu.org> 2011-11-21 18:02:29 UTC ---
I suppose I don't really object to a workaround in libjava, but surely the
sensible thing to do is fix isspace() not to throw. It can't, anyway: that
would be in breach of its spec.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (5 preceding siblings ...)
2011-11-21 19:22 ` aph at gcc dot gnu.org
@ 2011-11-22 15:37 ` jakub at gcc dot gnu.org
2011-11-22 18:34 ` aph at gcc dot gnu.org
` (8 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-11-22 15:37 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-11-22 15:19:53 UTC ---
(In reply to comment #6)
> I suppose I don't really object to a workaround in libjava, but surely the
> sensible thing to do is fix isspace() not to throw. It can't, anyway: that
> would be in breach of its spec.
Sorry, forgot about this PR.
isspace is actually marked as not throwing, i.e. throw() in C++. In glibc
2.15+ it happens to be implemented as throw() inline function which calls
another function (which is throw() too), the problem is that with
-fnon-call-exceptions the compiler doesn't know the function pointer is always
non-NULL and assumes the call instruction might throw on SIGSEGV/SIGILL etc.
That will always work, but the compiler must assume it doesn't always, thus it
needs -lsupc++ support with which libjava is not linked.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (6 preceding siblings ...)
2011-11-22 15:37 ` jakub at gcc dot gnu.org
@ 2011-11-22 18:34 ` aph at gcc dot gnu.org
2011-11-23 13:35 ` jakub at gcc dot gnu.org
` (7 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: aph at gcc dot gnu.org @ 2011-11-22 18:34 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
--- Comment #8 from Andrew Haley <aph at gcc dot gnu.org> 2011-11-22 17:55:51 UTC ---
(In reply to comment #7)
> isspace is actually marked as not throwing, i.e. throw() in C++. In glibc
> 2.15+ it happens to be implemented as throw() inline function which calls
> another function (which is throw() too), the problem is that with
> -fnon-call-exceptions the compiler doesn't know the function pointer is always
> non-NULL and assumes the call instruction might throw on SIGSEGV/SIGILL etc.
> That will always work, but the compiler must assume it doesn't always, thus it
> needs -lsupc++ support with which libjava is not linked.
Thank you, all is now clear. I wonder if it might make sense to fix this
in a more general way than simply not calling isspace(). Perhaps we could
provide a weak __cxa_call_unexpected, or find some way of persuading g++ not
to emit such a call.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (7 preceding siblings ...)
2011-11-22 18:34 ` aph at gcc dot gnu.org
@ 2011-11-23 13:35 ` jakub at gcc dot gnu.org
2011-11-24 7:27 ` jakub at gcc dot gnu.org
` (6 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-11-23 13:35 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2011-11-23
AssignedTo|unassigned at gcc dot |jakub at gcc dot gnu.org
|gnu.org |
Ever Confirmed|0 |1
--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-11-23 13:19:34 UTC ---
Created attachment 25901
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=25901
gcc47-pr50888.patch
Untested fix. Checked all locales on my F16 box and in all of them isspace
is true only for these 6 characters and nothing else (iswspace accepts various
other characters, but isspace works on single bytes only and the other
characters are multi-byte.
Yes, we could perhaps define __cxa_call_unexpected instead, but we'd really
want to make sure it is hidden visibility, in order not to override the
libstdc++.so __cxa_call_unexpected. And not all targets support hidden
visibility, so it would turn into a portability nightmare.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (8 preceding siblings ...)
2011-11-23 13:35 ` jakub at gcc dot gnu.org
@ 2011-11-24 7:27 ` jakub at gcc dot gnu.org
2011-11-24 8:26 ` jakub at gcc dot gnu.org
` (5 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-11-24 7:27 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-11-24 07:18:21 UTC ---
Author: jakub
Date: Thu Nov 24 07:18:16 2011
New Revision: 181685
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181685
Log:
PR bootstrap/50888
* prims.cc: Don't include ctype.h.
(c_isspace): Define.
(next_property_key, next_property_value): Use it instead
of isspace.
Modified:
trunk/libjava/ChangeLog
trunk/libjava/prims.cc
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (9 preceding siblings ...)
2011-11-24 7:27 ` jakub at gcc dot gnu.org
@ 2011-11-24 8:26 ` jakub at gcc dot gnu.org
2011-11-24 8:42 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-11-24 8:26 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-11-24 07:21:50 UTC ---
Author: jakub
Date: Thu Nov 24 07:21:39 2011
New Revision: 181686
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181686
Log:
PR bootstrap/50888
* prims.cc: Don't include ctype.h.
(c_isspace): Define.
(next_property_key, next_property_value): Use it instead
of isspace.
Modified:
branches/gcc-4_6-branch/libjava/ChangeLog
branches/gcc-4_6-branch/libjava/prims.cc
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (10 preceding siblings ...)
2011-11-24 8:26 ` jakub at gcc dot gnu.org
@ 2011-11-24 8:42 ` jakub at gcc dot gnu.org
2011-11-24 9:22 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-11-24 8:42 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-11-24 07:23:24 UTC ---
Author: jakub
Date: Thu Nov 24 07:23:16 2011
New Revision: 181687
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181687
Log:
PR bootstrap/50888
* prims.cc: Don't include ctype.h.
(c_isspace): Define.
(next_property_key, next_property_value): Use it instead
of isspace.
Modified:
branches/gcc-4_5-branch/libjava/ChangeLog
branches/gcc-4_5-branch/libjava/prims.cc
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (11 preceding siblings ...)
2011-11-24 8:42 ` jakub at gcc dot gnu.org
@ 2011-11-24 9:22 ` jakub at gcc dot gnu.org
2011-11-24 9:24 ` jakub at gcc dot gnu.org
` (2 subsequent siblings)
15 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-11-24 9:22 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
--- Comment #13 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-11-24 07:24:49 UTC ---
Author: jakub
Date: Thu Nov 24 07:24:43 2011
New Revision: 181688
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181688
Log:
PR bootstrap/50888
* prims.cc: Don't include ctype.h.
(c_isspace): Define.
(next_property_key, next_property_value): Use it instead
of isspace.
Modified:
branches/gcc-4_4-branch/libjava/ChangeLog
branches/gcc-4_4-branch/libjava/prims.cc
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (12 preceding siblings ...)
2011-11-24 9:22 ` jakub at gcc dot gnu.org
@ 2011-11-24 9:24 ` jakub at gcc dot gnu.org
2012-07-11 6:03 ` xguo at gcc dot gnu.org
2014-04-15 23:01 ` wade.colson at aol dot com
15 siblings, 0 replies; 17+ messages in thread
From: jakub at gcc dot gnu.org @ 2011-11-24 9:24 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-11-24 08:41:17 UTC ---
Fixed for 4.4+.
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (13 preceding siblings ...)
2011-11-24 9:24 ` jakub at gcc dot gnu.org
@ 2012-07-11 6:03 ` xguo at gcc dot gnu.org
2014-04-15 23:01 ` wade.colson at aol dot com
15 siblings, 0 replies; 17+ messages in thread
From: xguo at gcc dot gnu.org @ 2012-07-11 6:03 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
--- Comment #15 from xuepeng guo <xguo at gcc dot gnu.org> 2012-07-11 06:02:17 UTC ---
Author: xguo
Date: Wed Jul 11 06:02:10 2012
New Revision: 189421
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=189421
Log:
2012-07-11 Terry Guo <terry.guo@arm.com>
Backport r181685 from mainline
2011-11-24 Jakub Jelinek <jakub@redhat.com>
PR bootstrap/50888
* prims.cc: Don't include ctype.h.
(c_isspace): Define.
(next_property_key, next_property_value): Use it instead
of isspace.
Added:
branches/ARM/embedded-4_6-branch/libjava/ChangeLog.arm
Modified:
branches/ARM/embedded-4_6-branch/libjava/prims.cc
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Bug bootstrap/50888] Bootstrap failure in libjava against latest git glibc
2011-10-27 18:40 [Bug bootstrap/50888] New: Bootstrap failure in libjava against latest git glibc jakub at gcc dot gnu.org
` (14 preceding siblings ...)
2012-07-11 6:03 ` xguo at gcc dot gnu.org
@ 2014-04-15 23:01 ` wade.colson at aol dot com
15 siblings, 0 replies; 17+ messages in thread
From: wade.colson at aol dot com @ 2014-04-15 23:01 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50888
Wade Colson <wade.colson at aol dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |wade.colson at aol dot com
--- Comment #16 from Wade Colson <wade.colson at aol dot com> ---
*** Bug 260998 has been marked as a duplicate of this bug. ***
Seen from the domain http://volichat.com
Page where seen: http://volichat.com/mobile-chat-rooms
Marked for reference. Resolved as fixed @bugzilla.
^ permalink raw reply [flat|nested] 17+ messages in thread