[Bug objc/50909] Process "#pragma options align=reset" correctly on Mac OS X

["manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=50909

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #9 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Alex from comment #8)
> As to someone implementing clang behavior: I was under the impression that
> the attached patch just needed to be applied? That is why I was inquiring as
> to why nobody had applied it after 3 years.

Writing a patch is often the easy part. The hard part is getting the patch
approved and following up on reviewer's comments. See
https://gcc.gnu.org/contribute.html and https://gcc.gnu.org/wiki/GCC_Research

The patch doesn't look correct to me anyway, but you will get a better review
from a Darwin maintainer, see the MAINTAINERS file in the gcc sources.
>From gcc-bugs-return-454718-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Jun 23 16:59:01 2014
Return-Path: <gcc-bugs-return-454718-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 22377 invoked by alias); 23 Jun 2014 16:59:01 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 21331 invoked by uid 55); 23 Jun 2014 16:58:23 -0000
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/61553] __atomic_store with non-pointer arg ICE
Date: Mon, 23 Jun 2014 16:59:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 4.9.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mpolacek at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: mpolacek at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.10.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61553-4-cz3lj0u5cS@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61553-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61553-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-06/txt/msg01800.txt.bz2
Content-length: 576

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida553

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Author: mpolacek
Date: Mon Jun 23 16:57:48 2014
New Revision: 211905

URL: https://gcc.gnu.org/viewcvs?rev!1905&root=gcc&view=rev
Log:
    PR c/61553
    * c-common.c (get_atomic_generic_size): Don't segfault if the
    type doesn't have a size.

    * c-c++-common/pr61553.c: New test.

Added:
    trunk/gcc/testsuite/c-c++-common/pr61553.c
Modified:
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-common.c
    trunk/gcc/testsuite/ChangeLog