public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "gjl at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/50910] New: [avr] inefficient division by 2 Date: Sat, 29 Oct 2011 12:16:00 -0000 [thread overview] Message-ID: <bug-50910-4@http.gcc.gnu.org/bugzilla/> (raw) http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50910 Bug #: 50910 Summary: [avr] inefficient division by 2 Classification: Unclassified Product: gcc Version: 4.7.0 Status: UNCONFIRMED Keywords: missed-optimization Severity: normal Priority: P3 Component: target AssignedTo: gjl@gcc.gnu.org ReportedBy: gjl@gcc.gnu.org CC: eric.weddington@atmel.com Target: avr The following source char c; void bar_c (int x) { c = x ? x/2 : c+1; } reveals two issues == 1 == Compiled with $ avr-gcc -S -Os there is a call to libgcc's division routine. RTX costs of division has to be checked and costs of loading the constant added to the costs of division. bar_c: sbiw r24,0 breq .L2 ldi r22,lo8(2) clr r23 rcall __divmodhi4 rjmp .L3 .L2: lds r22,c subi r22,lo8(-(1)) .L3: sts c,r22 ret == 1 == Compiled with $ avr-gcc -S -O2 the code is happily jumping around to L7 and then back to L3. bar_c: sbiw r24,0 brne .L6 lds r24,c subi r24,lo8(-(1)) sts c,r24 ret .L6: sbrc r25,7 rjmp .L7 .L3: asr r25 ror r24 sts c,r24 ret .L7: adiw r24,1 rjmp .L3 Presumably, the cause is #define BRANCH_COST 0 in avr.h, and the sequence could be instead: ... .L6: sbrc r25,7 adiw r24,1 .L3: asr r25 ror r24 sts c,r24 ret
next reply other threads:[~2011-10-29 12:16 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-10-29 12:16 gjl at gcc dot gnu.org [this message] 2011-10-29 12:20 ` [Bug target/50910] " gjl at gcc dot gnu.org 2011-11-01 14:11 ` gjl at gcc dot gnu.org 2011-11-01 14:12 ` gjl at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-50910-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).