public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/51012] [4.7 Regression] ICE: in fold_convert_loc, at fold-const.c:1897 with -fno-early-inlining and passing incompatible function ptr
Date: Tue, 08 Nov 2011 14:18:00 -0000	[thread overview]
Message-ID: <bug-51012-4-etFT2uIPYy@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-51012-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51012

--- Comment #4 from rguenther at suse dot de <rguenther at suse dot de> 2011-11-08 13:50:44 UTC ---
On Tue, 8 Nov 2011, jamborm at gcc dot gnu.org wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51012
> 
> --- Comment #3 from Martin Jambor <jamborm at gcc dot gnu.org> 2011-11-08 13:06:29 UTC ---
> (In reply to comment #2)
> > 
> > What about WPA stage?  I think we don't "fixup" inlinable status of
> > edges at the beginning of ltrans (or inline transform).  Do we?
> 
> No.  And unless this got addressed meanwhile, we don't need indirect
> inlining to hit this bug with LTO (I belive
> https://bugzilla.mozilla.org/show_bug.cgi?id=652563 is a manifestation
> of this problem).  IIRC, Honza had plausible reasons why un-doing
> inlining decisions is tough but we eventually either need that or
> store types of arguments along each call graph edge.

I understand its 'though' because we possibly have thrown away
the offline copy already before committing inline decisions?
But - can't we simply materialize the clone?  (of course that
would be possibly many clones...)

Note that with LTO symbol merging even direct calls may become
un-inlinable (because they change to an incompatible signature).

Note that the idea to _not_ inline in those cases is motivated
to behave exactly the same as if we'd not inline for such
undefined code.  We could certainly fix this up during inlining
itself - as last resort with going through a memory temporary
(ugh).  But we for sure will behave differently than the target
machine for simple integer mode mismatches (note that what we see
on gimple doesn't really reflect the target ABI or what we would
see on RTL ...)


  parent reply	other threads:[~2011-11-08 13:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 19:50 [Bug tree-optimization/51012] New: " zsojka at seznam dot cz
2011-11-08 10:37 ` [Bug tree-optimization/51012] " rguenth at gcc dot gnu.org
2011-11-08 13:07 ` rguenth at gcc dot gnu.org
2011-11-08 13:25 ` jamborm at gcc dot gnu.org
2011-11-08 14:18 ` rguenther at suse dot de [this message]
2011-11-08 15:19 ` rguenth at gcc dot gnu.org
2011-11-08 15:44 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-51012-4-etFT2uIPYy@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).