[Bug other/51022] New: powerpc libgcc static-object.mk error

[Bug other/51022] New: powerpc libgcc static-object.mk error

[joel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51022

             Bug #: 51022
           Summary: powerpc libgcc static-object.mk error
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: joel@gcc.gnu.org


Mon Nov  7 15:16:57 UTC 2011 (revision 181085)

Target: powerpc-rtems4.11 

This happens during the configure phase.  It appears that something in the
makefile logic is confused and comes up empty.

Checking multilib configuration for libgcc...
make[2]: Entering directory
`/home2/joel/build/b-powerpc-gcc/powerpc-rtems4.11/libgcc'
/users/joel/test-gcc/gcc-svn/libgcc/static-object.mk:18: *** Unsupported file
type: .  Stop.
make[2]: Leaving directory
`/home2/joel/build/b-powerpc-gcc/powerpc-rtems4.11/libgcc'
make[1]: *** [all-target-libgcc] Error 2
make[1]: Leaving directory `/home2/joel/build/b-powerpc-gcc'
make: *** [all] Error 2

[Bug other/51022] powerpc libgcc static-object.mk error

[joel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51022

--- Comment #1 from Joel Sherrill <joel at gcc dot gnu.org> 2011-11-08 04:08:53 UTC ---
Configure command as reported by config.log in the top of the build tree.

/users/joel/test-gcc/gcc-svn/configure
--with-ppl=/users/joel/test-gcc/install-svn --disable-werror
--enable-threads=rtems --with-gnu-as --enable-multilib --enable-newlib-mb
--enable-newlib-iconv --with-gnu-ld --with-newlib --verbose --with-system-zlib
--disable-nls --enable-version-specific-runtime-libs --enable-languages=c,c++
--target=powerpc-rtems4.11 --prefix=/users/joel/test-gcc/install-svn

[Bug other/51022] powerpc libgcc static-object.mk error

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51022

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2011-11-08 18:02:13 UTC ---
The port doesn't even build for me as of r181158:

/vol/gcc/src/hg/trunk/local/gcc/config/rs6000/rs6000.c: In function
'rs6000_option_override_internal':
/vol/gcc/src/hg/trunk/local/gcc/config/rs6000/rs6000.c:2826: error:
'rs6000_explicit_options' undeclared (first use in this function)
/vol/gcc/src/hg/trunk/local/gcc/config/rs6000/rs6000.c:2826: error: (Each
undeclared identifier is reported only once
/vol/gcc/src/hg/trunk/local/gcc/config/rs6000/rs6000.c:2826: error: for each
function it appears in.)

rs6000_explicit_options is only used in config/rs6000/rtems.h, but
defined nowhere I can find.

    Rainer

[Bug other/51022] powerpc libgcc static-object.mk error

[joel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51022

--- Comment #3 from Joel Sherrill <joel at gcc dot gnu.org> 2011-11-08 18:12:13 UTC ---
Created attachment 25755
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=25755
workaround for other issue

Sorry.  Something broke it in a different place before you could get to it. :(

Ralf and I are using different versions of this patch.  We need some powerpc
expert to tell us which of us, if either, have the correct and preferred patch.

[Bug other/51022] powerpc libgcc static-object.mk error

[ro at CeBiTec dot Uni-Bielefeld.DE]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51022

--- Comment #4 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> 2011-11-08 18:49:38 UTC ---
> Sorry.  Something broke it in a different place before you could get to it. :(
>
> Ralf and I are using different versions of this patch.  We need some powerpc
> expert to tell us which of us, if either, have the correct and preferred patch.

Yep, that did the trick, thanks.

What's going on (though I don't fully understand why) is that make
chokes on the fact that LIB2ADD contains
$(srcdir)/config/rs6000/ibm-ldouble.c twice, once from rs6000/t-ppccomm,
and another time from rs6000/t-ppccomm-ldbl.  Since the latter only adds
that single file, removing it in libgcc/config.host should do the trick.

I need to investigate a bit further, though: how/why did I get us there,
and what's the best way out.  I see that there's a third fragment which
adds that file (but does a bit more): rs6000/t-ibm-ldouble.

    Rainer

[Bug other/51022] powerpc libgcc static-object.mk error

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51022

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2011-11/msg02109.htm
                   |                            |l
   Last reconfirmed|                            |2011-11-21
                 CC|                            |ro at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |ro at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.7.0
     Ever Confirmed|0                           |1

--- Comment #5 from Rainer Orth <ro at gcc dot gnu.org> 2011-11-21 16:13:50 UTC ---
Mine, patch posted.

[Bug other/51022] powerpc libgcc static-object.mk error

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51022

--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> 2011-11-28 16:02:16 UTC ---
Author: ro
Date: Mon Nov 28 16:02:10 2011
New Revision: 181782

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181782
Log:
Cleanup rs6000/t-ppccomm configurations (PR other/51022)

    PR other/51022
    * config/rs6000/t-savresfgpr: New file.
    * config/rs6000/t-ppccomm (LIB2ADD_ST): Remove all but
    $(srcdir)/config/rs6000/eabi.S.
    * config/rs6000/t-ppccomm-ldbl: Remove.
    * config.host (powerpc-*-freebsd*): Add rs6000/t-savresfgpr to
    tmake_file.
    (powerpc-*-eabispe*): Likewise.
    (powerpc-*-eabi*): Likewise.
    (powerpc-*-linux*, powerpc64-*-linux*): Likewise.
    (powerpc-wrs-vxworks, powerpc-wrs-vxworksae): Add rs6000/t-ppccomm
    to tmake_file, remove rs6000/t-ppccomm-ldbl.
    (powerpc-*-eabisimaltivec*): Remove rs6000/t-ppccomm-ldbl from
    tmake_file.
    (powerpc-*-eabisim*): Likewise.
    (powerpc-*-elf*): Likewise.
    (powerpc-*-eabialtivec*): Likewise.
    (powerpc-xilinx-eabi*): Likewise.
    (powerpc-*-rtems*): Likewise.
    (powerpcle-*-elf*): Likewise.
    (powerpcle-*-eabisim*): Likewise.
    (powerpcle-*-eabi*): Likewise.

Added:
    trunk/libgcc/config/rs6000/t-savresfgpr
      - copied, changed from r181779, trunk/libgcc/config/rs6000/t-ppccomm
Removed:
    trunk/libgcc/config/rs6000/t-ppccomm-ldbl
Modified:
    trunk/libgcc/ChangeLog
    trunk/libgcc/config.host
    trunk/libgcc/config/rs6000/t-ppccomm

[Bug other/51022] powerpc libgcc static-object.mk error

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51022

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Rainer Orth <ro at gcc dot gnu.org> 2011-11-28 16:09:38 UTC ---
Fixed for 4.7.0.