[Bug testsuite/51059] New: FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on powerpc-apple-darwin9

[Bug testsuite/51059] New: FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on powerpc-apple-darwin9

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

             Bug #: 51059
           Summary: FAIL: gcc.misc-tests/gcov-14.c (test for excess
                    errors) on powerpc-apple-darwin9
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dominiq@lps.ens.fr
                CC: nathan@gcc.gnu.org


The test gcc.misc-tests/gcov-14.c (r181105) fails on powerpc-apple-darwin9
(likely on *-*-darwin*) with

FAIL: gcc.misc-tests/gcov-14.c (test for excess errors)
Excess errors:
Undefined symbols:
  "_Foo", referenced from:
      _Foo$non_lazy_ptr in cc5tyPNa.o
ld: symbol(s) not found

WARNING: gcc.misc-tests/gcov-14.c compilation failed to produce executable
Executing on host: /opt/gcc/darwin_buildw/gcc/gcov  -a gcov-14.c    (timeout =
300)
gcov-14.gcda:cannot open data file, assuming not executed
File '/opt/gcc/work/gcc/testsuite/gcc.misc-tests/gcov-14.c'
No executable lines

FAIL: gcc.misc-tests/gcov-14.c gcov failed: gcov-14.c.gcov does not exist

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on powerpc-apple-darwin9

[nathan at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

--- Comment #1 from Nathan Sidwell <nathan at gcc dot gnu.org> 2011-11-10 07:38:26 UTC ---
There's something strange about the semantics of weak & inline on darwin (or a
bug in the darwin linker?).

Here's the bits of the testcase:

extern int __attribute__ ((weak)) Foo ();

extern __inline int Foo ()
{
  return 0; /* count(-) */
}

The program doesn't call 'Foo', but uses its address.  The intent is to make
sure that there's no body of 'Foo' emitted in the executable (or at least
coverage data indicates there's no body).  As the external declaration of 'Foo'
is weak, I expect the value of the 'Foo' symbol to be 0.

So, I think this test is either invalid for Darwin (and should be skipped), or
exposing an orthogonal bug (and should be xfailed).  Someone who knows darwin
better than me needs to comment.

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iains at gcc dot gnu.org
            Summary|FAIL:                       |FAIL:
                   |gcc.misc-tests/gcov-14.c    |gcc.misc-tests/gcov-14.c
                   |(test for excess errors) on |(test for excess errors) on
                   |powerpc-apple-darwin9       |*-apple-darwin*

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-11-11 13:25:38 UTC ---
As expected, I also see this test fails on x86_64-apple-darwin10.

> So, I think this test is either invalid for Darwin (and should be skipped), or
> exposing an orthogonal bug (and should be xfailed).  Someone who knows darwin
> better than me needs to comment.

CCed Iain Sandoe.

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011-11-11
     Ever Confirmed|0                           |1

--- Comment #3 from Iain Sandoe <iains at gcc dot gnu.org> 2011-11-11 15:39:55 UTC ---
Darwin's weak comes with a price .... flat namespace.
try this:


Index: gcc/testsuite/gcc.misc-tests/gcov-14.c
===================================================================
--- gcc/testsuite/gcc.misc-tests/gcov-14.c      (revision 181278)
+++ gcc/testsuite/gcc.misc-tests/gcov-14.c      (working copy)
@@ -1,6 +1,7 @@
 /* Test gcov extern inline.  */

 /* { dg-options "-O2 -fprofile-arcs -ftest-coverage" } */
+/* { dg-options "-O2 -fprofile-arcs -ftest-coverage  -flat_namespace
-undefined suppress" { target *-*-darwin* }  } */
 /* { dg-require-weak "" } */
 /* { dg-do run { target native } } */

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-11-11 17:32:42 UTC ---
> Darwin's weak comes with a price .... flat namespace.
> try this:
> ...
> +/* { dg-options "-O2 -fprofile-arcs -ftest-coverage  -flat_namespace
>   -undefined suppress" { target *-*-darwin* }  } */
> ...

Yes, it does fix the test. Thanks.

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

--- Comment #5 from Iain Sandoe <iains at gcc dot gnu.org> 2011-11-11 19:37:00 UTC ---
Having discussed this a bit with Mike, I think that my comment about
flat_namespace is not 100% correct.

However, in this specific case, it is probably the right way to solve the
problem.

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[nathan at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

--- Comment #6 from Nathan Sidwell <nathan at gcc dot gnu.org> 2011-11-11 20:11:31 UTC ---
great, who wants to commit the fix?

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

--- Comment #7 from Iain Sandoe <iains at gcc dot gnu.org> 2011-11-11 20:21:51 UTC ---
(In reply to comment #6)
> great, who wants to commit the fix?

I'll post it ..

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

--- Comment #8 from Iain Sandoe <iains at gcc dot gnu.org> 2011-11-11 20:37:39 UTC ---
and ... to answer Nathan's question:

Darwin's weak works the way you expect -- however the symbol does have to be
present at link time.

So - one would construct a dylib:

foo.dylib:
extern __inline int Foo ();
__inline int Foo ()
{
  return 0; /* count(-) */
}

build that:
gcc ../tests/foo-dylib.c -dynamiclib  -o foo.dylib

link with it...

gcc ../tests/call-foo-main.c foo.dylib -o cf

then the dylib is removed .. 
rm foo.dylib

and ./cf behaves as you would expect (it refers to foo.dylib - but is happy for
it to be omitted).

... however, that's a bit long-winded for this case.

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

--- Comment #9 from Iain Sandoe <iains at gcc dot gnu.org> 2011-11-12 14:30:52 UTC ---
Author: iains
Date: Sat Nov 12 14:30:45 2011
New Revision: 181317

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181317
Log:

gcc/testsuite:

    PR testsuite/51059
    * gcc.misc-tests/gcov-14.c (dg-options): Force flat namespace for
    Darwin targets and allow external symbols to be undefined.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.misc-tests/gcov-14.c

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Iain Sandoe <iains at gcc dot gnu.org> 2011-11-12 14:31:16 UTC ---
fixed.

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

--- Comment #11 from Iain Sandoe <iains at gcc dot gnu.org> 2011-11-14 11:53:36 UTC ---
Author: iains
Date: Mon Nov 14 11:53:33 2011
New Revision: 181350

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181350
Log:

gcc/testsuite:

    PR testsuite/51059
    * gcc.misc-tests/gcov-14.c (dg-options): Adjust to use
    dg-additional-options.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.misc-tests/gcov-14.c

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

Jack Howarth <howarth at nitro dot med.uc.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |howarth at nitro dot
                   |                            |med.uc.edu

--- Comment #12 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-12-03 18:20:08 UTC ---
This still fails on darwin11 under Xcode 4.2.1 as....

Executing on host: /sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc/xgcc
-B/sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc/
/sw/src/fink.build/gcc47-4.7.0-1/gcc-4.7-20111202/gcc/testsuite/gcc.misc-tests/gcov-14.c
   -O2 -fprofile-arcs -ftest-coverage -flat_namespace -undefined suppress  -lm 
 -m32 -o ./gcov-14.exe    (timeout = 300)
PASS: gcc.misc-tests/gcov-14.c (test for excess errors)
Setting LD_LIBRARY_PATH to
:/sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc::/sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc
dyld: Symbol not found: _Foo
  Referenced from:
/sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc/testsuite/gcc/./gcov-14.exe
  Expected in: flat namespace
 in
/sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc/testsuite/gcc/./gcov-14.exe
FAIL: gcc.misc-tests/gcov-14.c execution test
Executing on host: /sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc/gcov  -a
gcov-14.c    (timeout = 300)
gcov-14.gcda:cannot open data file, assuming not executed^M
File
'/sw/src/fink.build/gcc47-4.7.0-1/gcc-4.7-20111202/gcc/testsuite/gcc.misc-tests/gcov-14.c'^M
No executable lines^M
^M
FAIL: gcc.misc-tests/gcov-14.c gcov failed: gcov-14.c.gcov does not exist

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

--- Comment #13 from Iain Sandoe <iains at gcc dot gnu.org> 2011-12-03 18:36:07 UTC ---
(In reply to comment #12)
> This still fails on darwin11 under Xcode 4.2.1 as....
> 
> Executing on host: /sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc/xgcc
> -B/sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc/
> /sw/src/fink.build/gcc47-4.7.0-1/gcc-4.7-20111202/gcc/testsuite/gcc.misc-tests/gcov-14.c
>    -O2 -fprofile-arcs -ftest-coverage -flat_namespace -undefined suppress  -lm 
>  -m32 -o ./gcov-14.exe    (timeout = 300)
> PASS: gcc.misc-tests/gcov-14.c (test for excess errors)
> Setting LD_LIBRARY_PATH to
> :/sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc::/sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc
> dyld: Symbol not found: _Foo
>   Referenced from:
> /sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc/testsuite/gcc/./gcov-14.exe
>   Expected in: flat namespace
>  in
> /sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc/testsuite/gcc/./gcov-14.exe
> FAIL: gcc.misc-tests/gcov-14.c execution test
> Executing on host: /sw/src/fink.build/gcc47-4.7.0-1/darwin_objdir/gcc/gcov  -a
> gcov-14.c    (timeout = 300)
> gcov-14.gcda:cannot open data file, assuming not executed^M
> File
> '/sw/src/fink.build/gcc47-4.7.0-1/gcc-4.7-20111202/gcc/testsuite/gcc.misc-tests/gcov-14.c'^M
> No executable lines^M
> ^M
> FAIL: gcc.misc-tests/gcov-14.c gcov failed: gcov-14.c.gcov does not exist

I guess it's not supporting "-undefined suppress" ... _Foo is not meant to be
found at link time.
 (that is the intention of adding -flat_namespace -undefined suppress).

I suppose you could try adding -Wl,-U,_Foo instead ...

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

--- Comment #14 from Jack Howarth <howarth at nitro dot med.uc.edu> 2011-12-03 19:01:40 UTC ---
Adding -Wl,-U,_Foo doesn't help on darwin11. Perhaps the darwin linker
developer might have some insights?

[Bug testsuite/51059] FAIL: gcc.misc-tests/gcov-14.c (test for excess errors) on *-apple-darwin*

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51059

--- Comment #15 from Iain Sandoe <iains at gcc dot gnu.org> 2011-12-03 19:05:30 UTC ---
(In reply to comment #14)
> Adding -Wl,-U,_Foo doesn't help on darwin11. Perhaps the darwin linker
> developer might have some insights?

regrettably, I think this is associated with the already-reported weak symbol
breakage.
I think we'll either have to live with the fail or XFAIL it until we get some
feedback on that.