[Bug c/51061] New: Deprecated -I- option causes segfault

[Bug c/51061] New: Deprecated -I- option causes segfault

[rmansfield at qnx dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51061

             Bug #: 51061
           Summary: Deprecated -I- option causes segfault
    Classification: Unclassified
           Product: gcc
           Version: 4.7.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: rmansfield@qnx.com
                CC: paolo.carlini@oracle.com
              Host: x86_64-linux-gnu
            Target: arm-unknown-linux-gnueabi
             Build: x86_64-linux-gnu


$ touch t.c
$ ./xgcc -B. -I- t.c
cc1: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
$ ./xgcc -v
Using built-in specs.
COLLECT_GCC=./xgcc
Target: arm-unknown-linux-gnueabi
Configured with: ../configure --target=arm-unknown-linux-gnueabi
--prefix=/home/ryan/x-tools/arm-unknown-linux-gnueabi
--with-sysroot=/home/ryan/x-tools/arm-unknown-linux-gnueabi/arm-unknown-linux-gnueabi/sys-root
--disable-multilib
--with-local-prefix=/home/ryan/x-tools/arm-unknown-linux-gnueabi/arm-unknown-linux-gnueabi/sys-root
--disable-nls --enable-threads=posix --enable-symvers=gnu --enable-c99
--enable-long-long --enable-target-optspace
target_alias=arm-unknown-linux-gnueabi --enable-languages=c++ --disable-shared
--disable-libmudflap --disable-libssp
Thread model: posix
gcc version 4.7.0 20111109 (experimental) [trunk revision 181205] (GCC)

After the fix to PR36819, -I- has split_quote_chain calling free_path with a
null path

[Bug c/51061] Deprecated -I- option causes segfault

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51061

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsm28 at gcc dot gnu.org

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-09 14:58:33 UTC ---
Bother. Frankly I don't feel like spending much time on PR36819, we can as well
revert it. Or please test the attached. Joseph, does it make sense to you?

[Bug c/51061] Deprecated -I- option causes segfault

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51061

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-09 14:59:41 UTC ---
Created attachment 25770
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=25770
Untested

[Bug c/51061] Deprecated -I- option causes segfault

[rmansfield at qnx dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51061

--- Comment #3 from Ryan Mansfield <rmansfield at qnx dot com> 2011-11-09 15:10:59 UTC ---
Yes, the patch fixes the crash. Thanks.

[Bug preprocessor/51061] Deprecated -I- option causes segfault

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51061

--- Comment #4 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-11-09 17:26:42 UTC ---
Author: paolo
Date: Wed Nov  9 17:26:37 2011
New Revision: 181216

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=181216
Log:
2011-11-09  Paolo Carlini  <paolo.carlini@oracle.com>

    PR preprocessor/51061
    * incpath.c (merge_include_chains): Make sure to not pass null
    pointers to free_path.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/incpath.c

[Bug preprocessor/51061] Deprecated -I- option causes segfault

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51061

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.0

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-11-09 17:28:23 UTC ---
Fixed, thanks for testing!