* [Bug target/51106] [4.5/4.6/4.7 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
@ 2012-01-03 11:50 ` rguenth at gcc dot gnu.org
2012-01-04 13:36 ` rguenth at gcc dot gnu.org
` (28 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-01-03 11:50 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2012-01-03
Target Milestone|--- |4.5.4
Summary|[4.5 regression] ICE in |[4.5/4.6/4.7 Regression]
|move_insn, at |ICE in move_insn, at
|haifa-sched.c:2314 |haifa-sched.c:2314
Ever Confirmed|0 |1
Known to fail| |4.7.0
--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2012-01-03 11:49:52 UTC ---
On trunk we ICE with
t.i:32:25: warning: initialization from incompatible pointer type [enabled by
default]
t.i:2:5: warning: always_inline function might not be inlinable [-Wattributes]
t.i: In function 'aes_decrypt':
t.i:30:1: error: in basic block 8:
t.i:30:1: error: flow control insn inside a basic block
(jump_insn 34 33 47 8 (parallel [
(asm_operands/v ("1: jmp %l1
2:
.section .altinstructions,"a"
.balign 4
.long 1b
.long 0
.word %P0
.byte 2b - 1b
.byte 0
.previous
") ("") 0 [
(const_int 24 [0x18])
]
[
(asm_input:HI ("i") (null):0)
]
[
(label_ref:SI 22)
] t.i:30)
(clobber (reg:QI 18 fpsr))
(clobber (reg:QI 17 flags))
]) t.i:4 -1
(expr_list:REG_UNUSED (reg:QI 18 fpsr)
(expr_list:REG_UNUSED (reg:QI 17 flags)
(nil)))
-> 22)
t.i:30:1: internal compiler error: in rtl_verify_flow_info_1, at cfgrtl.c:2002
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
at -O2 and
t.i:4:2: error: impossible constraint in 'asm'
t.i:9:1: error: too many outgoing branch edges from bb 2
t.i:9:1: internal compiler error: verify_flow_info failed
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
with -O1.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6/4.7 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
2012-01-03 11:50 ` [Bug target/51106] [4.5/4.6/4.7 Regression] " rguenth at gcc dot gnu.org
@ 2012-01-04 13:36 ` rguenth at gcc dot gnu.org
2012-01-19 9:35 ` abel at gcc dot gnu.org
` (27 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-01-04 13:36 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P2
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6/4.7 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
2012-01-03 11:50 ` [Bug target/51106] [4.5/4.6/4.7 Regression] " rguenth at gcc dot gnu.org
2012-01-04 13:36 ` rguenth at gcc dot gnu.org
@ 2012-01-19 9:35 ` abel at gcc dot gnu.org
2012-01-19 10:11 ` jakub at gcc dot gnu.org
` (26 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: abel at gcc dot gnu.org @ 2012-01-19 9:35 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Andrey Belevantsev <abel at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |abel at gcc dot gnu.org,
| |jakub at gcc dot gnu.org
--- Comment #2 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-01-19 09:24:27 UTC ---
Well, the instantiate virtual regs pass just deletes the asm as having
impossible constraints and does not clean up cfg after itself. As the asm is
actually a jump in this case, everything blows up.
The trivial patch below makes this work for -O[012]. Any other places in
function.c need patching up? Jakub, what do you think?
diff --git a/gcc/function.c b/gcc/function.c
index fcb79f5..94e51f4 100644
--- a/gcc/function.c
+++ b/gcc/function.c
@@ -1737,7 +1737,7 @@ instantiate_virtual_regs_in_insn (rtx insn)
if (!check_asm_operands (PATTERN (insn)))
{
error_for_asm (insn, "impossible constraint in %<asm%>");
- delete_insn (insn);
+ delete_insn_and_edges (insn);
}
}
else
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6/4.7 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (2 preceding siblings ...)
2012-01-19 9:35 ` abel at gcc dot gnu.org
@ 2012-01-19 10:11 ` jakub at gcc dot gnu.org
2012-01-20 6:31 ` abel at gcc dot gnu.org
` (25 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-01-19 10:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-01-19 09:43:16 UTC ---
Shorter testcase for gcc.c-torture/compile/ :
int
foo (int x)
{
asm goto ("" : : "i" (x) : : lab);
return 1;
lab:
return 0;
}
Yeah, I think delete_insn_and_edges is the right fix here. You might also add
into the testsuite:
int
bar (int x)
{
asm goto ("" : : "i" (x) : : lab);
__builtin_unreachable ();
lab:
return 0;
}
(fortunately at this point the bb ending with the asm goto still has a fallthru
successor, otherwise purge_dead_edges wouldn't work).
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6/4.7 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (3 preceding siblings ...)
2012-01-19 10:11 ` jakub at gcc dot gnu.org
@ 2012-01-20 6:31 ` abel at gcc dot gnu.org
2012-01-20 7:34 ` [Bug target/51106] [4.5/4.6 " abel at gcc dot gnu.org
` (24 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: abel at gcc dot gnu.org @ 2012-01-20 6:31 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #4 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-01-20 06:22:31 UTC ---
Author: abel
Date: Fri Jan 20 06:22:24 2012
New Revision: 183325
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=183325
Log:
gcc:/
2012-01-20 Andrey Belevantsev <abel@ispras.ru>
PR target/51106
* function.c (instantiate_virtual_regs_in_insn): Use
delete_insn_and_edges when removing a wrong asm insn.
testsuite:/
2012-01-20 Jakub Jelinek <jakub@redhat.com>
PR target/51106
* gcc.dg/torture/pr51106-1.c: New test.
* gcc.dg/torture/pr51106-2.c: New test.
Added:
trunk/gcc/testsuite/gcc.dg/torture/pr51106-1.c
trunk/gcc/testsuite/gcc.dg/torture/pr51106-2.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/function.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (4 preceding siblings ...)
2012-01-20 6:31 ` abel at gcc dot gnu.org
@ 2012-01-20 7:34 ` abel at gcc dot gnu.org
2012-01-29 17:25 ` dirtyepic at gentoo dot org
` (23 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: abel at gcc dot gnu.org @ 2012-01-20 7:34 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Andrey Belevantsev <abel at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to work| |4.7.0
Summary|[4.5/4.6/4.7 Regression] |[4.5/4.6 Regression] ICE in
|ICE in move_insn, at |move_insn, at
|haifa-sched.c:2314 |haifa-sched.c:2314
Known to fail|4.7.0 |
--- Comment #5 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-01-20 06:23:41 UTC ---
Fixed on trunk.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (5 preceding siblings ...)
2012-01-20 7:34 ` [Bug target/51106] [4.5/4.6 " abel at gcc dot gnu.org
@ 2012-01-29 17:25 ` dirtyepic at gentoo dot org
2012-02-06 12:11 ` abel at gcc dot gnu.org
` (22 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: dirtyepic at gentoo dot org @ 2012-01-29 17:25 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Ryan Hill <dirtyepic at gentoo dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dirtyepic at gentoo dot org
--- Comment #6 from Ryan Hill <dirtyepic at gentoo dot org> 2012-01-29 16:14:28 UTC ---
Can this be applied to 4.5/4.6 please?
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (6 preceding siblings ...)
2012-01-29 17:25 ` dirtyepic at gentoo dot org
@ 2012-02-06 12:11 ` abel at gcc dot gnu.org
2012-02-06 12:27 ` jakub at gcc dot gnu.org
` (21 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: abel at gcc dot gnu.org @ 2012-02-06 12:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #7 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-02-06 12:10:17 UTC ---
(In reply to comment #6)
> Can this be applied to 4.5/4.6 please?
Well, the patch was approved for trunk only, but it is committed for two weeks
now and looks safe -- Jakub?
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (7 preceding siblings ...)
2012-02-06 12:11 ` abel at gcc dot gnu.org
@ 2012-02-06 12:27 ` jakub at gcc dot gnu.org
2012-02-09 10:11 ` abel at gcc dot gnu.org
` (20 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-02-06 12:27 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-02-06 12:26:48 UTC ---
Yes, it is ok for the affected branches if bootstrap/regtest passes.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (8 preceding siblings ...)
2012-02-06 12:27 ` jakub at gcc dot gnu.org
@ 2012-02-09 10:11 ` abel at gcc dot gnu.org
2012-02-09 10:18 ` abel at gcc dot gnu.org
` (19 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: abel at gcc dot gnu.org @ 2012-02-09 10:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #9 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-02-09 10:10:41 UTC ---
Author: abel
Date: Thu Feb 9 10:10:36 2012
New Revision: 184038
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=184038
Log:
2012-02-09 Andrey Belevantsev <abel@ispras.ru>
Backport from mainline
2012-01-20 Andrey Belevantsev <abel@ispras.ru>
PR target/51106
* function.c (instantiate_virtual_regs_in_insn): Use
delete_insn_and_edges when removing a wrong asm insn.
Backport from mainline
2012-01-20 Jakub Jelinek <jakub@redhat.com>
PR target/51106
* gcc.dg/torture/pr51106-1.c: New test.
* gcc.dg/torture/pr51106-2.c: New test.
Added:
branches/gcc-4_6-branch/gcc/testsuite/gcc.dg/torture/pr51106-1.c
branches/gcc-4_6-branch/gcc/testsuite/gcc.dg/torture/pr51106-2.c
Modified:
branches/gcc-4_6-branch/gcc/ChangeLog
branches/gcc-4_6-branch/gcc/function.c
branches/gcc-4_6-branch/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (9 preceding siblings ...)
2012-02-09 10:11 ` abel at gcc dot gnu.org
@ 2012-02-09 10:18 ` abel at gcc dot gnu.org
2012-02-09 10:19 ` abel at gcc dot gnu.org
` (18 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: abel at gcc dot gnu.org @ 2012-02-09 10:18 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #10 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-02-09 10:17:59 UTC ---
Author: abel
Date: Thu Feb 9 10:17:55 2012
New Revision: 184040
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=184040
Log:
2012-02-09 Andrey Belevantsev <abel@ispras.ru>
Backport from mainline
2012-01-20 Andrey Belevantsev <abel@ispras.ru>
PR target/51106
* function.c (instantiate_virtual_regs_in_insn): Use
delete_insn_and_edges when removing a wrong asm insn.
Backport from mainline
2012-01-20 Jakub Jelinek <jakub@redhat.com>
PR target/51106
* gcc.dg/torture/pr51106-1.c: New test.
* gcc.dg/torture/pr51106-2.c: New test.
Added:
branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/torture/pr51106-1.c
branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/torture/pr51106-2.c
Modified:
branches/gcc-4_5-branch/gcc/ChangeLog
branches/gcc-4_5-branch/gcc/function.c
branches/gcc-4_5-branch/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (10 preceding siblings ...)
2012-02-09 10:18 ` abel at gcc dot gnu.org
@ 2012-02-09 10:19 ` abel at gcc dot gnu.org
2012-03-25 12:48 ` olegendo at gcc dot gnu.org
` (17 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: abel at gcc dot gnu.org @ 2012-02-09 10:19 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Andrey Belevantsev <abel at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #11 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-02-09 10:18:40 UTC ---
Tested ok, so committed to 4.5/4.6, fixed, closed.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (11 preceding siblings ...)
2012-02-09 10:19 ` abel at gcc dot gnu.org
@ 2012-03-25 12:48 ` olegendo at gcc dot gnu.org
2012-03-27 12:49 ` abel at gcc dot gnu.org
` (16 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: olegendo at gcc dot gnu.org @ 2012-03-25 12:48 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Oleg Endo <olegendo at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |olegendo at gcc dot gnu.org
--- Comment #12 from Oleg Endo <olegendo at gcc dot gnu.org> 2012-03-25 12:46:01 UTC ---
(In reply to comment #11)
> Tested ok, so committed to 4.5/4.6, fixed, closed.
I've noticed that on trunk rev 185768 the pr51106-2.c test case fails for the
SH target with:
sh_tmp.cpp: In function 'bar':
sh_tmp.cpp:163:3: warning: asm operand 0 probably doesn't match constraints
[enabled by default]
sh_tmp.cpp:163:3: error: impossible constraint in 'asm'
sh_tmp.cpp:167:1: internal compiler error: in purge_dead_edges, at
cfgrtl.c:2462
Using built-in specs.
COLLECT_GCC=sh-elf-gcc
COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/sh-elf/4.8.0/lto-wrapper
Target: sh-elf
Configured with: ../gcc-trunk/configure --target=sh-elf --prefix=/usr/local
--enable-languages=c,c++ --enable-multilib --disable-libssp --disable-nls
--disable-werror --enable-lto --with-newlib --with-gnu-as --with-gnu-ld
--with-system-zlib
Thread model: single
gcc version 4.8.0 20120324 (experimental) (GCC)
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (12 preceding siblings ...)
2012-03-25 12:48 ` olegendo at gcc dot gnu.org
@ 2012-03-27 12:49 ` abel at gcc dot gnu.org
2012-03-27 13:05 ` dominiq at lps dot ens.fr
` (15 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: abel at gcc dot gnu.org @ 2012-03-27 12:49 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Andrey Belevantsev <abel at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
CC| |rguenth at gcc dot gnu.org
Resolution|FIXED |
Target Milestone|4.5.4 |4.8.0
Known to fail| |4.8.0
--- Comment #13 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-03-27 12:42:06 UTC ---
It's failing not only on sh, but on x86-64 too, started with (no surprise here)
r185564:
2012-03-20 Richard Guenther <rguenther@suse.de>
* tree-pass.h (pass_rtl_eh): Remove.
Richard, the issue here was that when removing the wrong asm jump, we need also
to fixup the cfg. This can be done by the purge_dead_edges call because as
Jakub mentioned in comment #3 the basic block with the asm has two successor
edges, one of them is fallthru. After your patch (probably because of the new
call to cleanup_cfg) there is no more fallthru edge but a single edge. Which
blows up purge_dead_edges called from delete_insn_and_edges. So probably
purge_dead_edges should be fixed to expect not having a fallthru edge -- Jakub
may have more context here.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (13 preceding siblings ...)
2012-03-27 12:49 ` abel at gcc dot gnu.org
@ 2012-03-27 13:05 ` dominiq at lps dot ens.fr
2012-03-27 13:15 ` abel at gcc dot gnu.org
` (14 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: dominiq at lps dot ens.fr @ 2012-03-27 13:05 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #14 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-03-27 13:02:41 UTC ---
(In reply to comment #13)
> It's failing not only on sh, but on x86-64 too, started with (no surprise here)
> r185564: ...
Is it related to pr52650?
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (14 preceding siblings ...)
2012-03-27 13:05 ` dominiq at lps dot ens.fr
@ 2012-03-27 13:15 ` abel at gcc dot gnu.org
2012-03-27 13:52 ` abel at gcc dot gnu.org
` (13 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: abel at gcc dot gnu.org @ 2012-03-27 13:15 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #15 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-03-27 13:06:41 UTC ---
(In reply to comment #14)
> (In reply to comment #13)
> > It's failing not only on sh, but on x86-64 too, started with (no surprise here)
> > r185564: ...
>
> Is it related to pr52650?
Yes, I would say it is the same. It's strange that Richard didn't see this in
his testing.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (15 preceding siblings ...)
2012-03-27 13:15 ` abel at gcc dot gnu.org
@ 2012-03-27 13:52 ` abel at gcc dot gnu.org
2012-03-27 13:55 ` rguenther at suse dot de
` (12 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: abel at gcc dot gnu.org @ 2012-03-27 13:52 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #16 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-03-27 13:28:03 UTC ---
So, something like the below patch, or even better -- as we want to fold all
RTL-build related pseudo passes into expand, make pass_instantiate_virtual_regs
also the expand part (thus, until the into_cfglayout pass), and then the new
cleanup_cfg will nicely work at the end of expand.
diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c
index b86cc74..0c27d11 100644
--- a/gcc/cfgrtl.c
+++ b/gcc/cfgrtl.c
@@ -2261,7 +2261,7 @@ purge_dead_edges (basic_block bb)
edge e;
rtx insn = BB_END (bb), note;
bool purged = false;
- bool found;
+ bool found, fallthru;
edge_iterator ei;
if (DEBUG_INSN_P (insn) && insn != BB_HEAD (bb))
@@ -2433,16 +2433,22 @@ purge_dead_edges (basic_block bb)
as these are only created by conditional branches. If we find such an
edge we know that there used to be a jump here and can then safely
remove all non-fallthru edges. */
- found = false;
+ found = fallthru = false;
FOR_EACH_EDGE (e, ei, bb->succs)
- if (! (e->flags & (EDGE_COMPLEX | EDGE_FALLTHRU)))
- {
+ {
+ if (! (e->flags & (EDGE_COMPLEX | EDGE_FALLTHRU)))
found = true;
- break;
- }
-
+ if (e->flags & (EDGE_FALLTHRU | EDGE_FAKE))
+ fallthru = true;
+ }
if (!found)
return purged;
+ if (!fallthru)
+ {
+ gcc_assert (single_succ_p (bb));
+ single_succ_edge (bb)->flags |= EDGE_FALLTHRU;
+ return purged;
+ }
/* Remove all but the fake and fallthru edges. The fake edge may be
the only successor for this block in the case of noreturn
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (16 preceding siblings ...)
2012-03-27 13:52 ` abel at gcc dot gnu.org
@ 2012-03-27 13:55 ` rguenther at suse dot de
2012-03-27 14:11 ` abel at gcc dot gnu.org
` (11 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: rguenther at suse dot de @ 2012-03-27 13:55 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #17 from rguenther at suse dot de <rguenther at suse dot de> 2012-03-27 13:50:57 UTC ---
On Tue, 27 Mar 2012, abel at gcc dot gnu.org wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
>
> --- Comment #16 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-03-27 13:28:03 UTC ---
> So, something like the below patch, or even better -- as we want to fold all
> RTL-build related pseudo passes into expand, make pass_instantiate_virtual_regs
> also the expand part (thus, until the into_cfglayout pass), and then the new
> cleanup_cfg will nicely work at the end of expand.
>
> diff --git a/gcc/cfgrtl.c b/gcc/cfgrtl.c
> index b86cc74..0c27d11 100644
> --- a/gcc/cfgrtl.c
> +++ b/gcc/cfgrtl.c
> @@ -2261,7 +2261,7 @@ purge_dead_edges (basic_block bb)
> edge e;
> rtx insn = BB_END (bb), note;
> bool purged = false;
> - bool found;
> + bool found, fallthru;
> edge_iterator ei;
>
> if (DEBUG_INSN_P (insn) && insn != BB_HEAD (bb))
> @@ -2433,16 +2433,22 @@ purge_dead_edges (basic_block bb)
> as these are only created by conditional branches. If we find such an
> edge we know that there used to be a jump here and can then safely
> remove all non-fallthru edges. */
> - found = false;
> + found = fallthru = false;
> FOR_EACH_EDGE (e, ei, bb->succs)
> - if (! (e->flags & (EDGE_COMPLEX | EDGE_FALLTHRU)))
> - {
> + {
> + if (! (e->flags & (EDGE_COMPLEX | EDGE_FALLTHRU)))
> found = true;
> - break;
> - }
> -
> + if (e->flags & (EDGE_FALLTHRU | EDGE_FAKE))
> + fallthru = true;
> + }
> if (!found)
> return purged;
> + if (!fallthru)
> + {
> + gcc_assert (single_succ_p (bb));
> + single_succ_edge (bb)->flags |= EDGE_FALLTHRU;
> + return purged;
> + }
>
> /* Remove all but the fake and fallthru edges. The fake edge may be
> the only successor for this block in the case of noreturn
>
Looks reasonable. Though I think that whoever removed the fallthru
edge should have adjusted the flags on the others.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (17 preceding siblings ...)
2012-03-27 13:55 ` rguenther at suse dot de
@ 2012-03-27 14:11 ` abel at gcc dot gnu.org
2012-03-28 8:02 ` rguenther at suse dot de
` (10 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: abel at gcc dot gnu.org @ 2012-03-27 14:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #18 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-03-27 14:08:23 UTC ---
(In reply to comment #17)
> Looks reasonable. Though I think that whoever removed the fallthru
> edge should have adjusted the flags on the others.
That's simply delete_basic_block at cfgcleanup.c:2612 -- we have block 2 with
two successors 4 and 5, and block 4 is trivially dead (empty, no succ, etc.),
so when removing block 4 we just remove the 2->4 edge which is the only
fallthru one. Which seems fine as the asm in question is seen by the rest of
code as an unconditional jump then. Only when we remove it, we get no jump and
still no fallthru bit, which confuses purge_dead_edges.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.5/4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (18 preceding siblings ...)
2012-03-27 14:11 ` abel at gcc dot gnu.org
@ 2012-03-28 8:02 ` rguenther at suse dot de
2012-10-27 23:09 ` [Bug target/51106] [4.6 " davem at gcc dot gnu.org
` (9 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: rguenther at suse dot de @ 2012-03-28 8:02 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #19 from rguenther at suse dot de <rguenther at suse dot de> 2012-03-28 07:59:59 UTC ---
On Tue, 27 Mar 2012, abel at gcc dot gnu.org wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
>
> --- Comment #18 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-03-27 14:08:23 UTC ---
> (In reply to comment #17)
> > Looks reasonable. Though I think that whoever removed the fallthru
> > edge should have adjusted the flags on the others.
> That's simply delete_basic_block at cfgcleanup.c:2612 -- we have block 2 with
> two successors 4 and 5, and block 4 is trivially dead (empty, no succ, etc.),
> so when removing block 4 we just remove the 2->4 edge which is the only
> fallthru one. Which seems fine as the asm in question is seen by the rest of
> code as an unconditional jump then. Only when we remove it, we get no jump and
> still no fallthru bit, which confuses purge_dead_edges.
I see.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (19 preceding siblings ...)
2012-03-28 8:02 ` rguenther at suse dot de
@ 2012-10-27 23:09 ` davem at gcc dot gnu.org
2012-10-28 18:17 ` abel at gcc dot gnu.org
` (8 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: davem at gcc dot gnu.org @ 2012-10-27 23:09 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
davem at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |davem at gcc dot gnu.org
--- Comment #20 from davem at gcc dot gnu.org 2012-10-27 23:08:50 UTC ---
This issue still exists in mainline, there seems to be no objection to Andrey's
suggested fix, could someone please commit it?
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (20 preceding siblings ...)
2012-10-27 23:09 ` [Bug target/51106] [4.6 " davem at gcc dot gnu.org
@ 2012-10-28 18:17 ` abel at gcc dot gnu.org
2012-11-27 15:46 ` dominiq at lps dot ens.fr
` (7 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: abel at gcc dot gnu.org @ 2012-10-28 18:17 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #21 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-10-28 18:17:16 UTC ---
(In reply to comment #20)
> This issue still exists in mainline, there seems to be no objection to Andrey's
> suggested fix, could someone please commit it?
Not quite, the last message was
http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00161.html and then there was no
consensus about the way to proceed.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (21 preceding siblings ...)
2012-10-28 18:17 ` abel at gcc dot gnu.org
@ 2012-11-27 15:46 ` dominiq at lps dot ens.fr
2013-03-22 14:44 ` jakub at gcc dot gnu.org
` (6 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: dominiq at lps dot ens.fr @ 2012-11-27 15:46 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
--- Comment #22 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-11-27 15:46:07 UTC ---
Does revision 193846 fix this PR or not?
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (22 preceding siblings ...)
2012-11-27 15:46 ` dominiq at lps dot ens.fr
@ 2013-03-22 14:44 ` jakub at gcc dot gnu.org
2013-05-31 10:58 ` jakub at gcc dot gnu.org
` (5 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-03-22 14:44 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.8.0 |4.8.1
--- Comment #23 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-03-22 14:43:34 UTC ---
GCC 4.8.0 is being released, adjusting target milestone.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (23 preceding siblings ...)
2013-03-22 14:44 ` jakub at gcc dot gnu.org
@ 2013-05-31 10:58 ` jakub at gcc dot gnu.org
2013-10-16 9:51 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-05-31 10:58 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.8.1 |4.8.2
--- Comment #24 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.1 has been released.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (24 preceding siblings ...)
2013-05-31 10:58 ` jakub at gcc dot gnu.org
@ 2013-10-16 9:51 ` jakub at gcc dot gnu.org
2014-05-22 9:03 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-10-16 9:51 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.8.2 |4.8.3
--- Comment #25 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.2 has been released.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (25 preceding siblings ...)
2013-10-16 9:51 ` jakub at gcc dot gnu.org
@ 2014-05-22 9:03 ` rguenth at gcc dot gnu.org
2014-12-19 13:30 ` jakub at gcc dot gnu.org
` (2 subsequent siblings)
29 siblings, 0 replies; 31+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-05-22 9:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.8.3 |4.8.4
--- Comment #26 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 4.8.3 is being released, adjusting target milestone.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (26 preceding siblings ...)
2014-05-22 9:03 ` rguenth at gcc dot gnu.org
@ 2014-12-19 13:30 ` jakub at gcc dot gnu.org
2015-06-23 8:40 ` rguenth at gcc dot gnu.org
2021-08-08 6:05 ` pinskia at gcc dot gnu.org
29 siblings, 0 replies; 31+ messages in thread
From: jakub at gcc dot gnu.org @ 2014-12-19 13:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.8.4 |4.8.5
--- Comment #27 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 4.8.4 has been released.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (27 preceding siblings ...)
2014-12-19 13:30 ` jakub at gcc dot gnu.org
@ 2015-06-23 8:40 ` rguenth at gcc dot gnu.org
2021-08-08 6:05 ` pinskia at gcc dot gnu.org
29 siblings, 0 replies; 31+ messages in thread
From: rguenth at gcc dot gnu.org @ 2015-06-23 8:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
Target Milestone|4.8.5 |4.7.0
--- Comment #28 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed according to dup.
^ permalink raw reply [flat|nested] 31+ messages in thread* [Bug target/51106] [4.6 Regression] ICE in move_insn, at haifa-sched.c:2314
2011-11-12 14:06 [Bug target/51106] New: [4.5 regression] ICE in move_insn, at haifa-sched.c:2314 rl at hellgate dot ch
` (28 preceding siblings ...)
2015-06-23 8:40 ` rguenth at gcc dot gnu.org
@ 2021-08-08 6:05 ` pinskia at gcc dot gnu.org
29 siblings, 0 replies; 31+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-08 6:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51106
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://gcc.gnu.org/bugzill
| |a/show_bug.cgi?id=52650
Resolution|FIXED |DUPLICATE
--- Comment #29 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This is really a dup of bug 52650.
*** This bug has been marked as a duplicate of bug 52650 ***
^ permalink raw reply [flat|nested] 31+ messages in thread